-
-
Notifications
You must be signed in to change notification settings - Fork 364
feat(DataTableDynamicContext): add UseCache parameter #5389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's Guide by SourceryThis pull request introduces a Updated class diagram for DataTableDynamicContextclassDiagram
class DataTableDynamicContext {
-Action~DataTableDynamicContext, ITableColumn~? AddAttributesCallback
+bool UseCache
-Dictionary~DataRow, IDynamicObject~ RowToItemCache
+IEnumerable~IDynamicObject~ GetItems()
}
note for DataTableDynamicContext "Added UseCache property to control internal caching"
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider if
UseCacheshould be configurable via a cascading parameter instead of directly on the context.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5389 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 645 645
Lines 29254 29261 +7
Branches 4131 4132 +1
=========================================
+ Hits 29254 29261 +7 ☔ View full report in Codecov by Sentry. |
fbe4b46 to
2412354
Compare
add UseCache parameter
Summary of the changes (Less than 80 chars)
简单描述你更改了什么, 不超过80个字符;如果有关联 Issue 请在下方填写相关编号
Description
fixes #5384
Regression?
[If yes, specify the version the behavior has regressed from]
[是否影响老版本]
Risk
[Justify the selection above]
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Introduced a
UseCacheparameter to theDataTableDynamicContextto allow developers to control whether the internal cache is used when retrieving items, providing more flexibility in data handling.New Features:
UseCacheparameter to theDataTableDynamicContextclass to control whether the internal cache is used when retrieving items.Enhancements:
GetItemsmethod now checks theUseCacheproperty to determine whether to use the cached items or rebuild them.