-
-
Notifications
You must be signed in to change notification settings - Fork 364
feat(DateTimePicker): add FirstDayOfWeek parameter #5417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-Authored-By: cervinkamichal0 <[email protected]>
…icker # Conflicts: # src/BootstrapBlazor/BootstrapBlazor.csproj
Reviewer's Guide by SourceryThis pull request introduces a new Updated class diagram for DatePickerBodyclassDiagram
class DatePickerBody {
DateTime StartDate
bool EnableDisabledDaysCache
DayOfWeek FirstDayOfWeek
List<string> WeekLists
+OnParametersSet()
+ShouldRender()
-GetWeekList()
}
note for DatePickerBody "Added FirstDayOfWeek property and GetWeekList method"
Updated class diagram for DateTimePickerclassDiagram
class DateTimePicker {
string? Format
string? TimeFormat
DayOfWeek FirstDayOfWeek
}
note for DateTimePicker "Added FirstDayOfWeek property"
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider adding a globalization test to ensure the
FirstDayOfWeekparameter works correctly across different cultures. - The code introduces a new parameter
FirstDayOfWeek; ensure it's documented in the component's documentation page.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5417 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 644 644
Lines 29350 29359 +9
Branches 4129 4128 -1
=========================================
+ Hits 29350 29359 +9 ☔ View full report in Codecov by Sentry. |
add FirstDayOfWeek parameter
Summary of the changes (Less than 80 chars)
简单描述你更改了什么, 不超过80个字符;如果有关联 Issue 请在下方填写相关编号
Description
fixes #5414
Regression?
[If yes, specify the version the behavior has regressed from]
[是否影响老版本]
Risk
[Justify the selection above]
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
This pull request introduces a new
FirstDayOfWeekparameter to theDateTimePickercomponent, allowing users to customize the first day of the week in the calendar. The implementation includes modifications to theDatePickerBodycomponent to handle the new parameter and a unit test to ensure the functionality works as expected.New Features:
FirstDayOfWeekparameter to theDateTimePickercomponent to allow users to configure the first day of the week displayed in the calendar.Enhancements:
FirstDayOfWeekparameter.Tests:
FirstDayOfWeekparameter functionality.