fix(Textarea): adding new functionality to handle Shift + Enter #5611

h2ls · 2025-03-12T08:27:15Z

Link issues

Summary By Copilot

This pull request includes several changes to the BootstrapBlazor components, focusing on improving the code readability by translating comments from Chinese to English and adding new functionality to handle Shift + Enter key presses in the input components.

Key changes:

Functionality Enhancements:

src/BootstrapBlazor/Components/Input/BootstrapInput.razor.js: Added logic to handle Shift + Enter key presses, preventing the default action if Shift is held and data-bb-shift-enter attribute is set to true.

Code Readability Improvements:

src/BootstrapBlazor/Components/Input/BootstrapInputBase.cs: Translated all comments from Chinese to English to improve code readability and maintainability. [1] [2] [3] [4] [5] [6]
src/BootstrapBlazor/Components/Textarea/Textarea.razor.cs: Translated comments from Chinese to English for better clarity.

Regression?

Yes
No

Risk

High
Medium
Low

Verification

Manual (required)
Automated

Packaging changes reviewed?

Yes
No
N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

Doc is updated/provided or not needed
Demo is updated/provided or not needed
Merge the latest code from the main branch

…allback - Add `hasNoModifiers` helper to check for Ctrl/Shift/Alt/Meta keys - Update Enter key handling in `handleKeyUp` to ignore modifier combinations - Retain existing Escape key logic

sourcery-ai · 2025-03-12T08:27:21Z

Reviewer's Guide by Sourcery

This pull request modifies the keyup event handler for the textarea component to ensure that the Enter key callback is only triggered when the Enter key is pressed alone, without any modifier keys (Ctrl, Shift, Alt, Meta). A new helper function hasNoModifiers was introduced to check for the absence of modifier keys.

Sequence diagram for Enter key press with and without modifiers

sequenceDiagram
    participant User
    participant textarea
    participant BootstrapInput.razor.js
    participant invoke

    User->>textarea: Presses Enter key (no modifiers)
    textarea-->>BootstrapInput.razor.js: keyup event
    BootstrapInput.razor.js->>BootstrapInput.razor.js: hasNoModifiers(e) == true
    BootstrapInput.razor.js->>invoke: invokeMethodAsync(enterCallbackMethod, el.value)
    invoke-->>textarea: Callback triggered

    User->>textarea: Presses Ctrl+Enter
    textarea-->>BootstrapInput.razor.js: keyup event
    BootstrapInput.razor.js->>BootstrapInput.razor.js: hasNoModifiers(e) == false
    BootstrapInput.razor.js-->>textarea: Callback not triggered

File-Level Changes

Change	Details	Files
Implemented a modifier key check to ensure the Enter key callback is triggered only when the Enter key is pressed without any modifier keys.	Added a `hasNoModifiers` helper function to detect if Ctrl, Shift, Alt, or Meta keys are pressed. Modified the `keyup` event handler to include the modifier check before triggering the Enter key callback.	`src/BootstrapBlazor/Components/Input/BootstrapInput.razor.js`

Assessment against linked issues

Issue	Objective	Addressed	Explanation
#5610	The Enter key callback should only fire when the Enter key is pressed alone (without Ctrl/Shift/Alt/Meta keys).	✅

Possibly linked issues

bug(textarea): Unexpected Enter Key Triggering with Modifier Keys #5610: The PR fixes the bug described in the issue by adding a modifier key check to the Enter key callback logic.
bug(textarea): Unexpected Enter Key Triggering with Modifier Keys #5610: The PR fixes the bug described in the issue. The PR adds a check to only trigger the event if no modifier keys are pressed.
bug(textarea): Unexpected Enter Key Triggering with Modifier Keys #5610: The PR fixes the issue where the Enter key callback was not firing when the numpad Enter key was pressed.

Tips and commands

Interacting with Sourcery

Trigger a new review: Comment @sourcery-ai review on the pull request.
Continue discussions: Reply directly to Sourcery's review comments.
Generate a GitHub issue from a review comment: Ask Sourcery to create an
issue from a review comment by replying to it. You can also reply to a
review comment with @sourcery-ai issue to create an issue from it.
Generate a pull request title: Write @sourcery-ai anywhere in the pull
request title to generate a title at any time. You can also comment
@sourcery-ai title on the pull request to (re-)generate the title at any time.
Generate a pull request summary: Write @sourcery-ai summary anywhere in
the pull request body to generate a PR summary at any time exactly where you
want it. You can also comment @sourcery-ai summary on the pull request to
(re-)generate the summary at any time.
Generate reviewer's guide: Comment @sourcery-ai guide on the pull
request to (re-)generate the reviewer's guide at any time.
Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
pull request to resolve all Sourcery comments. Useful if you've already
addressed all the comments and don't want to see them anymore.
Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
request to dismiss all existing Sourcery reviews. Especially useful if you
want to start fresh with a new review - don't forget to comment
@sourcery-ai review to trigger a new review!
Generate a plan of action for an issue: Comment @sourcery-ai plan on
an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

Enable or disable review features such as the Sourcery-generated pull request
summary, the reviewer's guide, and others.
Change the review language.
Add, remove or edit custom review instructions.
Adjust other review settings.

Getting Help

Contact our support team for questions or feedback.
Visit our documentation for detailed guides and information.
Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

bb-auto · 2025-03-12T08:27:21Z

Thanks for your PR, @h2ls. Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

sourcery-ai

Hey @h2ls - I've reviewed your changes - here's some feedback:

Overall Comments:

Consider adding a comment to explain why hasNoModifiers is needed.

Here's what I looked at during the review

🟢 General issues: all looks good
🟢 Security: all looks good
🟢 Testing: all looks good
🟢 Complexity: all looks good
🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

codecov · 2025-03-12T08:49:09Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (2cf8af4) to head (41cb909).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff            @@
##              main     #5611   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          649       649           
  Lines        29622     29622           
  Branches      4165      4165           
=========================================
  Hits         29622     29622

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

h2ls · 2025-03-13T00:43:54Z

@dotnet-policy-service agree

h2ls · 2025-03-13T00:45:53Z

@microsoft-github-policy-service agree

ArgoZhang · 2025-03-13T01:40:27Z

@sourcery-ai review

fix(keyup): prevent modifier key combinations from triggering Enter c…

acfc7d4

…allback - Add `hasNoModifiers` helper to check for Ctrl/Shift/Alt/Meta keys - Update Enter key handling in `handleKeyUp` to ignore modifier combinations - Retain existing Escape key logic

bb-auto bot requested a review from ArgoZhang March 12, 2025 08:27

sourcery-ai bot previously approved these changes Mar 12, 2025

View reviewed changes

h2ls changed the title ~~fix(textarea): Ensure Enter key callback fires only when pressed alone~~ fix(Textarea): Ensure Enter key callback fires only when pressed alone Mar 12, 2025

ArgoZhang linked an issue Mar 13, 2025 that may be closed by this pull request

bug(Textarea): OnEnterAsync 事件缺少是否按下 Shift 参数 #5609

Closed

1 task

doc: 更改注释为英文

51e5d77

ArgoZhang dismissed sourcery-ai[bot]’s stale review via 51e5d77 March 13, 2025 00:46

h2ls self-assigned this Mar 13, 2025

ArgoZhang added 5 commits March 13, 2025 09:08

doc: 更新注释为英语

d69d352

refactor: 更新逻辑

acfc4c4

revert: 重置代码

8294e39

refactor: 使用 js 解决问题保证效率

b9d9473

doc: 移除不使用的命名空间

a0310a4

ArgoZhang previously approved these changes Mar 13, 2025

View reviewed changes

bb-auto bot assigned ArgoZhang and unassigned h2ls Mar 13, 2025

bb-auto bot added the bug Something isn't working label Mar 13, 2025

bb-auto bot added this to the v9.4.0 milestone Mar 13, 2025

ArgoZhang changed the title ~~fix(Textarea): Ensure Enter key callback fires only when pressed alone~~ fix(Textarea): adding new functionality to handle Shift + Enter Mar 13, 2025

chore: bump version 9.4.9-beta04

41cb909

ArgoZhang dismissed their stale review via 41cb909 March 13, 2025 01:41

ArgoZhang approved these changes Mar 13, 2025

View reviewed changes

ArgoZhang merged commit 0bab5a6 into main Mar 13, 2025
6 checks passed

ArgoZhang deleted the lee/handleKeyUp branch March 13, 2025 01:47

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix(Textarea): adding new functionality to handle Shift + Enter #5611

fix(Textarea): adding new functionality to handle Shift + Enter #5611

Uh oh!

h2ls commented Mar 12, 2025 •

edited by ArgoZhang

Loading

Uh oh!

sourcery-ai bot commented Mar 12, 2025 •

edited

Loading

Interacting with Sourcery

Customizing Your Experience

Getting Help

Uh oh!

bb-auto bot commented Mar 12, 2025

Uh oh!

sourcery-ai bot left a comment

Uh oh!

codecov bot commented Mar 12, 2025 •

edited

Loading

Uh oh!

h2ls commented Mar 13, 2025

Uh oh!

h2ls commented Mar 13, 2025

Uh oh!

ArgoZhang commented Mar 13, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

fix(Textarea): adding new functionality to handle Shift + Enter #5611

fix(Textarea): adding new functionality to handle Shift + Enter #5611

Uh oh!

Conversation

h2ls commented Mar 12, 2025 • edited by ArgoZhang Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Link issues

Summary By Copilot

Key changes:

Functionality Enhancements:

Code Readability Improvements:

Regression?

Risk

Verification

Packaging changes reviewed?

☑️ Self Check before Merge

Uh oh!

sourcery-ai bot commented Mar 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer's Guide by Sourcery

Sequence diagram for Enter key press with and without modifiers

File-Level Changes

Assessment against linked issues

Possibly linked issues

Interacting with Sourcery

Customizing Your Experience

Getting Help

Uh oh!

bb-auto bot commented Mar 12, 2025

Uh oh!

sourcery-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Mar 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

h2ls commented Mar 13, 2025

Uh oh!

h2ls commented Mar 13, 2025

Uh oh!

ArgoZhang commented Mar 13, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

h2ls commented Mar 12, 2025 •

edited by ArgoZhang

Loading

sourcery-ai bot commented Mar 12, 2025 •

edited

Loading

codecov bot commented Mar 12, 2025 •

edited

Loading