feat(Layout): support TabStyle/ShowToolbar parameter #5703
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Reviewer's Guide by SourceryThis pull request introduces enhancements to the Sequence diagram for adding a tab itemsequenceDiagram
participant Layout
participant Tab
participant TabItem
Layout->>Tab: Renders Tab component
Tab->>Tab: AddTabItem(url)
activate Tab
Tab->>Tab: Creates parameters dictionary with url
Tab->>TabItem: Creates TabItem with parameters
deactivate Tab
Updated class diagram for the Layout componentclassDiagram
class Layout {
TabStyle TabStyle
bool ShowToolbar
RenderFragment ToolbarTemplate
bool ShowFullscreenToolbarButton
string FullscreenToolbarButtonIcon
string FullscreenToolbarTooltipText
bool ShowRefreshToolbarButton
string RefreshToolbarButtonIcon
string RefreshToolbarTooltipText
Func~Task~ OnToolbarRefreshCallback
}
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Hey @ArgoZhang - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider adding a demo page to showcase the new
Layoutcomponent features. - The added parameters in
Layout.razor.cscould benefit from XML documentation comments explaining their purpose.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟡 Testing: 1 issue found
- 🟡 Complexity: 1 issue found
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5703 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 657 657
Lines 29806 29818 +12
Branches 4225 4225
=========================================
+ Hits 29806 29818 +12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link issues
fixes #5702
Summary By Copilot
This pull request includes several changes to the
BootstrapBlazorproject, focusing on updating the version, enhancing theLayoutcomponent, and modifying theTabcomponent. The most important changes are summarized below:Version Update:
9.5.0-beta13to9.5.0-beta15inBootstrapBlazor.csproj.Layout Component Enhancements:
Layoutcomponent to support toolbar functionality, includingTabStyle,ShowToolbar,ToolbarTemplate,ShowRefreshToolbarButton,ShowFullscreenToolbarButton,RefreshToolbarButtonIcon,FullscreenToolbarButtonIcon,RefreshToolbarTooltipText,FullscreenToolbarTooltipText, andOnToolbarRefreshCallback.Layout.razorto include new toolbar-related attributes in theTabcomponent.Tab Component Modifications:
AddTabItemmethod inTab.razor.csto initialize theparametersdictionary with theurlvalue. [1] [2]z-indexproperties fromTab.razor.scssto simplify the styling. [1] [2]Unit Tests:
TabStyle_OkinLayoutTest.csto verify the correct rendering of theLayoutcomponent with various toolbar configurations.Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Adds support for toolbar customization to the Layout component, including options for TabStyle, showing/hiding the toolbar, custom toolbar templates, and refresh/fullscreen buttons.
Enhancements: