chore(Action): update action add any-of-labels config #5720
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Reviewer's Guide by SourceryThis pull request updates the No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Hey @ArgoZhang - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider whether the
any-of-labelsconfiguration should be configurable via repository settings instead of hardcoding it in the workflow.
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Comment on lines
+18
to
+19
| stale-issue-message: "Since the issue was labeled with `invalid`, but no response in 2 days. This issue will be closed. If you have any questions, you can comment and reply. \r 由于该 issue 被标记为不合规工程，却 2 天未收到回应。现关闭 issue，若有任何问题，可评论回复" | ||
| close-issue-message: "Since the issue was labeled with `need-repro-project`, but no response in 2 days. This issue will be closed. If you have any questions, you can comment and reply. \r 由于该 issue 被标记为需要复现工程，却 2 天未收到回应。现关闭 issue，若有任何问题，可评论回复" |
Contributor
There was a problem hiding this comment.
question: Review the use of '\r' in the message strings.
The added carriage return ('\r') might affect formatting. Consider whether a newline ('\n') might be more appropriate, or confirm that the carriage return produces the desired layout in all environments.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5720 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 657 657
Lines 29830 29830
Branches 4229 4229
=========================================
Hits 29830 29830 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link issues
fixes #5719
Summary By Copilot
This pull request includes updates to the
.github/workflows/close-stale-issues.ymlfile to modify the schedule for closing inactive issues and to adjust the configuration for handling stale issues. The most important changes include updating the cron schedule and refining the labels and messages used for stale issues.Changes to the cron schedule:
.github/workflows/close-stale-issues.yml: Changed the cron schedule from "30 2 * * *" to "0 1 * * *" to adjust the timing for closing inactive issues.Refinements to stale issue handling:
.github/workflows/close-stale-issues.yml: Addedany-of-labelsparameter with values "invalid,need-repro-project" to specify labels that trigger the stale issue process..github/workflows/close-stale-issues.yml: Updated thestale-issue-messageandclose-issue-messageto include a carriage return for better formatting.Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Updates the close-stale-issues workflow to run at a different time and to consider issues with the 'invalid' or 'need-repro-project' labels as stale.
CI: