feat(Table): add col-line-no style on Line column #5851
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Reviewer's Guide by SourceryThis pull request introduces styling and class updates to the No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the Table component by introducing a dedicated CSS class for line number columns to support specific styling requirements.
- Added the "col-line-no" class to the LineCellClassString property in Table.razor.cs.
- Updated the class building chain to include alignment classes alongside the new line number styling.
Files not reviewed (1)
- src/BootstrapBlazor/Components/Table/Table.razor.scss: Language not supported
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Hey @ArgoZhang - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider adding a more descriptive name to the
col-line-noclass to better reflect its purpose.
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
| @@ -1,4 +1,4 @@ | |||
| .table-container { | |||
| .table-container { | |||
Contributor
There was a problem hiding this comment.
nitpick (bug_risk): Possible unintended Byte Order Mark in file.
It appears that an invisible character (likely a BOM) was introduced before .table-container. Confirm that this was intentional and that it doesn’t cause encoding problems in environments that might not expect it.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5851 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 660 660
Lines 30138 30139 +1
Branches 4257 4257
=========================================
+ Hits 30138 30139 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ArgoZhang
added a commit
that referenced
this pull request
Apr 22, 2025
* refactor: 增加行号样式 * refactor: 增加 col-line-no 样式 * refactor: 增加间隙
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link issues
fixes #5850
Summary By Copilot
This pull request introduces styling and class updates to the
Tablecomponent in theBootstrapBlazorlibrary. The changes primarily focus on adding a new class for line number columns and updating related styles.Updates to the
Tablecomponent:Class Addition for Line Number Columns:
col-line-noclass to theLineCellClassStringproperty inTable.razor.csto enable specific styling for line number columns.Styling Adjustments:
.table-containerclass inTable.razor.scss(though the change appears to be a minor text encoding or formatting update)..col-line-noclass within.table-excelto adjust padding for line number cells.Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Add styling for line number columns in the Table component
New Features:
Enhancements: