Skip to content

feat(IFrame): add attributes support #6160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 5, 2025
Merged

feat(IFrame): add attributes support #6160

merged 1 commit into from
Jun 5, 2025

Conversation

@ArgoZhang
Copy link
Member

@ArgoZhang ArgoZhang commented Jun 5, 2025 •
edited by sourcery-ai bot
Loading

Link issues

fixes #6159

Summary By Copilot

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

New Features:

  • Enable passing custom HTML attributes to IFrame elements through AdditionalAttributes

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Jun 5, 2025 •
edited
Loading

Reviewer's Guide

This PR enhances the IFrame component by enabling support for arbitrary HTML attributes through Blazor’s CaptureUnmatchedValues feature and updating the iframe markup accordingly.

File-Level Changes

Change Details Files
Enable arbitrary HTML attributes support in the IFrame component
  • Added @attributes directive to iframe markup
  • Removed hardcoded frameborder attribute
 src/BootstrapBlazor/Components/IFrame/IFrame.razor

Assessment against linked issues

Issue Objective Addressed Explanation
#6159 Add support for attributes to the IFrame component. ✅

Possibly linked issues

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@bb-auto bb-auto bot added the enhancement New feature or request label Jun 5, 2025
@bb-auto bb-auto bot added this to the 9.7.0 milestone Jun 5, 2025
@ArgoZhang ArgoZhang merged commit 406eb19 into main Jun 5, 2025
3 checks passed
@ArgoZhang ArgoZhang deleted the dev-iframe branch June 5, 2025 05:08
@codecov
Copy link

codecov bot commented Jun 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.99%. Comparing base (16cc7d4) to head (1c2ac8d).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #6160   +/-   ##
=======================================
  Coverage   99.99%   99.99%           
=======================================
  Files         704      704           
  Lines       31099    31099           
  Branches     4395     4395           
=======================================
  Hits        31098    31098           
  Partials        1        1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

sourcery-ai[bot]
sourcery-ai bot approved these changes Jun 5, 2025
View reviewed changes
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ArgoZhang - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟡 General issues: 1 issue found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good
Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

src/BootstrapBlazor/Components/IFrame/IFrame.razor
@attribute [BootstrapModuleAutoLoader(JSObjectReference = true)]

<iframe id="@Id" src="@Src" frameborder="0" class="@ClassString"></iframe>
<iframe @attributes="AdditionalAttributes" id="@Id" src="@Src" class="@ClassString"></iframe>
Copy link
Contributor

@sourcery-ai sourcery-ai bot Jun 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: Add a default title attribute for accessibility

Introduce a Title parameter or set a default title to ensure the iframe is accessible when no title is provided via AdditionalAttributes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] approved these changes

Assignees

@ArgoZhang ArgoZhang

Labels

enhancement New feature or request

Projects

None yet

Milestone

v9.7.0

Development

Successfully merging this pull request may close these issues.

feat(IFrame): add attributes support

2 participants

@ArgoZhang