feat(ErrorLogger): add EnableILogger parameter #6246
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Reviewer's GuideAdds a configurable ILogger toggle to the error-logging components and exposes it through layout and global options, updating the render trees, dependency injection, and tests accordingly. Class diagram for updated error logging componentsclassDiagram
class IErrorLogger {
+bool ShowToast
+bool EnableILogger
+string ToastTitle
+RenderFragment ErrorContent
+RenderFragment ChildContent
+Func<Exception, Task> OnErrorHandleAsync
+Func<Task> OnInitializedCallback
}
class ErrorLogger {
+bool ShowToast
+bool EnableILogger
+string ToastTitle
+RenderFragment ErrorContent
+RenderFragment ChildContent
+Func<Exception, Task> OnErrorHandleAsync
+Func<Task> OnInitializedCallback
}
class BootstrapBlazorErrorBoundary {
+bool ShowToast
+bool EnableILogger
+string ToastTitle
+RenderFragment ErrorContent
+RenderFragment ChildContent
+Task OnErrorAsync(Exception)
}
class Layout {
+bool? ShowErrorLoggerToast
+bool? EnableErrorLoggerILogger
-bool _showToast
-bool _enableILogger
}
class BootstrapBlazorOptions {
+bool ShowErrorLoggerToast
+bool EnableErrorLoggerILogger
}
ErrorLogger --|> IErrorLogger
ErrorLogger o-- BootstrapBlazorErrorBoundary : uses
Layout o-- ErrorLogger : uses
Layout o-- BootstrapBlazorOptions : uses
BootstrapBlazorErrorBoundary o-- ILogger : injects
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Hey @ArgoZhang - I've reviewed your changes and they look great!
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location> `src/BootstrapBlazor/Components/Layout/Layout.razor:129` </location>
<code_context>
else
{
<ErrorLogger EnableErrorLogger="@_enableErrorLogger" ShowToast="@_showToast" ToastTitle="@ErrorLoggerToastTitle"
- OnErrorHandleAsync="OnErrorHandleAsync" OnInitializedCallback="OnErrorLoggerInitialized">
+ EnableILogger="@_enableILogger" OnErrorHandleAsync="OnErrorHandleAsync" OnInitializedCallback="OnErrorLoggerInitialized">
</code_context>
<issue_to_address>
Unrecognized ‘EnableErrorLogger’ attribute on ErrorLogger component
Remove the EnableErrorLogger attribute or replace it with EnableILogger to match the component's parameters.
</issue_to_address>
### Comment 2
<location> `src/BootstrapBlazor/Components/ErrorLogger/ErrorLogger.cs:121` </location>
<code_context>
builder.AddAttribute(3, nameof(BootstrapBlazorErrorBoundary.ToastTitle), ToastTitle);
builder.AddAttribute(4, nameof(BootstrapBlazorErrorBoundary.ErrorContent), ErrorContent);
builder.AddAttribute(5, nameof(BootstrapBlazorErrorBoundary.ChildContent), ChildContent);
+ builder.AddAttribute(6, nameof(BootstrapBlazorErrorBoundary.EnableILogger), EnableILogger);
builder.AddComponentReferenceCapture(5, obj => _errorBoundary = (BootstrapBlazorErrorBoundary)obj);
builder.CloseComponent();
</code_context>
<issue_to_address>
RenderTreeBuilder sequence numbers are non-monotonic and duplicated
The AddComponentReferenceCapture should use a unique, higher sequence number (e.g., 7) to avoid conflicts with previous attributes.
</issue_to_address>
<suggested_fix>
<<<<<<< SEARCH
builder.AddComponentReferenceCapture(5, obj => _errorBoundary = (BootstrapBlazorErrorBoundary)obj);
=======
builder.AddComponentReferenceCapture(7, obj => _errorBoundary = (BootstrapBlazorErrorBoundary)obj);
>>>>>>> REPLACE
</suggested_fix>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6246 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 704 704
Lines 31121 31130 +9
Branches 4400 4402 +2
=========================================
+ Hits 31121 31130 +9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link issues
fixes #6245
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Introduce a configurable flag to enable or disable the built-in error logging behavior, expose it through component parameters and global options, and update the layout and tests accordingly
New Features:
Bug Fixes:
Tests: