doc(Select): update ShowSwal sample code #6248
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Reviewer's GuideThis PR refactors the Select demo to leverage the ShowSwal confirmation feature by replacing the OnBeforeSelectedItemChange handler, enriches the demo with an ignored descriptive section, and adds new localization entries for SwalTitle, SwalContent, and SwalFooter in both en-US and zh-CN locales. Class diagram for Select component demo updateclassDiagram
class Select {
+TValue
+Items
+ShowSwal: bool
+SwalTitle: string
+SwalContent: string
+SwalFooter: string
}
%% OnBeforeSelectedItemChange handler removed from usage in demo
class DemoBlock {
+Title
+Introduction
+Name
}
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6248 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 704 704
Lines 31130 31130
Branches 4402 4402
=========================================
Hits 31130 31130
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Hey @ArgoZhang - I've reviewed your changes and they look great!
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location> `src/BootstrapBlazor.Server/Components/Samples/Selects.razor:369` </location>
<code_context>
Name="ConfirmSelect">
+ <section ignore>
+ <ul class="ul-demo">
+ <li>@((MarkupString)Localizer["SelectConfifrmSelectDesc1"].Value)</li>
+ <li>@((MarkupString)Localizer["SelectConfifrmSelectDesc2"].Value)</li>
+ </ul>
+ </section>
</code_context>
<issue_to_address>
Typo in localization key names
"Confirm" is misspelled as "Confifrm" in the localization keys. Please update to match the correct spelling and the JSON resource entries.
</issue_to_address>
<suggested_fix>
<<<<<<< SEARCH
<li>@((MarkupString)Localizer["SelectConfifrmSelectDesc1"].Value)</li>
<li>@((MarkupString)Localizer["SelectConfifrmSelectDesc2"].Value)</li>
=======
<li>@((MarkupString)Localizer["SelectConfirmSelectDesc1"].Value)</li>
<li>@((MarkupString)Localizer["SelectConfirmSelectDesc2"].Value)</li>
>>>>>>> REPLACE
</suggested_fix>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Comment on lines
+369
to
+370
| <li>@((MarkupString)Localizer["SelectConfifrmSelectDesc1"].Value)</li> | ||
| <li>@((MarkupString)Localizer["SelectConfifrmSelectDesc2"].Value)</li> |
Contributor
There was a problem hiding this comment.
issue (typo): Typo in localization key names
"Confirm" is misspelled as "Confifrm" in the localization keys. Please update to match the correct spelling and the JSON resource entries.
Suggested change
| <li>@((MarkupString)Localizer["SelectConfifrmSelectDesc1"].Value)</li> | |
| <li>@((MarkupString)Localizer["SelectConfifrmSelectDesc2"].Value)</li> | |
| <li>@((MarkupString)Localizer["SelectConfirmSelectDesc1"].Value)</li> | |
| <li>@((MarkupString)Localizer["SelectConfirmSelectDesc2"].Value)</li> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link issues
fixes #6247
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Update the Select component demo to showcase the new ShowSwal option by replacing the OnBeforeSelectedItemChange handler with ShowSwal and adding an explanatory ignore-only section; sync corresponding localization entries in English and Chinese.
Enhancements:
Documentation: