-
-
Notifications
You must be signed in to change notification settings - Fork 363
feat(ITcpSocketClient): add ConnectAsync extension method #6273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's GuideIntroduces a new ConnectAsync extension on ITcpSocketClient that parses and validates host/port strings before delegating to the endpoint-based ConnectAsync, removes the deprecated string-based interface overload, and corrects sample text in the SocketFactories component. Class diagram for ITcpSocketClientExtensions changesclassDiagram
class ITcpSocketClientExtensions {
+ValueTask<bool> SendAsync(ITcpSocketClient client, string content, Encoding? encoding = null, CancellationToken token = default)
+ValueTask<bool> ConnectAsync(ITcpSocketClient client, string ipString, int port, CancellationToken token = default)
}
ITcpSocketClientExtensions ..> ITcpSocketClient : extension methods
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes and they look great!
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6273 +/- ##
===========================================
- Coverage 100.00% 99.99% -0.01%
===========================================
Files 712 712
Lines 31383 31397 +14
Branches 4433 4437 +4
===========================================
+ Hits 31383 31396 +13
- Partials 0 1 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Link issues
fixes #6272
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Introduce a ConnectAsync extension on ITcpSocketClientExtensions to support connecting by IP string and port with input validation, remove the legacy interface overload, and correct sample documentation text.
Enhancements:
Documentation: