Skip to content

Conversation

@ArgoZhang
Copy link
Member

@ArgoZhang ArgoZhang commented Jun 21, 2025

Link issues

fixes #6272

Summary By Copilot

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Introduce a ConnectAsync extension on ITcpSocketClientExtensions to support connecting by IP string and port with input validation, remove the legacy interface overload, and correct sample documentation text.

Enhancements:

  • Move the existing host-and-port ConnectAsync overload from the interface into a new extension method on ITcpSocketClientExtensions with IP string parsing and port validation.

Documentation:

  • Fix Chinese description in SocketFactories sample from '内置数据库处理器' to '内置数据处理器'.

@bb-auto bb-auto bot added the enhancement New feature or request label Jun 21, 2025
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Jun 21, 2025

Reviewer's Guide

Introduces a new ConnectAsync extension on ITcpSocketClient that parses and validates host/port strings before delegating to the endpoint-based ConnectAsync, removes the deprecated string-based interface overload, and corrects sample text in the SocketFactories component.

Class diagram for ITcpSocketClientExtensions changes

classDiagram
    class ITcpSocketClientExtensions {
        +ValueTask<bool> SendAsync(ITcpSocketClient client, string content, Encoding? encoding = null, CancellationToken token = default)
        +ValueTask<bool> ConnectAsync(ITcpSocketClient client, string ipString, int port, CancellationToken token = default)
    }
    ITcpSocketClientExtensions ..> ITcpSocketClient : extension methods
Loading

File-Level Changes

Change Details Files
Add ConnectAsync extension method with validation and parsing
  • Include System.Net namespace
  • Implement ConnectAsync(this ITcpSocketClient, string ipString, int port, CancellationToken) as extension
  • Validate ipString for null/empty and port range with ArgumentNullException/ArgumentOutOfRangeException
  • Parse ipString to IPAddress or throw InvalidOperationException on failure
  • Create IPEndPoint and call the existing ConnectAsync(endpoint, token)
  • Provide XML documentation for the new overload
src/BootstrapBlazor/Extensions/ITcpSocketClientExtensions.cs
Remove deprecated string-based ConnectAsync from interface
  • Delete ConnectAsync(string host, int port, CancellationToken) signature
  • Remove its associated XML documentation
src/BootstrapBlazor/Services/TcpSocket/ITcpSocketClient.cs
Fix terminology in sample component
  • Update description text from “内置数据库处理器” to “内置数据处理器”
src/BootstrapBlazor.Server/Components/Samples/SocketFactories.razor

Assessment against linked issues

Issue Objective Addressed Explanation
#6272 Add a ConnectAsync extension method to ITcpSocketClient.

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@bb-auto bb-auto bot added this to the 9.7.0 milestone Jun 21, 2025
sourcery-ai[bot]
sourcery-ai bot previously approved these changes Jun 21, 2025
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ArgoZhang - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@ArgoZhang ArgoZhang merged commit 4fdc480 into main Jun 21, 2025
3 checks passed
@ArgoZhang ArgoZhang deleted the feat-socket branch June 21, 2025 12:38
@codecov
Copy link

codecov bot commented Jun 21, 2025

Codecov Report

Attention: Patch coverage is 96.29630% with 1 line in your changes missing coverage. Please review.

Project coverage is 99.99%. Comparing base (ea1c142) to head (dd278cd).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/BootstrapBlazor/Utils/Utility.cs 94.73% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##              main    #6273      +/-   ##
===========================================
- Coverage   100.00%   99.99%   -0.01%     
===========================================
  Files          712      712              
  Lines        31383    31397      +14     
  Branches      4433     4437       +4     
===========================================
+ Hits         31383    31396      +13     
- Partials         0        1       +1     
Flag Coverage Δ
BB 99.99% <96.29%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(ITcpSocketClient): add ConnectAsync extension method

2 participants