Skip to content

Conversation

@ArgoZhang
Copy link
Member

@ArgoZhang ArgoZhang commented Jun 25, 2025

Link issues

fixes #6296

Summary By Copilot

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Update the TableResetSearchButtonIcon across all supported icon packs to use a clear/cancel icon instead of a trash icon.

Bug Fixes:

Enhancements:

  • Replace the Bootstrap reset search icon from trash3 to x-circle-fill
  • Switch the FontAwesome reset search icon from trash-can to delete-left
  • Change the MaterialDesign reset search icon from trash-can-outline to backspace

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Jun 25, 2025

Reviewer's Guide

This PR updates the default icon for the table reset search button across Bootstrap, FontAwesome, and MaterialDesign icon providers by replacing trash-style icons with more intuitive X/Clear icons.

Class diagram for updated TableResetSearchButtonIcon icon mapping

classDiagram
    class BootstrapIcons {
        +TableResetSearchButtonIcon : string = "bi bi-x-circle-fill"
    }
    class FontAwesomeIcons {
        +TableResetSearchButtonIcon : string = "fa-solid fa-delete-left"
    }
    class MaterialDesignIcons {
        +TableResetSearchButtonIcon : string = "mdi mdi-backspace"
    }
    class ComponentIcons {
        <<static>>
        +TableResetSearchButtonIcon
    }
    BootstrapIcons ..> ComponentIcons : uses
    FontAwesomeIcons ..> ComponentIcons : uses
    MaterialDesignIcons ..> ComponentIcons : uses
Loading

File-Level Changes

Change Details Files
Replaced Bootstrap reset search icon
  • Replaced "bi bi-trash3" with "bi bi-x-circle-fill"
src/BootstrapBlazor/Icons/BootstrapIcons.cs
Replaced FontAwesome reset search icon
  • Replaced "fa-regular fa-trash-can" with "fa-solid fa-delete-left"
src/BootstrapBlazor/Icons/FontAwesomeIcons.cs
Replaced MaterialDesign reset search icon
  • Replaced "mdi mdi-trash-can-outline" with "mdi mdi-backspace"
src/BootstrapBlazor/Icons/MaterialDesignIcons.cs

Assessment against linked issues

Issue Objective Addressed Explanation
#6296 Update the TableResetSearchButtonIcon icon in BootstrapIcons.
#6296 Update the TableResetSearchButtonIcon icon in FontAwesomeIcons.
#6296 Update the TableResetSearchButtonIcon icon in MaterialDesignIcons.

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@bb-auto bb-auto bot added the enhancement New feature or request label Jun 25, 2025
@bb-auto bb-auto bot added this to the 9.7.0 milestone Jun 25, 2025
@ArgoZhang ArgoZhang merged commit de03bba into main Jun 25, 2025
2 of 3 checks passed
@ArgoZhang ArgoZhang deleted the refactor-table-icon branch June 25, 2025 00:40
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ArgoZhang - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(Table): update TableResetSearchButtonIcon icon

2 participants