-
-
Notifications
You must be signed in to change notification settings - Fork 363
feat(Table): update TableResetSearchButtonIcon icon #6297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's GuideThis PR updates the default icon for the table reset search button across Bootstrap, FontAwesome, and MaterialDesign icon providers by replacing trash-style icons with more intuitive X/Clear icons. Class diagram for updated TableResetSearchButtonIcon icon mappingclassDiagram
class BootstrapIcons {
+TableResetSearchButtonIcon : string = "bi bi-x-circle-fill"
}
class FontAwesomeIcons {
+TableResetSearchButtonIcon : string = "fa-solid fa-delete-left"
}
class MaterialDesignIcons {
+TableResetSearchButtonIcon : string = "mdi mdi-backspace"
}
class ComponentIcons {
<<static>>
+TableResetSearchButtonIcon
}
BootstrapIcons ..> ComponentIcons : uses
FontAwesomeIcons ..> ComponentIcons : uses
MaterialDesignIcons ..> ComponentIcons : uses
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes and they look great!
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Link issues
fixes #6296
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Update the TableResetSearchButtonIcon across all supported icon packs to use a clear/cancel icon instead of a trash icon.
Bug Fixes:
Enhancements: