-
-
Notifications
You must be signed in to change notification settings - Fork 363
feat(Table): add NotSupportedColumnFilterMessage parameter #6302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's GuideIntroduces a new NotSupportedMessage parameter on the Table component and propagates it into TableColumnFilter instances to allow consumers to customize the prompt shown for unsupported filter types, with corresponding adjustments in unit tests and localization resources. File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes and they look great!
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6302 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 714 714
Lines 31411 31446 +35
Branches 4437 4437
=========================================
+ Hits 31411 31446 +35
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Link issues
fixes #6301
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Add a NotSupportedMessage parameter to Table to let consumers customize the message shown for unsupported column filters
New Features:
Enhancements:
Tests: