Skip to content

Conversation

@ArgoZhang
Copy link
Member

@ArgoZhang ArgoZhang commented Jun 26, 2025

Link issues

fixes #6309

Summary By Copilot

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Remove the tabs-body-content-wrap wrapper from the Tab component and update unit tests to match the new CSS structure.

Enhancements:

  • Remove redundant tabs-body-content-wrap div from TabItemContent and streamline content rendering.
  • Simplify the render logic by directly rendering ChildContent within ErrorLogger.

Tests:

  • Update unit test selectors to use .tabs-body-content and .tabs-body-content.d-none instead of .tabs-body-content-wrap.

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Jun 26, 2025

Reviewer's Guide

This refactor removes the redundant “tabs-body-content-wrap” wrapper by inlining the ErrorLogger component directly in the TabItemContent render logic (with the key moved accordingly) and updates all affected unit‐test selectors to match the new markup.

File-Level Changes

Change Details Files
Remove redundant wrapper element in TabItemContent rendering
  • Deleted the outer
  • Inlined ErrorLogger component inside BuildRenderTree
  • Eliminated the old RenderFragment helper method
src/BootstrapBlazor/Components/Tab/TabItemContent.cs
Reassign component key to ErrorLogger
  • Removed builder.SetKey on the wrapper div
  • Added builder.SetKey(_key) on the ErrorLogger component
src/BootstrapBlazor/Components/Tab/TabItemContent.cs
Adjust unit test selectors to new structure
  • Replaced .tabs-body .d-none .tabs-body-content-wrap with .tabs-body .tabs-body-content.d-none
  • Replaced .tabs-body-content .tabs-body-content-wrap with .tabs-body-content
test/UnitTest/Components/TabTest.cs

Assessment against linked issues

Issue Objective Addressed Explanation
#6309 Remove the tabs-body-content-wrap HTML node from the Tab component.

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@bb-auto bb-auto bot added the enhancement New feature or request label Jun 26, 2025
@bb-auto bb-auto bot added this to the 9.7.0 milestone Jun 26, 2025
@ArgoZhang ArgoZhang merged commit db34239 into main Jun 26, 2025
4 checks passed
@ArgoZhang ArgoZhang deleted the feat-tab branch June 26, 2025 00:49
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ArgoZhang - I've reviewed your changes - here's some feedback:

  • Remove the now-unused RenderItemContent method signature and any dead code tied to the old wrapper to keep the codebase clean.
  • Update or remove any CSS rules or logic targeting .tabs-body-content-wrap and verify there are no styling/layout regressions after dropping that wrapper.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Remove the now-unused RenderItemContent method signature and any dead code tied to the old wrapper to keep the codebase clean.
- Update or remove any CSS rules or logic targeting `.tabs-body-content-wrap` and verify there are no styling/layout regressions after dropping that wrapper.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@codecov
Copy link

codecov bot commented Jun 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (560bb21) to head (5b9877e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #6310   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          714       714           
  Lines        31457     31447   -10     
  Branches      4438      4437    -1     
=========================================
- Hits         31457     31447   -10     
Flag Coverage Δ
BB 100.00% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

refactor(Tab): remove tabs-body-content-wrap html node

2 participants