-
-
Notifications
You must be signed in to change notification settings - Fork 363
refactor(Tab): remove tabs-body-content-wrap html node #6310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-Authored-By: Kim Kokholm <[email protected]>
Reviewer's GuideThis refactor removes the redundant “tabs-body-content-wrap” wrapper by inlining the ErrorLogger component directly in the TabItemContent render logic (with the key moved accordingly) and updates all affected unit‐test selectors to match the new markup. File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes - here's some feedback:
- Remove the now-unused RenderItemContent method signature and any dead code tied to the old wrapper to keep the codebase clean.
- Update or remove any CSS rules or logic targeting
.tabs-body-content-wrapand verify there are no styling/layout regressions after dropping that wrapper.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Remove the now-unused RenderItemContent method signature and any dead code tied to the old wrapper to keep the codebase clean.
- Update or remove any CSS rules or logic targeting `.tabs-body-content-wrap` and verify there are no styling/layout regressions after dropping that wrapper.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6310 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 714 714
Lines 31457 31447 -10
Branches 4438 4437 -1
=========================================
- Hits 31457 31447 -10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Link issues
fixes #6309
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Remove the tabs-body-content-wrap wrapper from the Tab component and update unit tests to match the new CSS structure.
Enhancements:
Tests: