-
-
Notifications
You must be signed in to change notification settings - Fork 363
fix(EnumFilter): incorrect selected value #6334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's GuideUpdated default and reset filter input values to use empty strings instead of null to correct selected value handling in the EnumFilter component. Class diagram for updated EnumFilter value handlingclassDiagram
class EnumFilter {
+IEnumerable<SelectedItem>? Items
-string? _value1 = ""
-string? _value2 = ""
+override void Reset()
+override Task SetFilterConditionsAsync(FilterKeyValueAction filter)
}
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes and they look great!
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6334 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 717 717
Lines 31558 31560 +2
Branches 4457 4457
=========================================
+ Hits 31558 31560 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…#6338) * refactor: 调整参数位置 * Revert "fix(EnumFilter): incorrect selected value (#6334)" This reverts commit daf9af9. * Revert "fix(BoolFilter): set default value is empty" This reverts commit 26e33c3. * Reapply "fix(BoolFilter): set default value is empty" This reverts commit 4509634. * Reapply "fix(EnumFilter): incorrect selected value (#6334)" This reverts commit 3f3e125. * refactor: 增加中文注释 * refactor: 支持默认值 * test: 增加单元测试
Link issues
fixes #6333
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Fix incorrect selected value in EnumFilter by initializing and resetting filter inputs to empty strings instead of null
Bug Fixes: