-
-
Notifications
You must be signed in to change notification settings - Fork 363
fix(Search): DisplayText needs to be shown on first load #6351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for your PR, @yacper. Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
Reviewer's GuideEnsures the Search component initializes its display text by setting File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes issue #6350 by ensuring filter items are initialized and the display text is set based on the current Value when parameters are applied.
- Initialize
_filterItemsto an empty array using C# 12 shorthand. - Set
_displayTextfrom theValueeach timeOnParametersSetruns.
Comments suppressed due to low confidence (1)
src/BootstrapBlazor/Components/Search/Search.razor.cs:204
- Add or update a unit test to verify that
_displayTextis correctly initialized fromValuewhenOnParametersSetis called.
_displayText = GetDisplayText(Value);
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6351 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 718 718
Lines 31572 31572
Branches 4462 4461 -1
=========================================
Hits 31572 31572
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Link issues
fixes #6350
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Bug Fixes:
_displayTextfromValueduringOnParametersSetin the Search component to fix missing initial display