Skip to content

Conversation

@yacper
Copy link
Contributor

@yacper yacper commented Jul 3, 2025

Link issues

fixes #6350

Summary By Copilot

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Bug Fixes:

  • Assign _displayText from Value during OnParametersSet in the Search component to fix missing initial display

Copilot AI review requested due to automatic review settings July 3, 2025 06:07
@bb-auto
Copy link

bb-auto bot commented Jul 3, 2025

Thanks for your PR, @yacper. Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Jul 3, 2025

Reviewer's Guide

Ensures the Search component initializes its display text by setting _displayText using the current Value within OnParametersSet, addressing the missing initial text issue.

File-Level Changes

Change Details Files
Initialize display text on parameter update
  • Assign _displayText by calling GetDisplayText(Value) in OnParametersSet
src/BootstrapBlazor/Components/Search/Search.razor.cs

Assessment against linked issues

Issue Objective Addressed Explanation

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@bb-auto bb-auto bot added the bug Something isn't working label Jul 3, 2025
@bb-auto bb-auto bot requested a review from ArgoZhang July 3, 2025 06:07
@bb-auto bb-auto bot added this to the 9.8.0 milestone Jul 3, 2025
sourcery-ai[bot]
sourcery-ai bot previously approved these changes Jul 3, 2025
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @yacper - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes issue #6350 by ensuring filter items are initialized and the display text is set based on the current Value when parameters are applied.

  • Initialize _filterItems to an empty array using C# 12 shorthand.
  • Set _displayText from the Value each time OnParametersSet runs.
Comments suppressed due to low confidence (1)

src/BootstrapBlazor/Components/Search/Search.razor.cs:204

  • Add or update a unit test to verify that _displayText is correctly initialized from Value when OnParametersSet is called.
        _displayText = GetDisplayText(Value);

@ArgoZhang ArgoZhang changed the title fix bug #6350 fix(Search): DisplayText needs to be shown on first load Jul 3, 2025
@codecov
Copy link

codecov bot commented Jul 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (e755e92) to head (45923b9).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #6351   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          718       718           
  Lines        31572     31572           
  Branches      4462      4461    -1     
=========================================
  Hits         31572     31572           
Flag Coverage Δ
BB 100.00% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ArgoZhang ArgoZhang merged commit 1afd090 into dotnetcore:main Jul 3, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug(Search): 首次加载时需要显示 DisplayText

2 participants