Skip to content

fix(Table): UI not refreshed after save when set ScrollMode to Virtual #6397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 11, 2025
Merged

fix(Table): UI not refreshed after save when set ScrollMode to Virtual #6397

merged 2 commits into from
Jul 11, 2025

Conversation

@ArgoZhang
Copy link
Member

@ArgoZhang ArgoZhang commented Jul 11, 2025 •
edited by sourcery-ai bot
Loading

Link issues

fixes #6346

Summary By Copilot

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Bug Fixes:

  • Replace QueryData calls with QueryAsync to ensure UI updates in Virtual scroll mode after saving, sorting reset, and during auto-refresh

@bb-auto bb-auto bot added the bug Something isn't working label Jul 11, 2025
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Jul 11, 2025 •
edited
Loading

Reviewer's Guide

This PR fixes the UI refresh issue under virtual scroll mode by replacing all direct QueryData calls with the asynchronous QueryAsync method in key table lifecycle workflows, ensuring the table state is properly updated without unnecessary loading animations.

Class diagram for updated Table component data querying methods

classDiagram
    class Table {
        +Task QueryData()
        +Task QueryAsync()
        +Task LoopQueryAsync()
        +Task ResetSortAsync()
        +Task SaveAsync(EditContext context, ItemChangedType changedType)
    }
    Table : QueryData() replaced by QueryAsync() in LoopQueryAsync()
    Table : QueryData() replaced by QueryAsync() in ResetSortAsync()
    Table : QueryData() replaced by QueryAsync() in SaveAsync()
Loading

File-Level Changes

Change Details Files
Use QueryAsync instead of QueryData to refresh table data
  • LoopQueryAsync now awaits QueryAsync for auto-refresh
  • ResetSortAsync switched from QueryData to QueryAsync
  • Toolbar SaveAsync method updated to call QueryAsync
 src/BootstrapBlazor/Components/Table/Table.razor.cs
src/BootstrapBlazor/Components/Table/Table.razor.Toolbar.cs

Assessment against linked issues

Issue Objective Addressed Explanation
#6346 After adding a new row in the Table's EditMode with EditForm, the data should be displayed without requiring a refresh. ✅
#6346 When editing a row in the Table, the edit form should pop up as expected. ✅

Possibly linked issues

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@bb-auto bb-auto bot added this to the 9.8.0 milestone Jul 11, 2025
sourcery-ai[bot]
sourcery-ai bot previously approved these changes Jul 11, 2025
View reviewed changes
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ArgoZhang - I've reviewed your changes and they look great!

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@ArgoZhang ArgoZhang merged commit c70eca9 into main Jul 11, 2025
4 checks passed
@ArgoZhang ArgoZhang deleted the fix-table branch July 11, 2025 11:24
@codecov
Copy link

codecov bot commented Jul 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (5d2ed31) to head (ad8dfc2).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff            @@
##              main     #6397   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          718       718           
  Lines        31729     31729           
  Branches      4477      4477           
=========================================
  Hits         31729     31729
Flag Coverage Δ
BB 100.00% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] left review comments

Assignees

@ArgoZhang ArgoZhang

Labels

bug Something isn't working

Projects

None yet

Milestone

v9.8.0

Development

Successfully merging this pull request may close these issues.

bug(Table): UI not refreshed after save when set ScrollMode to Virtual

2 participants

@ArgoZhang