-
-
Notifications
You must be signed in to change notification settings - Fork 363
feat(Table): support CssClass on CardView mode #6525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
让Table的RenderMode模式为CardView 时,修改 Column属性 CssClass 可以生效
|
Thanks for your PR, @Mydashixiong. Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
Reviewer's GuideThis PR ensures that when the Table RenderMode is set to CardView, the CssClass assigned to each Column is applied to the rendered cells by injecting the class into the table-cell container. Class diagram for TableColumn CssClass usage in CardView modeclassDiagram
class Table {
RenderMode : RenderMode
Columns : List<TableColumn>
}
class TableColumn {
CssClass : string
GetDisplayName()
}
Table --> "*" TableColumn : contains
class CardViewCell {
+string CssClass
}
TableColumn --> CardViewCell : CssClass applied in CardView
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Mydashixiong - I've reviewed your changes and they look great!
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6525 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 714 714
Lines 31387 31392 +5
Branches 4430 4431 +1
=========================================
+ Hits 31387 31392 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
让Table的RenderMode模式为CardView 时,修改 Column属性 CssClass 可以生效
Link issues
fixes #6530
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
New Features: