feat(Bundle): update css bundler #6804
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Reviewer's GuideThis PR overhauls CSS bundling by updating import paths, enhancing RTL-specific styles, correcting the Pickr theme asset link, and removing an obsolete RTL stylesheet. ER diagram for CSS asset file changeserDiagram
BOOTSTRAP_BLAZOR_BUNDLE_MIN_CSS {
string bootstrap_core_path
string animate_path
string swal_path
}
BOOTSTRAP_BLAZOR_BUNDLE_RTL_MIN_CSS {
string bootstrap_core_rtl_path
string animate_path
string swal_path
}
BOOTSTRAP_BLAZOR_BUNDLE_MIN_CSS ||--|| BOOTSTRAP_BLAZOR_BUNDLE_RTL_MIN_CSS : shares_structure
Class diagram for updated CSS asset imports in bundlerclassDiagram
class "bootstrap.blazor.bundle.min.css" {
+@import url('../core/bootstrap/css/bootstrap.min.css')
+@import url('bootstrapblazor.min.css')
+@import url('../lib/animate/animate.min.css')
+@import url('../lib/swal/sweetalert2.min.css')
}
class "bootstrap.blazor.bundle.rtl.min.css" {
+@import url('../core/bootstrap/css/bootstrap.rtl.min.css')
+@import url('bootstrapblazor.min.css')
+@import url('../lib/animate/animate.min.css')
+@import url('../lib/swal/sweetalert2.min.css')
}
class "ColorPicker.razor.js" {
+addLink("./_content/BootstrapBlazor/lib/pickr/nano.min.css")
}
"bootstrap.blazor.bundle.min.css" <|-- "bootstrap.blazor.bundle.rtl.min.css"
Flow diagram for RTL-specific style enhancementsflowchart TD
A["components.scss"] --> B["Add RTL .card-collapse-bar arrow rotation"]
A --> C["Add RTL .form-select-append left alignment"]
A --> D["Add RTL .select .clear-icon left alignment"]
A --> E["Add RTL .pagination arrow rotation for first/last page"]
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the CSS bundler to consolidate RTL styles and modernize asset management. The main purpose is to move RTL (right-to-left) styles from a separate CSS file into the main SCSS components file and update CSS bundle paths to reference assets directly from their source locations.
- Consolidation of RTL styles into the main SCSS components file
- Updated CSS bundle imports to use source paths instead of copied files
- Simplified build targets and project file configuration
Reviewed Changes
Copilot reviewed 7 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| components.scss | Added RTL-specific styles that were previously in separate CSS file |
| rtl.css | Removed as RTL styles moved to components.scss |
| bootstrap.blazor.bundle.rtl.min.css | Updated import paths to reference source locations |
| bootstrap.blazor.bundle.min.css | Updated import paths to reference source locations |
| Directory.Build.targets | Simplified build process, removed CSS copying tasks |
| ColorPicker.razor.js | Updated CSS path to reference source location |
| BootstrapBlazor.csproj | Updated content exclusions to match new bundling approach |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Hey there - I've reviewed your changes - here's some feedback:
- Double-check that the updated relative import paths in the bundle CSS files match your deployed folder structure to prevent any missing asset errors.
- Consider centralizing your asset/library paths (e.g., for the Pickr nano.min.css) into a shared config or constant to reduce hardcoded string duplication across JS and CSS.
- Ensure the removed rtl.css isn’t referenced elsewhere and that the new inline RTL overrides fully replace its previous styles without creating specificity conflicts.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Double-check that the updated relative import paths in the bundle CSS files match your deployed folder structure to prevent any missing asset errors.
- Consider centralizing your asset/library paths (e.g., for the Pickr nano.min.css) into a shared config or constant to reduce hardcoded string duplication across JS and CSS.
- Ensure the removed rtl.css isn’t referenced elsewhere and that the new inline RTL overrides fully replace its previous styles without creating specificity conflicts.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6804 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 739 739
Lines 31748 31748
Branches 4464 4464
=========================================
Hits 31748 31748
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link issues
fixes #6803
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Update CSS bundler imports and paths, enhance RTL styling for multiple components, and remove an unused RTL stylesheet.
Bug Fixes:
Enhancements:
Chores: