Skip to content

Conversation

@AApuci
Copy link
Collaborator

@AApuci AApuci commented Oct 11, 2025

Modified the OnAutoFitContentAsync callback to accept the calculated column width as a parameter in both C# and JavaScript. This allows custom logic to consider the current width when determining the final column width, improving flexibility for auto-fit scenarios.

Link issues

fixes #6863

Summary By Copilot

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Enhance the auto-fit column width feature by passing the calculated width into the user callback and refining the width computation logic in JavaScript.

Enhancements:

  • Update C# OnAutoFitContentAsync signature to Func<string, float, Task> to accept the calculated column width
  • Modify the JS auto-fit routine to compute max cell width (including header rows) before invoking the callback
  • Invoke the callback with both field name and calculated width, and only apply the returned width if it’s positive
  • Expand the JS row selector to include header rows in the auto-fit width calculation

Modified the OnAutoFitContentAsync callback to accept the calculated column width as a parameter in both C# and JavaScript. This allows custom logic to consider the current width when determining the final column width, improving flexibility for auto-fit scenarios.

Co-Authored-By: ljmay168 <[email protected]>
@bb-auto
Copy link

bb-auto bot commented Oct 11, 2025

Thanks for your PR, @AApuci. Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Oct 11, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR refines the auto-fit column width workflow by first measuring the raw maximum cell width in JavaScript, then passing that value into the C# callback for custom adjustment; it also fixes row selection to include header rows per issue #6864.

Sequence diagram for updated auto-fit column width workflow

sequenceDiagram
    participant JS as JavaScript (Table.razor.js)
    participant CSharp as C# (Table.razor.cs)
    participant Callback as OnAutoFitContentAsync
    JS->>JS: Calculate maxWidth from table cells
    JS->>CSharp: invokeMethodAsync(AutoFitContentCallback, fieldName, maxWidth)
    CSharp->>Callback: OnAutoFitContentAsync(fieldName, maxWidth)
    Callback-->>CSharp: widthValue
    CSharp-->>JS: widthValue
    JS->>JS: Use widthValue if > 0, else use maxWidth
Loading

Class diagram for updated Table component auto-fit callback

classDiagram
    class Table {
        +Func<string, float, Task<float>>? OnAutoFitContentAsync
        +Task<float> AutoFitContentCallback(string fieldName, float calcWidth)
    }
    Table : AutoFitContentCallback is JSInvokable
    Table --> "OnAutoFitContentAsync" Func<string, float, Task<float>>
Loading

File-Level Changes

rows alongside cells
Change Details Files
Expanded auto-fit callback to receive calculated width
  • Adjusted JS.invokeMethodAsync call to pass maxWidth as a second argument
  • Changed C# OnAutoFitContentAsync delegate signature to Func<string, float, Task>
  • Updated JSInvokable AutoFitContentCallback in C# to accept and forward the calcWidth parameter
src/BootstrapBlazor/Components/Table/Table.razor.js
src/BootstrapBlazor/Components/Table/Table.razor.cs
Refactored JS maxWidth calculation sequence
  • Removed initial widthValue assignment and zero-based fallback logic
  • Always compute maxWidth from measured cell widths before invoking the callback
  • Applied callback result only when it returns a positive value
src/BootstrapBlazor/Components/Table/Table.razor.js
Extended row query selectors to include header rows
  • Updated row selection in both branches to include
src/BootstrapBlazor/Components/Table/Table.razor.js

Possibly linked issues

  • feat(Table): 自适应列宽时建议同时适应表头和表体内容宽度 #6864: The PR updates OnAutoFitContentAsync callback to include calculated column width parameter, directly implementing the issue's request.
  • #The provided GitHub issue: PR modifies OnAutoFitContentAsync to pass calculated width, allowing custom logic to react to auto-fit, solving the issue's problem of timing.
  • #N/A: The PR adds a calcWidth parameter to the OnAutoFitContentAsync callback, directly addressing the issue's feature request.

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@bb-auto bb-auto bot requested a review from ArgoZhang October 11, 2025 02:37
sourcery-ai[bot]
sourcery-ai bot previously approved these changes Oct 11, 2025
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@codecov
Copy link

codecov bot commented Oct 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (737e58a) to head (0817694).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #6868   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          739       739           
  Lines        31763     31763           
  Branches      4466      4466           
=========================================
  Hits         31763     31763           
Flag Coverage Δ
BB 100.00% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

AApuci and others added 2 commits October 11, 2025 10:53
@ArgoZhang
Copy link
Member

@AApuci 按照提示签署一下 CLA 谢谢啦

@ArgoZhang ArgoZhang changed the title Update auto-fit column width callback to include width feat(Table): update auto-fit column width callback to include width Oct 11, 2025
@AApuci
Copy link
Collaborator Author

AApuci commented Oct 11, 2025

@dotnet-policy-service agree

@ArgoZhang ArgoZhang merged commit b9a132b into main Oct 11, 2025
6 of 7 checks passed
@ArgoZhang ArgoZhang deleted the Feat-Table-FitColumn branch October 11, 2025 04:39
@bb-auto bb-auto bot added the enhancement New feature or request label Oct 11, 2025
@bb-auto bb-auto bot added this to the 9.11.0 milestone Oct 11, 2025
@AApuci
Copy link
Collaborator Author

AApuci commented Oct 11, 2025

@microsoft-github-policy-service agree

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(Table): 能否为 OnAutoFitContentAsync 添加一个js计算的列宽参数

3 participants