-
-
Notifications
You must be signed in to change notification settings - Fork 362
fix(Cascader): hide arrow icon when hover #6926
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThe Cascader component’s CSS class builder was updated to apply the correct class for clearable behavior, ensuring the arrow icon is properly hidden on hover when clearable functionality is enabled. Class diagram for updated Cascader component CSS class logicclassDiagram
class Cascader {
- bool IsDisabled
- bool IsClearable
- string? CssClass
- string? ValidCss
+ string? ClassString
}
Cascader : ClassString uses CssBuilder
class CssBuilder {
+ Default(string)
+ AddClass(string, bool)
+ Build()
}
Cascader --> CssBuilder : builds ClassString
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes an issue with the Cascader component where the arrow icon was visible when hovering over clearable cascader inputs. The fix corrects the CSS class name from "cls" to "is-clearable" to properly apply the styling that hides the arrow icon during hover.
- Updated CSS class name for clearable cascader state
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6926 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 740 740
Lines 31815 31815
Branches 4469 4469
=========================================
Hits 31815 31815
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Link issues
fixes #6925
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Bug Fixes: