Skip to content

perf(GetUniqueName): add cache for assembly GetUniqueName method #6996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Oct 24, 2025
Merged

perf(GetUniqueName): add cache for assembly GetUniqueName method #6996

merged 9 commits into from
Oct 24, 2025

Conversation

@kimdiego2098
Copy link
Collaborator

@kimdiego2098 kimdiego2098 commented Oct 23, 2025 •
edited by ArgoZhang
Loading

Issues

fixes #6997

feat: GetUniqueName方法添加缓存

Summary by Sourcery

Introduce caching for the GetUniqueName method to avoid repeated computation of assembly names and update the extension method to use the cache.

New Features:

  • Add a cached GetUniqueName(Assembly) method in CacheManager to generate and store unique assembly names

Enhancements:

  • Refactor AssemblyExtensions.GetUniqueName to delegate to the cached implementation in CacheManager

@bb-auto
Copy link

bb-auto bot commented Oct 23, 2025

Thanks for your PR, @kimdiego2098. Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Oct 23, 2025 •
edited
Loading

Reviewer's Guide

This PR introduces caching for the GetUniqueName logic by moving its implementation into CacheManager and updating AssemblyExtensions to delegate to the cached method.

Sequence diagram for GetUniqueName method with caching

sequenceDiagram
    participant Caller
    participant AssemblyExtensions
    participant CacheManager
    participant MemoryCache
    Caller->>AssemblyExtensions: GetUniqueName(assembly)
    AssemblyExtensions->>CacheManager: GetUniqueName(assembly)
    CacheManager->>MemoryCache: GetOrCreate(assembly, ...)
    MemoryCache-->>CacheManager: unique name
    CacheManager-->>AssemblyExtensions: unique name
    AssemblyExtensions-->>Caller: unique name
Loading

Class diagram for updated GetUniqueName caching logic

classDiagram
    class CacheManager {
        +static string GetUniqueName(Assembly assembly)
    }
    class AssemblyExtensions {
        +static string GetUniqueName(Assembly assembly)
    }
    AssemblyExtensions --> CacheManager: delegates GetUniqueName
Loading

File-Level Changes

Change Details Files
Implemented cached GetUniqueName method in CacheManager
  • Added a GetUniqueName static method under a new Assembly region
  • Used Instance.GetOrCreate with assembly as the cache key
  • Built unique name with IsCollectible check and optional hash code
  • Included XML documentation for the new method
 src/BootstrapBlazor/Services/CacheManager.cs
Updated AssemblyExtensions to use the cached GetUniqueName
  • Replaced inline conditional logic with a call to CacheManager.GetUniqueName
  • Removed duplicate GetUniqueName implementation in the extension
 src/BootstrapBlazor/Extensions/AssemblyExtensions.cs
Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@bb-auto bb-auto bot requested a review from ArgoZhang October 23, 2025 13:33
sourcery-ai[bot]
sourcery-ai bot previously approved these changes Oct 23, 2025
View reviewed changes
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@ArgoZhang ArgoZhang changed the title feat: GetUniqueName方法添加缓存 perf(GetUniqueName): add cache for assembly GetUniqueName method Oct 24, 2025
@bb-auto bb-auto bot added the enhancement New feature or request label Oct 24, 2025
@bb-auto bb-auto bot added this to the 9.11.0 milestone Oct 24, 2025
ArgoZhang
ArgoZhang previously approved these changes Oct 24, 2025
View reviewed changes
@codecov
Copy link

codecov bot commented Oct 24, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (9662123) to head (7ba89fd).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff            @@
##              main     #6996   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          741       741           
  Lines        32365     32371    +6     
  Branches      4481      4481           
=========================================
+ Hits         32365     32371    +6
Flag Coverage Δ
BB 100.00% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ArgoZhang ArgoZhang merged commit 7239ed0 into main Oct 24, 2025
7 checks passed
@ArgoZhang ArgoZhang deleted the cache_dev branch October 24, 2025 01:31
@dependabot dependabot bot mentioned this pull request Nov 3, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ArgoZhang ArgoZhang ArgoZhang approved these changes

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] left review comments

Assignees

@ArgoZhang ArgoZhang

Labels

enhancement New feature or request

Projects

None yet

Milestone

9.11.0

Development

Successfully merging this pull request may close these issues.

perf(GetUniqueName): add cache for assembly GetUniqueName method

3 participants

@kimdiego2098 @ArgoZhang