Skip to content

Conversation

@ArgoZhang
Copy link
Member

@ArgoZhang ArgoZhang commented Nov 2, 2025

Link issues

fixes #7049

Summary By Copilot

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Document and demonstrate the new IsGroupExtendButtons parameter in the Table component by adding a toggle control in the TablesEdit sample page, introducing the backing field and localization entries, and updating button styling.

New Features:

  • Add IsGroupExtendButtons toggle control to the TablesEdit sample page with corresponding code-behind backing field and localization labels.

Enhancements:

  • Adjust btn-separate SCSS to use inline-flex layout and proper button spacing.

Documentation:

  • Include documentation for the new IsGroupExtendButtons Table parameter in the component samples.

Copilot AI review requested due to automatic review settings November 2, 2025 07:07
@bb-auto bb-auto bot added the documentation Improvements or additions to documentation label Nov 2, 2025
@bb-auto bb-auto bot added this to the 10.0.0 milestone Nov 2, 2025
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Nov 2, 2025

Reviewer's Guide

This PR enhances the Table component documentation by introducing a live toggle for the new IsGroupExtendButtons parameter in the sample edit page, updates styling for button grouping in SCSS, and adds corresponding localization entries to support the new feature.

Class diagram for TablesEdit sample changes

classDiagram
    class TablesEdit {
        - bool _useGroup
        + DataServiceUrl : string
    }
    TablesEdit : _useGroup
    TablesEdit : DataServiceUrl
Loading

Class diagram for Table component parameter update

classDiagram
    class Table {
        + IsGroupExtendButtons : bool
    }
    Table : IsGroupExtendButtons
Loading

File-Level Changes

Change Details Files
Introduce demo switch for IsGroupExtendButtons
  • Added a form section with label and Switch control
  • Bound the switch value to a private field
  • Enabled IsGroupExtendButtons binding on the Table component
src/BootstrapBlazor.Server/Components/Samples/Table/TablesEdit.razor
Add backing field for the demo toggle
  • Declared a private bool field to store switch state
src/BootstrapBlazor.Server/Components/Samples/Table/TablesEdit.razor.cs
Refactor .btn-separate styling
  • Wrapped button group container with inline-flex display
  • Nested child rule to apply margin between buttons
src/BootstrapBlazor/Components/Table/Table.razor.scss
Add localization entries for new switch
  • Inserted key for IsGroupExtendButtons in English resource
  • Inserted corresponding key in Chinese resource
src/BootstrapBlazor.Server/Locales/en-US.json
src/BootstrapBlazor.Server/Locales/zh-CN.json

Assessment against linked issues

Issue Objective Addressed Explanation
#7049 Add documentation and sample code demonstrating the usage of the IsGroupExtendButtons property for the Table component.

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@ArgoZhang ArgoZhang enabled auto-merge (squash) November 2, 2025 07:07
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@codecov
Copy link

codecov bot commented Nov 2, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (8640cbf) to head (8cf7839).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #7050   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          745       745           
  Lines        32532     32532           
  Branches      4510      4510           
=========================================
  Hits         32532     32532           
Flag Coverage Δ
BB 100.00% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ArgoZhang ArgoZhang merged commit 841ccab into main Nov 2, 2025
11 checks passed
@ArgoZhang ArgoZhang deleted the doc-table branch November 2, 2025 07:10
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds documentation for the IsGroupExtendButtons parameter in the Table component by updating localization files and the demo page to showcase this feature.

  • Updated Chinese and English localization files to document the IsGroupExtendButtons parameter
  • Enhanced the Table demo with an interactive switch to control the IsGroupExtendButtons parameter
  • Improved CSS styling for button groups with proper inline-flex display

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/BootstrapBlazor/Components/Table/Table.razor.scss Added CSS improvements for button group display and spacing
src/BootstrapBlazor.Server/Locales/zh-CN.json Added Chinese documentation for IsGroupExtendButtons parameter
src/BootstrapBlazor.Server/Locales/en-US.json Added English documentation for IsGroupExtendButtons parameter
src/BootstrapBlazor.Server/Components/Samples/Table/TablesEdit.razor.cs Added boolean field to control IsGroupExtendButtons demo
src/BootstrapBlazor.Server/Components/Samples/Table/TablesEdit.razor Enhanced demo UI with switch control for IsGroupExtendButtons parameter

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

doc(Table): add IsGroupExtendButtons documentation

2 participants