Skip to content

Conversation

@braia123
Copy link
Collaborator

@braia123 braia123 commented Nov 3, 2025

Link issues

fixes #7055

Summary By Copilot

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Synchronize the AutoFill input display with programmatic Value changes and enhance its sample documentation and demo.

Bug Fixes:

  • Ensure the AutoFill input field updates its displayed text when the bound Value parameter is set in code by invoking a JS setValue call

Enhancements:

  • Include the IsAutoClearWhenInvalid property in the AutoFill sample’s attribute list
  • Add a test button to the sample page to clear the bound model and demonstrate the update behavior

@bb-auto
Copy link

bb-auto bot commented Nov 3, 2025

Thanks for your PR, @braia123. Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Nov 3, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Synchronize the input display when Value changes by invoking a JS interop call, and enhance the AutoFill sample with the new IsAutoClearWhenInvalid option and a test button.

Sequence diagram for synchronizing input display when Value changes in AutoFill

sequenceDiagram
participant AutoFillComponent
participant JSInterop
AutoFillComponent->>AutoFillComponent: OnParametersSet()
AutoFillComponent->>AutoFillComponent: _displayText = GetDisplayText(Value)
AutoFillComponent->>AutoFillComponent: _clientValue = _displayText
AutoFillComponent->>JSInterop: InvokeVoidAsync("setValue", Id, _displayText)
Loading

Class diagram for updated AutoFill component attributes

classDiagram
class AutoFill~T~ {
  +IsAutoClearWhenInvalid: bool
  +Value: T
  +Items: List<T>
  +OnGetDisplayText: Func<T, string>
  +IsLikeMatch: bool
  +IsSelectAllTextOnFocus: bool
}
AutoFill~string~ --|> AutoFill~T~
Loading

File-Level Changes

Change Details Files
Synchronize input display on Value assignment
  • Invoke JavaScript setValue method in OnParametersSet after updating _displayText and _clientValue
src/BootstrapBlazor/Components/AutoFill/AutoFill.razor.cs
Enhance sample with IsAutoClearWhenInvalid parameter
  • Add new AttributeItem entry for IsAutoClearWhenInvalid in sample metadata
  • Expose IsAutoClearWhenInvalid in AutoFill sample usage
src/BootstrapBlazor.Server/Components/Samples/AutoFills.razor.cs
Add test button to clear bound model in sample
  • Insert a Button in AutoFills.razor to reset Model1 for manual testing
src/BootstrapBlazor.Server/Components/Samples/AutoFills.razor

Assessment against linked issues

Issue Objective Addressed Explanation
#7055 Ensure that when the bound Value of AutoFill is set to null via code, the input display updates to reflect the new (null) value.

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@bb-auto bb-auto bot added the enhancement New feature or request label Nov 3, 2025
@bb-auto bb-auto bot requested a review from ArgoZhang November 3, 2025 12:06
@bb-auto bb-auto bot added this to the 10.0.0 milestone Nov 3, 2025
sourcery-ai[bot]
sourcery-ai bot previously approved these changes Nov 3, 2025
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@codecov
Copy link

codecov bot commented Nov 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (eaa2a93) to head (e845e9a).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #7058   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          745       745           
  Lines        32534     32549   +15     
  Branches      4510      4512    +2     
=========================================
+ Hits         32534     32549   +15     
Flag Coverage Δ
BB 100.00% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ArgoZhang ArgoZhang changed the title 代码赋值给Value时更新input显示内容 feat(AutoFill): support update value by external code Nov 4, 2025
@ArgoZhang ArgoZhang merged commit c6b14dc into main Nov 4, 2025
7 checks passed
@ArgoZhang ArgoZhang deleted the AutoFill branch November 4, 2025 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(AutoFill): 对绑定的Value赋值input不更新显示内容

3 participants