-
-
Notifications
You must be signed in to change notification settings - Fork 362
feat(AutoFill): support update value by external code #7058
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for your PR, @braia123. Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
Reviewer's guide (collapsed on small PRs)Reviewer's GuideSynchronize the input display when Value changes by invoking a JS interop call, and enhance the AutoFill sample with the new IsAutoClearWhenInvalid option and a test button. Sequence diagram for synchronizing input display when Value changes in AutoFillsequenceDiagram
participant AutoFillComponent
participant JSInterop
AutoFillComponent->>AutoFillComponent: OnParametersSet()
AutoFillComponent->>AutoFillComponent: _displayText = GetDisplayText(Value)
AutoFillComponent->>AutoFillComponent: _clientValue = _displayText
AutoFillComponent->>JSInterop: InvokeVoidAsync("setValue", Id, _displayText)
Class diagram for updated AutoFill component attributesclassDiagram
class AutoFill~T~ {
+IsAutoClearWhenInvalid: bool
+Value: T
+Items: List<T>
+OnGetDisplayText: Func<T, string>
+IsLikeMatch: bool
+IsSelectAllTextOnFocus: bool
}
AutoFill~string~ --|> AutoFill~T~
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7058 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 745 745
Lines 32534 32549 +15
Branches 4510 4512 +2
=========================================
+ Hits 32534 32549 +15
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Link issues
fixes #7055
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Synchronize the AutoFill input display with programmatic Value changes and enhance its sample documentation and demo.
Bug Fixes:
Enhancements: