Skip to content

Conversation

@ArgoZhang
Copy link
Member

@ArgoZhang ArgoZhang commented Nov 12, 2025

Link issues

fixes #7105

Summary By Copilot

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Simplify the Router component in Routes.razor by removing the obsolete .NET 10 conditional code and always specifying the NotFoundPage parameter

Enhancements:

  • Remove the IsNet10OrGreater conditional and related code in Routes.razor
  • Unify Router markup to always include NotFoundPage="typeof(Pages.NotFound)"

Chores:

  • Clean up legacy conditional logic in the server project

Copilot AI review requested due to automatic review settings November 12, 2025 04:45
@bb-auto bb-auto bot added the chore This are tasks or bot action label Nov 12, 2025
@bb-auto bb-auto bot added this to the 10.0.0 milestone Nov 12, 2025
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Nov 12, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This pull request streamlines the server-side routing setup by removing legacy .NET 1.0 conditional blocks and unconditionally registering a custom NotFound page in the Router component.

Class diagram for updated Router component usage

classDiagram
    class Router {
        +AppAssembly
        +NotFoundPage
    }
    class RouteView {
        +RouteData
        +DefaultLayout
    }
    class FocusOnNavigate {
        +RouteData
        +Selector
    }
    class Pages_NotFound
    Router --> RouteView : contains
    Router --> FocusOnNavigate : contains
    Router --> Pages_NotFound : NotFoundPage
    RouteView --> MainLayout : DefaultLayout
Loading

Flow diagram for simplified routing logic after PR

flowchart TD
    A[Router]
    B[Found]
    C[RouteView]
    D[FocusOnNavigate]
    E[NotFoundPage]
    A -->|AppAssembly| B
    B -->|Context: routeData| C
    B --> D
    A -->|NotFoundPage| E
Loading

File-Level Changes

Change Details Files
Simplify router setup by removing conditional compilation and always including the NotFoundPage parameter
  • Deleted IsNet10OrGreater property and all #if NET10_0_OR_GREATER logic
  • Removed dual Router definitions and branch handling
  • Retained single Router declaration with NotFoundPage set to Pages.NotFound
src/BootstrapBlazor.Server/Components/Routes.razor

Assessment against linked issues

Issue Objective Addressed Explanation
#7105 Update the NotFound parameter in the Route component to use NotFoundPage="typeof(Pages.NotFound)" unconditionally.

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copilot finished reviewing on behalf of ArgoZhang November 12, 2025 04:46
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR simplifies the Router configuration by removing the conditional logic based on .NET version and always using the NotFoundPage parameter. The changes support targeting .NET 10 or greater as the minimum version.

  • Removed conditional rendering logic for .NET 10+ detection
  • Simplified Router component to always include NotFoundPage parameter
  • Removed BOM character from project file

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
src/BootstrapBlazor.Server/Components/Routes.razor Simplified Router by removing .NET version conditional logic and always using NotFoundPage parameter
src/BootstrapBlazor.Server/BootstrapBlazor.Server.csproj Removed BOM character from XML file

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link

codecov bot commented Nov 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (1512b3d) to head (ef644da).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #7106   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          745       745           
  Lines        32548     32548           
  Branches      4510      4510           
=========================================
  Hits         32548     32548           
Flag Coverage Δ
BB 100.00% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ArgoZhang ArgoZhang enabled auto-merge (squash) November 12, 2025 05:00
@ArgoZhang ArgoZhang merged commit f23d8b4 into main Nov 12, 2025
7 checks passed
@ArgoZhang ArgoZhang deleted the chore-dom2image branch November 12, 2025 05:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore This are tasks or bot action

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore(Route): update NotFound parameter

2 participants