-
-
Notifications
You must be signed in to change notification settings - Fork 363
chore(Route): update NotFound parameter #7106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis pull request streamlines the server-side routing setup by removing legacy .NET 1.0 conditional blocks and unconditionally registering a custom NotFound page in the Router component. Class diagram for updated Router component usageclassDiagram
class Router {
+AppAssembly
+NotFoundPage
}
class RouteView {
+RouteData
+DefaultLayout
}
class FocusOnNavigate {
+RouteData
+Selector
}
class Pages_NotFound
Router --> RouteView : contains
Router --> FocusOnNavigate : contains
Router --> Pages_NotFound : NotFoundPage
RouteView --> MainLayout : DefaultLayout
Flow diagram for simplified routing logic after PRflowchart TD
A[Router]
B[Found]
C[RouteView]
D[FocusOnNavigate]
E[NotFoundPage]
A -->|AppAssembly| B
B -->|Context: routeData| C
B --> D
A -->|NotFoundPage| E
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR simplifies the Router configuration by removing the conditional logic based on .NET version and always using the NotFoundPage parameter. The changes support targeting .NET 10 or greater as the minimum version.
- Removed conditional rendering logic for .NET 10+ detection
- Simplified Router component to always include
NotFoundPageparameter - Removed BOM character from project file
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/BootstrapBlazor.Server/Components/Routes.razor | Simplified Router by removing .NET version conditional logic and always using NotFoundPage parameter |
| src/BootstrapBlazor.Server/BootstrapBlazor.Server.csproj | Removed BOM character from XML file |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7106 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 745 745
Lines 32548 32548
Branches 4510 4510
=========================================
Hits 32548 32548
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Link issues
fixes #7105
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Simplify the Router component in Routes.razor by removing the obsolete .NET 10 conditional code and always specifying the NotFoundPage parameter
Enhancements:
Chores: