非方法成员的声明的诊断检测

Author: xljiulang

WebApiClient.Analyzers/AttributeCtorAnalyzer.cs

@@ -21,7 +21,8 @@ public override ImmutableArray<DiagnosticDescriptor> SupportedDiagnostics
                 return ImmutableArray.Create(
                     DiagnosticDescriptors.AttributeDescriptor,
                     DiagnosticDescriptors.ReturnTypeDescriptor,
-                    DiagnosticDescriptors.RefParameterDescriptor);
+                    DiagnosticDescriptors.RefParameterDescriptor,
+                    DiagnosticDescriptors.NotMethodDefindDescriptor);
             }
         }
 

WebApiClient.Analyzers/DiagnosticDescriptors.cs

@@ -23,8 +23,13 @@ static class DiagnosticDescriptors
         /// 引用参数诊断描述器
         /// </summary>
         public static DiagnosticDescriptor RefParameterDescriptor { get; }
-            = Rule("PR1001", "不支持ref/out", "参数不支持ref/out等修饰");
+            = Rule("RP1001", "不支持ref/out", "参数不支持ref/out等修饰");
 
+        /// <summary>
+        /// 非方法声明诊断描述器
+        /// </summary>
+        public static DiagnosticDescriptor NotMethodDefindDescriptor { get; }
+            = Rule("NM1001", "不支持的非方法声明", "不支持的非方法声明，只允许方法的声明");
 
         /// <summary>
         /// 创建诊断描述器

WebApiClient.Analyzers/WebApiClientHtttApi.cs

@@ -20,7 +20,7 @@ class WebApiClientHtttApi
         /// <summary>
         /// 接口声明
         /// </summary>
-        private readonly InterfaceDeclarationSyntax interfaceDeclaration;
+        private readonly InterfaceDeclarationSyntax httpApiInterfaceSyntax;
 
         /// <summary>
         /// webApiClient上下文
@@ -39,7 +39,7 @@ class WebApiClientHtttApi
         public WebApiClientHtttApi(SyntaxNodeAnalysisContext syntaxNodeContext)
         {
             this.syntaxNodeContext = syntaxNodeContext;
-            this.interfaceDeclaration = syntaxNodeContext.Node as InterfaceDeclarationSyntax;
+            this.httpApiInterfaceSyntax = syntaxNodeContext.Node as InterfaceDeclarationSyntax;
             this.webApiClientContext = new WebApiClientContext(syntaxNodeContext.Compilation);
             this.IsHtttApiInterface = this.GetIsHtttApiInterface();
         }
@@ -50,12 +50,12 @@ public WebApiClientHtttApi(SyntaxNodeAnalysisContext syntaxNodeContext)
         /// <returns></returns>
         private bool GetIsHtttApiInterface()
         {
-            if (this.interfaceDeclaration == null || this.interfaceDeclaration.BaseList == null)
+            if (this.httpApiInterfaceSyntax == null || this.httpApiInterfaceSyntax.BaseList == null)
             {
                 return false;
             }
 
-            foreach (var baseType in this.interfaceDeclaration.BaseList.Types)
+            foreach (var baseType in this.httpApiInterfaceSyntax.BaseList.Types)
             {
                 var type = this.syntaxNodeContext.SemanticModel.GetTypeInfo(baseType.Type).Type;
                 if (type.Equals(this.webApiClientContext.IHttpApiType) == true)
@@ -75,6 +75,7 @@ public void ReportDiagnostic()
             this.ReportDiagnosticOfAttributes();
             this.ReportDiagnosticOfReturnTypes();
             this.ReportDiagnosticOfRefParameters();
+            this.ReportDiagnosticOfNotMethodDefinds();
         }
 
         /// <summary>
@@ -87,7 +88,7 @@ public void ReportDiagnosticOfAttributes()
                 return;
             }
 
-            var interfaceSymbol = this.syntaxNodeContext.SemanticModel.GetDeclaredSymbol(this.interfaceDeclaration);
+            var interfaceSymbol = this.syntaxNodeContext.SemanticModel.GetDeclaredSymbol(this.httpApiInterfaceSyntax);
             if (interfaceSymbol == null)
             {
                 return;
@@ -155,13 +156,34 @@ public void ReportDiagnosticOfRefParameters()
             }
         }
 
+        /// <summary>
+        /// 报告非方法声明诊断
+        /// </summary>
+        public void ReportDiagnosticOfNotMethodDefinds()
+        {
+            if (this.IsHtttApiInterface == false)
+            {
+                return;
+            }
+
+            foreach (var member in this.httpApiInterfaceSyntax.Members)
+            {
+                if (member.Kind() != SyntaxKind.MethodDeclaration)
+                {
+                    var location = member.GetLocation();
+                    var diagnostic = DiagnosticDescriptors.NotMethodDefindDescriptor.ToDiagnostic(location);
+                    this.syntaxNodeContext.ReportDiagnostic(diagnostic);
+                }
+            }
+        }
+
         /// <summary>
         /// 获取HttpApi方法
         /// </summary>
         /// <returns></returns>
         private IEnumerable<IMethodSymbol> GetHttpApiMethodSymbols()
         {
-            foreach (var member in this.interfaceDeclaration.Members)
+            foreach (var member in this.httpApiInterfaceSyntax.Members)
             {
                 if (member.Kind() != SyntaxKind.MethodDeclaration)
                 {