Comment not required variable, which can cause an IndexOutOfBoundsException

TomMuehlegger · TomMuehlegger · commit 94cf6dfd5457 · 2024-11-26T12:26:47.000+01:00
diff --git a/LibNoDaveConnectionLibrary/PLCs/S7_xxx/MC7/JumpMarks.cs b/LibNoDaveConnectionLibrary/PLCs/S7_xxx/MC7/JumpMarks.cs
@@ -52,7 +52,9 @@ public static List<FunctionBlockRow> AddJumpmarks(List<FunctionBlockRow> myBlk,
 
             if (JumpMarks != null && JumpMarks.Length >= 5)
             {
-                int anzJ = BitConverter.ToInt16(JumpMarks, NetworkCount * 2);  //Todo: find out why it does not always contain the right amount of JumpNames
+                // Comment this out, as the variable anzJ is not used at all and it sometimes throws and IndexOutOfBounds Exception
+                // Eg. there are 68 jump marks, but the Network count is 40 => access from index 80 --> IOB Exception
+                // int anzJ = BitConverter.ToInt16(JumpMarks, NetworkCount * 2);  //Todo: find out why it does not always contain the right amount of JumpNames
 
                 for (int n = NetworkCount * 2 + 4; n < JumpMarks.Length; n += 5)
                 {

Original file line number	Diff line number	Diff line change
`@@ -52,7 +52,9 @@ public static List<FunctionBlockRow> AddJumpmarks(List<FunctionBlockRow> myBlk,`
`52`	`52`
`53`	`53`	`if (JumpMarks != null && JumpMarks.Length >= 5)`
`54`	`54`	`{`
`55`		`- int anzJ = BitConverter.ToInt16(JumpMarks, NetworkCount * 2); //Todo: find out why it does not always contain the right amount of JumpNames`
	`55`	`+ // Comment this out, as the variable anzJ is not used at all and it sometimes throws and IndexOutOfBounds Exception`
	`56`	`+ // Eg. there are 68 jump marks, but the Network count is 40 => access from index 80 --> IOB Exception`
	`57`	`+ // int anzJ = BitConverter.ToInt16(JumpMarks, NetworkCount * 2); //Todo: find out why it does not always contain the right amount of JumpNames`
`56`	`58`
`57`	`59`	`for (int n = NetworkCount * 2 + 4; n < JumpMarks.Length; n += 5)`
`58`	`60`	`{`