AddTable now uses GENERATED ALWAYS AS IDENTITY in Oracle / Added data loader for oracle

Author: JaBistDuNarrisch

src/Migrator.Tests/Providers/Generic/Generic_AddTableTestsBase.cs

@@ -0,0 +1,63 @@
+using System.Data;
+using DotNetProjects.Migrator.Framework;
+using Migrator.Tests.Providers.Base;
+using NUnit.Framework;
+
+namespace Migrator.Tests.Providers.Generic;
+
+[TestFixture]
+public abstract class Generic_AddTableTestsBase : TransformationProviderBase
+{
+    [Test]
+    public void AddTable_PrimaryKeyWithIdentity_Success()
+    {
+        // Arrange
+        var tableName = "TableName";
+        var column1Name = "Column1";
+        var column2Name = "Column2";
+
+        // Act
+        Provider.AddTable(tableName,
+            new Column(column1Name, DbType.Int32, ColumnProperty.NotNull | ColumnProperty.PrimaryKeyWithIdentity),
+            new Column(column2Name, DbType.Int32, ColumnProperty.NotNull)
+        );
+
+        // Assert
+        var column1 = Provider.GetColumnByName(tableName, column1Name);
+        var column2 = Provider.GetColumnByName(tableName, column2Name);
+
+        Assert.That(column1.ColumnProperty.HasFlag(ColumnProperty.PrimaryKeyWithIdentity), Is.True);
+        Assert.That(column2.ColumnProperty.HasFlag(ColumnProperty.NotNull), Is.True);
+    }
+
+    [Test]
+    public void AddTable_NotNull_Success()
+    {
+        // Arrange
+        var tableName = "TableName";
+        var column1Name = "Column1";
+
+        // Act
+        Provider.AddTable(tableName,
+            new Column(column1Name, DbType.Int32, ColumnProperty.NotNull)
+        );
+
+        // Assert
+        var column1 = Provider.GetColumnByName(tableName, column1Name);
+
+        Assert.That(column1.ColumnProperty.HasFlag(ColumnProperty.NotNull), Is.True);
+    }
+
+
+    [Test]
+    public void AddTableWithCompoundPrimaryKey()
+    {
+        Provider.AddTable("Test",
+            new Column("PersonId", DbType.Int32, ColumnProperty.PrimaryKey),
+            new Column("AddressId", DbType.Int32, ColumnProperty.PrimaryKey)
+        );
+
+        Assert.That(Provider.TableExists("Test"), Is.True, "Table doesn't exist");
+        Assert.That(Provider.PrimaryKeyExists("Test", "PK_Test"), Is.True, "Constraint doesn't exist");
+    }
+}

src/Migrator.Tests/Providers/OracleProvider/OracleTransformationProvider_AddTable_Tests.cs

@@ -1,48 +1,16 @@
-using System.Data;
 using System.Threading.Tasks;
-using DotNetProjects.Migrator.Framework;
-using Migrator.Tests.Providers.Base;
+using Migrator.Tests.Providers.Generic;
 using NUnit.Framework;
 
 namespace Migrator.Tests.Providers.OracleProvider;
 
 [TestFixture]
 [Category("Oracle")]
-public class OracleTransformationProvider_AddTable_Tests : TransformationProviderBase
+public class OracleTransformationProvider_AddTable_Tests : Generic_AddTableTestsBase
 {
     [SetUp]
     public async Task SetUpAsync()
     {
         await BeginOracleTransactionAsync();
     }
-
-    [Test]
-    public void AddTableWithCompoundPrimaryKey()
-    {
-        Provider.AddTable("Test",
-            new Column("PersonId", DbType.Int32, ColumnProperty.PrimaryKey),
-            new Column("AddressId", DbType.Int32, ColumnProperty.PrimaryKey)
-        );
-
-        Assert.That(Provider.TableExists("Test"), Is.True, "Table doesn't exist");
-        Assert.That(Provider.PrimaryKeyExists("Test", "PK_Test"), Is.True, "Constraint doesn't exist");
-    }
-
-    [Test]
-    public void AddTable_NotNull_Success()
-    {
-        // Arrange
-        var tableName = "TableName";
-        var column1Name = "Column1";
-
-        // Act
-        Provider.AddTable(tableName,
-            new Column(column1Name, DbType.Int32, ColumnProperty.NotNull)
-        );
-
-        // Assert
-        var column1 = Provider.GetColumnByName(tableName, column1Name);
-
-        Assert.That(column1.ColumnProperty.HasFlag(ColumnProperty.NotNull), Is.True);
-    }
 }

src/Migrator.Tests/Providers/PostgreSQL/PostgreSQLTransformationProvider_AddTableTests.cs

@@ -1,23 +1,16 @@
-using System.Data;
-using DotNetProjects.Migrator.Framework;
-using Migrator.Tests.Providers.PostgreSQL.Base;
+using System.Threading.Tasks;
+using Migrator.Tests.Providers.Generic;
 using NUnit.Framework;
 
 namespace Migrator.Tests.Providers.PostgreSQL;
 
 [TestFixture]
 [Category("Postgre")]
-public class PostgreSQLTransformationProvider_AddTableTests : PostgreSQLTransformationProviderTestBase
+public class PostgreSQLTransformationProvider_AddTableTests : Generic_AddTableTestsBase
 {
-    [Test]
-    public void AddTableWithCompoundPrimaryKey()
+    [SetUp]
+    public async Task SetUpAsync()
     {
-        Provider.AddTable("Test",
-            new Column("PersonId", DbType.Int32, ColumnProperty.PrimaryKey),
-            new Column("AddressId", DbType.Int32, ColumnProperty.PrimaryKey)
-        );
-
-        Assert.That(Provider.TableExists("Test"), Is.True, "Table doesn't exist");
-        Assert.That(Provider.PrimaryKeyExists("Test", "PK_Test"), Is.True, "Constraint doesn't exist");
+        await BeginPostgreSQLTransactionAsync();
     }
 }

src/Migrator.Tests/Providers/SQLServer/SQLServerTransformationProvider_AddTableTests.cs

@@ -1,14 +1,14 @@
 using System.Data;
 using System.Threading.Tasks;
 using DotNetProjects.Migrator.Framework;
-using Migrator.Tests.Providers.Base;
+using Migrator.Tests.Providers.Generic;
 using NUnit.Framework;
 
 namespace Migrator.Tests.Providers.SQLServer;
 
 [TestFixture]
 [Category("SqlServer")]
-public class SQLServerTransformationProvider_AddTableTests : TransformationProviderBase
+public class SQLServerTransformationProvider_AddTableTests : Generic_AddTableTestsBase
 {
     [SetUp]
     public async Task SetUpAsync()

src/Migrator.Tests/Providers/SQLite/SQLiteTransformationProvider_AddTableTests.cs

@@ -1,16 +1,23 @@
 using System.Data.SQLite;
 using System.Linq;
+using System.Threading.Tasks;
 using DotNetProjects.Migrator.Framework;
 using DotNetProjects.Migrator.Providers.Impl.SQLite;
-using Migrator.Tests.Providers.SQLite.Base;
+using Migrator.Tests.Providers.Generic;
 using NUnit.Framework;
 
 namespace Migrator.Tests.Providers.SQLite;
 
 [TestFixture]
 [Category("SQLite")]
-public class SQLiteTransformationProvider_AddTableTests : SQLiteTransformationProviderTestBase
+public class SQLiteTransformationProvider_AddTableTests : Generic_AddTableTestsBase
 {
+    [SetUp]
+    public async Task SetUpAsync()
+    {
+        await BeginSQLiteTransactionAsync();
+    }
+
     [Test]
     public void AddTable_UniqueOnlyOnColumnLevel_Obsolete_UniquesListIsEmpty()
     {

src/Migrator/Framework/IDialect.cs

@@ -51,8 +51,9 @@ public interface IDialect
     DbType GetDbType(string databaseTypeName);
 
     void RegisterProperty(ColumnProperty property, string sql);
+
     string SqlForProperty(ColumnProperty property, Column column);
-    string Quote(string value);
+
     string Default(object defaultValue);
 
     /// <summary>
@@ -61,4 +62,25 @@ public interface IDialect
     /// <param name="type">The DbType</param>
     /// <returns>True if the database type has an unsigned variant, otherwise false</returns>
     bool IsUnsignedCompatible(DbType type);
+
+    /// <summary>
+    /// Quotes the string.
+    /// </summary>
+    /// <param name="value"></param>
+    /// <returns></returns>
+    string Quote(string value);
+
+    /// <summary>
+    /// Quotes the table name if necessary.
+    /// </summary>
+    /// <param name="tableName"></param>
+    /// <returns></returns>
+    string QuoteTableNameIfRequired(string tableName);
+
+    /// <summary>
+    /// Quotes the column name if necessary.
+    /// </summary>
+    /// <param name="columnName"></param>
+    /// <returns></returns>
+    string QuoteColumnNameIfRequired(string columnName);
 }