Skip to content

Commit 2f211fa

Browse files
Ja bist du narrischJa bist du narrisch
authored andcommitted
Fix common tests for Postgre. SQL Server and SQLite tests are all green
1 parent ad19dd8 commit 2f211fa

File tree

1 file changed

+22
-15
lines changed

1 file changed

+22
-15
lines changed

src/Migrator.Tests/Providers/Base/TransformationProviderBase.cs

Lines changed: 22 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -307,8 +307,8 @@ public void CommitTwice()
307307
[Test]
308308
public void InsertData()
309309
{
310-
Provider.Insert("TestTwo", ["Id", "TestId"], [1, "1"]);
311-
Provider.Insert("TestTwo", ["Id", "TestId"], [2, "2"]);
310+
Provider.Insert("TestTwo", ["Id", "TestId"], [1, 1]);
311+
Provider.Insert("TestTwo", ["Id", "TestId"], [2, 2]);
312312

313313
using var cmd = Provider.CreateCommand();
314314
using var reader = Provider.Select(cmd, "TestId", "TestTwo");
@@ -323,8 +323,8 @@ public void CanInsertNullData()
323323
{
324324
AddTable();
325325

326-
Provider.Insert("Test", ["Id", "Title"], ["1", "foo"]);
327-
Provider.Insert("Test", ["Id", "Title"], ["2", null]);
326+
Provider.Insert("Test", ["Id", "Title"], [1, "foo"]);
327+
Provider.Insert("Test", ["Id", "Title"], [2, null]);
328328

329329
using var cmd = Provider.CreateCommand();
330330
using var reader = Provider.Select(cmd, "Title", "Test");
@@ -337,12 +337,16 @@ public void CanInsertNullData()
337337
[Test]
338338
public void CanInsertDataWithSingleQuotes()
339339
{
340+
// Arrange
341+
const string testString = "Test string with ' (single quote)";
340342
AddTable();
341-
Provider.Insert("Test", ["Id", "Title"], ["1", "Muad'Dib"]);
343+
Provider.Insert("Test", ["Id", "Title"], [1, testString]);
344+
342345
using var cmd = Provider.CreateCommand();
343346
using var reader = Provider.Select(cmd, "Title", "Test");
347+
344348
Assert.That(reader.Read(), Is.True);
345-
Assert.That("Muad'Dib", Is.EqualTo(reader.GetString(0)));
349+
Assert.That(testString, Is.EqualTo(reader.GetString(0)));
346350
Assert.That(reader.Read(), Is.False);
347351
}
348352

@@ -362,9 +366,12 @@ public void DeleteData()
362366
public void DeleteDataWithArrays()
363367
{
364368
InsertData();
365-
Provider.Delete("TestTwo", ["TestId"], ["1"]);
369+
370+
Provider.Delete("TestTwo", ["TestId"], [1]);
371+
366372
using var cmd = Provider.CreateCommand();
367373
using var reader = Provider.Select(cmd, "TestId", "TestTwo");
374+
368375
Assert.That(reader.Read(), Is.True);
369376
Assert.That(2, Is.EqualTo(Convert.ToInt32(reader[0])));
370377
Assert.That(reader.Read(), Is.False);
@@ -373,10 +380,10 @@ public void DeleteDataWithArrays()
373380
[Test]
374381
public void UpdateData()
375382
{
376-
Provider.Insert("TestTwo", ["Id", "TestId"], [20, "1"]);
377-
Provider.Insert("TestTwo", ["Id", "TestId"], [21, "2"]);
383+
Provider.Insert("TestTwo", ["Id", "TestId"], [20, 1]);
384+
Provider.Insert("TestTwo", ["Id", "TestId"], [21, 2]);
378385

379-
Provider.Update("TestTwo", ["TestId"], ["3"]);
386+
Provider.Update("TestTwo", ["TestId"], [3]);
380387
using var cmd = Provider.CreateCommand();
381388
using var reader = Provider.Select(cmd, "TestId", "TestTwo");
382389
var vals = GetVals(reader);
@@ -390,8 +397,8 @@ public void UpdateData()
390397
public void CanUpdateWithNullData()
391398
{
392399
AddTable();
393-
Provider.Insert("Test", ["Id", "Title"], ["1", "foo"]);
394-
Provider.Insert("Test", ["Id", "Title"], ["2", null]);
400+
Provider.Insert("Test", ["Id", "Title"], [1, "foo"]);
401+
Provider.Insert("Test", ["Id", "Title"], [2, null]);
395402

396403
Provider.Update("Test", ["Title"], [null]);
397404
using var cmd = Provider.CreateCommand();
@@ -405,10 +412,10 @@ public void CanUpdateWithNullData()
405412
[Test]
406413
public void UpdateDataWithWhere()
407414
{
408-
Provider.Insert("TestTwo", ["Id", "TestId"], [10, "1"]);
409-
Provider.Insert("TestTwo", ["Id", "TestId"], [11, "2"]);
415+
Provider.Insert("TestTwo", ["Id", "TestId"], [10, 1]);
416+
Provider.Insert("TestTwo", ["Id", "TestId"], [11, 2]);
410417

411-
Provider.Update("TestTwo", ["TestId"], ["3"], "TestId='1'");
418+
Provider.Update("TestTwo", ["TestId"], [3], "TestId='1'");
412419
using var cmd = Provider.CreateCommand();
413420
using var reader = Provider.Select(cmd, "TestId", "TestTwo");
414421
var vals = GetVals(reader);

0 commit comments

Comments
 (0)