Match FK constraint extract data with pragma FK data

Author: Ja bist du narrisch

src/Migrator.Tests/Providers/SQLite/SQLiteTransformationProvider_GetForeignKeysTests.cs

@@ -1,7 +1,5 @@
 using System.Data;
 using System.Linq;
-using DotNetProjects.Migrator.Framework;
-using DotNetProjects.Migrator.Providers.Impl.SQLite;
 using Migrator.Framework;
 using Migrator.Tests.Providers.SQLite.Base;
 using NUnit.Framework;
@@ -48,40 +46,11 @@ public void RenameColumn_HavingASingleForeignKeyPointingToTheTargetColumn_Single
         // Act
         var foreignKeyConstraints = Provider.GetForeignKeyConstraints(child);
 
-        // var tableInfoLevel2Before = ((SQLiteTransformationProvider)Provider).GetSQLiteTableInfo(tableNameLevel2);
-        // var tableInfoLevel3Before = ((SQLiteTransformationProvider)Provider).GetSQLiteTableInfo(tableNameLevel3);
+        // Assert
+        Assert.That(foreignKeyConstraints.Single(x => x.Name == foreignKeyStringA).ChildColumns, Is.EqualTo([childColumnFKToParentAProperty1]));
+        Assert.That(foreignKeyConstraints.Single(x => x.Name == foreignKeyStringA).ParentColumns, Is.EqualTo([parentAProperty1]));
 
-        // Provider.ExecuteNonQuery($"INSERT INTO {tableNameLevel1} ({propertyId}) VALUES (1)");
-        // Provider.ExecuteNonQuery($"INSERT INTO {tableNameLevel1} ({propertyId}) VALUES (2)");
-        // Provider.ExecuteNonQuery($"INSERT INTO {tableNameLevel2} ({propertyId}, {propertyLevel1Id}) VALUES (1, 1)");
-        // Provider.ExecuteNonQuery($"INSERT INTO {tableNameLevel3} ({propertyId}, {propertyLevel2Id}) VALUES (1, 1)");
-
-        // // Act
-        // Provider.RenameColumn(tableNameLevel2, propertyId, propertyIdRenamed);
-        // Provider.RenameColumn(tableNameLevel2, propertyLevel1Id, propertyLevel1IdRenamed);
-
-        // // Assert
-        // Provider.ExecuteNonQuery($"INSERT INTO {tableNameLevel2} ({propertyIdRenamed}, {propertyLevel1IdRenamed}) VALUES (2,2)");
-        // using var command = Provider.GetCommand();
-
-        // using var reader = Provider.ExecuteQuery(command, $"SELECT COUNT(*) as Count from {tableNameLevel2}");
-        // reader.Read();
-        // var count = reader.GetInt32(reader.GetOrdinal("Count"));
-        // Assert.That(count, Is.EqualTo(2));
-
-        // var tableInfoLevel2After = ((SQLiteTransformationProvider)Provider).GetSQLiteTableInfo(tableNameLevel2);
-
-        // Assert.That(tableInfoLevel2Before.Columns.Single(x => x.Name == propertyId).ColumnProperty.HasFlag(ColumnProperty.PrimaryKey), Is.True);
-        // Assert.That(tableInfoLevel2Before.Columns.Single(x => x.Name == propertyLevel1Id).ColumnProperty.HasFlag(ColumnProperty.Unique), Is.True);
-        // Assert.That(tableInfoLevel2Before.ForeignKeys.Single().ChildColumns.Single(), Is.EqualTo(propertyLevel1Id));
-
-        // Assert.That(tableInfoLevel2After.Columns.FirstOrDefault(x => x.Name == propertyId), Is.Null);
-        // Assert.That(tableInfoLevel2After.Columns.FirstOrDefault(x => x.Name == propertyLevel1Id), Is.Null);
-        // Assert.That(tableInfoLevel2After.Columns.FirstOrDefault(x => x.Name == propertyIdRenamed), Is.Not.Null);
-        // Assert.That(tableInfoLevel2After.Columns.FirstOrDefault(x => x.Name == propertyLevel1IdRenamed), Is.Not.Null);
-        // Assert.That(tableInfoLevel2After.ForeignKeys.Single().ChildColumns.Single(), Is.EqualTo(propertyLevel1IdRenamed));
-
-        // var valid = ((SQLiteTransformationProvider)Provider).CheckForeignKeyIntegrity();
-        // Assert.That(valid, Is.True);
+        Assert.That(foreignKeyConstraints.Single(x => x.Name == foreignKeyStringB).ChildColumns, Is.EqualTo([childColumnFKToParentBProperty1, childColumnFKToParentBProperty2]));
+        Assert.That(foreignKeyConstraints.Single(x => x.Name == foreignKeyStringB).ParentColumns, Is.EqualTo([parentBProperty1, parentBProperty2]));
     }
 }

src/Migrator/Providers/Impl/SQLite/SQLiteTransformationProvider.cs

@@ -118,22 +118,65 @@ public override ForeignKeyConstraint[] GetForeignKeyConstraints(string tableName
                 foreignKeyConstraints.Add(foreignKeyConstraint);
             }
 
+            if (foreignKeyConstraints.Count == 0)
+            {
+                return [];
+            }
+
             var createTableScript = GetSqlCreateTableScript(tableName);
             var regEx = ForeignKeyRegex();
             var matchesCollection = regEx.Matches(createTableScript);
-            var matches = matchesCollection.Cast<Match>().ToList().Where(x => x.Success).Select(x => x.Value).ToList();
+            var fkParts = matchesCollection.Cast<Match>().ToList().Where(x => x.Success).Select(x => x.Value).ToList();
 
-            if (matches.Count != foreignKeyConstraints.Count)
+            if (fkParts.Count != foreignKeyConstraints.Count)
             {
-                throw new Exception($"Cannot extract all foreign keys out of the create table script in SQLite. Did you use a name as foreign key constraint for all constraints in table {tableName}?");
+                throw new Exception($"Cannot extract all foreign keys out of the create table script in SQLite. Did you use a name as foreign key constraint for all constraints in table '{tableName}' in this or older migrations?");
             }
 
-            foreach (var foreignKeyConstraint in foreignKeyConstraints)
+            List<ForeignKeyExtract> foreignKeyExtracts = [];
+
+            foreach (var fkPart in fkParts)
             {
                 var regexParenthesis = ForeignKeyParenthesisRegex();
-                regexParenthesis.Matches()
+                var parenthesisContents = regexParenthesis.Matches(fkPart).Cast<Match>().Select(x => x.Groups[1].Value).ToList();
+
+                if (parenthesisContents.Count != 2)
+                {
+                    throw new Exception("Cannot extract parenthesis of foreign key constraint");
+                }
+
+                var foreignKeyExtract = new ForeignKeyExtract()
+                {
+                    ChildColumnNames = parenthesisContents[0].Split(",").Select(x => x.Trim()).ToList(),
+                    ParentColumnNames = parenthesisContents[1].Split(",").Select(x => x.Trim()).ToList(),
+                };
+
+                var foreignKeyConstraintNameRegex = ForeignKeyConstraintNameRegex();
+                var foreignKeyNameMatch = foreignKeyConstraintNameRegex.Match(fkPart);
+
+                if (!foreignKeyNameMatch.Success)
+                {
+                    throw new Exception("Could not extract the foreign key constraint name");
+                }
+
+                foreignKeyExtract.ForeignKeyName = foreignKeyNameMatch.Groups[1].Value;
+
+                foreignKeyExtracts.Add(foreignKeyExtract);
             }
 
+            foreach (var foreignKeyConstraint in foreignKeyConstraints)
+            {
+                foreach (var foreignKeyExtract in foreignKeyExtracts)
+                {
+                    if (
+                        foreignKeyExtract.ChildColumnNames.SequenceEqual(foreignKeyConstraint.ChildColumns) &&
+                        foreignKeyExtract.ParentColumnNames.SequenceEqual(foreignKeyConstraint.ParentColumns)
+                    )
+                    {
+                        foreignKeyConstraint.Name = foreignKeyExtract.ForeignKeyName;
+                    }
+                }
+            }
 
             return foreignKeyConstraints.ToArray();
         }
@@ -1259,5 +1302,7 @@ protected override void ConfigureParameterWithValue(IDbDataParameter parameter,
         private static partial Regex ForeignKeyRegex();
         [GeneratedRegex(@"\(([^)]+)\)")]
         private static partial Regex ForeignKeyParenthesisRegex();
+        [GeneratedRegex(@"CONSTRAINT\s+(\w+)\s+FOREIGN\s+KEY")]
+        private static partial Regex ForeignKeyConstraintNameRegex();
     }
 }