Added checkConstraint test

Author: JaBistDuNarrisch

src/Migrator.Tests/Providers/SQLite/SQLiteTransformationProvider_GetCheckConstraintsTests.cs

@@ -1,4 +1,3 @@
-using System;
 using System.Data.SQLite;
 using DotNetProjects.Migrator.Framework;
 using DotNetProjects.Migrator.Providers.Impl.SQLite;
@@ -42,20 +41,4 @@ public void GetCheckConstraints_AddCheckConstraintsViaAddTable_CreatesTableCorre
         var createScript = ((SQLiteTransformationProvider)Provider).GetSqlCreateTableScript(tableName);
         Assert.That(createScript, Is.EqualTo("CREATE TABLE MyTableName (MyColumnName INTEGER NULL, CONSTRAINT MyCheckConstraint1 CHECK (MyColumnName > 10), CONSTRAINT MyCheckConstraint2 CHECK (MyColumnName < 100))"));
     }
-
-    [Test]
-    public void CheckForeignKeyIntegrity_IntegrityOk_ReturnsTrue()
-    {
-        // Arrange
-        AddTableWithPrimaryKey();
-        Provider.ExecuteNonQuery("INSERT INTO Test (Id, name) VALUES (1, 'my name')");
-        Provider.ExecuteNonQuery("INSERT INTO TestTwo (TestId) VALUES (1)");
-        Provider.AddForeignKey(name: "FKName", childTable: "TestTwo", childColumn: "TestId", parentTable: "Test", parentColumn: "Id", constraint: ForeignKeyConstraintType.Cascade);
-
-        // Act
-        var result = ((SQLiteTransformationProvider)Provider).CheckForeignKeyIntegrity();
-
-        // Assert
-        Assert.That(result, Is.True);
-    }
 }

src/Migrator.Tests/Providers/SQLite/SQLiteTransformationProvider_RemoveColumnTests.cs

@@ -265,4 +265,23 @@ public void RemoveColumn_HavingAForeignKeyPointingFromTableToParentAndForeignKey
         var valid = ((SQLiteTransformationProvider)Provider).CheckForeignKeyIntegrity();
         Assert.That(valid, Is.True);
     }
+
+    [Test]
+    public void RemoveColumn_ColumnExistsInCheckConstraintString_Throws()
+    {
+        const string tableName = "MyTableName";
+        const string columnName = "MyColumnName";
+        const string checkConstraint1 = "MyCheckConstraint1";
+
+        // Arrange
+        Provider.AddTable(tableName,
+            new Column(columnName, System.Data.DbType.Int32),
+            new CheckConstraint(checkConstraint1, $"{columnName} > 10")
+        );
+
+        var checkConstraints = ((SQLiteTransformationProvider)Provider).GetCheckConstraints(tableName);
+
+        // Act/Assert
+        Assert.Throws<MigrationException>(() => Provider.RemoveColumn(tableName, columnName));
+    }
 }

src/Migrator/Providers/Impl/SQLite/SQLiteTransformationProvider.cs

@@ -7,9 +7,9 @@
 using System.Linq;
 using System.Text;
 using System.Text.RegularExpressions;
-using System.Xml.Linq;
 using ForeignKeyConstraint = DotNetProjects.Migrator.Framework.ForeignKeyConstraint;
 using Index = DotNetProjects.Migrator.Framework.Index;
+using DotNetProjects.Migrator.Framework.Extensions;
 
 namespace DotNetProjects.Migrator.Providers.Impl.SQLite;
 
@@ -407,9 +407,11 @@ public override void RemoveColumn(string tableName, string column)
 
         var sqliteInfoMainTable = GetSQLiteTableInfo(tableName);
 
-        if (sqliteInfoMainTable.CheckConstraints.Any(x => x.CheckConstraintString.Equals(column, StringComparison.OrdinalIgnoreCase)))
+        var checkConstraints = sqliteInfoMainTable.CheckConstraints;
+
+        if (checkConstraints.Any(x => x.CheckConstraintString.Contains(column, StringComparison.OrdinalIgnoreCase)))
         {
-            throw new Exception("A check constraint contains the column you want to remove. Remove the check constraint first");
+            throw new MigrationException("A check constraint contains the column you want to remove. Remove the check constraint first");
         }
 
         if (!sqliteInfoMainTable.ColumnMappings.Any(x => x.OldName == column))