Added multi column FK test for GetForeignKeys

Author: Ja bist du narrisch

src/Migrator.Tests/Providers/Base/TransformationProviderConstraintBase.cs

@@ -145,10 +145,12 @@ public void AddTableWithCompoundPrimaryKeyShouldKeepNullForOtherProperties()
                            new Column("AddressId", DbType.Int32, ColumnProperty.PrimaryKey),
                            new Column("Name", DbType.String, 30, ColumnProperty.Null)
             );
+
         Assert.That(Provider.TableExists("Test"), Is.True, "Table doesn't exist");
         Assert.That(Provider.PrimaryKeyExists("Test", "PK_Test"), Is.True, "Constraint doesn't exist");
 
         var column = Provider.GetColumnByName("Test", "Name");
+
         Assert.That(column, Is.Not.Null);
         Assert.That((column.ColumnProperty & ColumnProperty.Null) == ColumnProperty.Null, Is.True);
     }
@@ -174,8 +176,10 @@ public void GetForeignKeyConstraints_SingleColumn_Success()
 
         Provider.AddForeignKey(fkName, childTableName, parentIdColumn, parentTableName, idColumn);
 
+        // Act
         var foreignKeyConstraints = Provider.GetForeignKeyConstraints(childTableName);
 
+        // Assert
         var resultSingle = foreignKeyConstraints.Single();
 
         Assert.That(resultSingle.Name.ToLowerInvariant(), Is.EqualTo(fkName.ToLowerInvariant()));
@@ -184,4 +188,50 @@ public void GetForeignKeyConstraints_SingleColumn_Success()
         Assert.That(resultSingle.ChildColumns.Select(x => x.ToLowerInvariant()).Single(), Is.EqualTo(parentIdColumn.ToLowerInvariant()));
         Assert.That(resultSingle.ParentColumns.Select(x => x.ToLowerInvariant()).Single(), Is.EqualTo(idColumn.ToLowerInvariant()));
     }
+
+    [Test]
+    public void GetForeignKeyConstraints_MultiColumnColumn_Success()
+    {
+        // Arrange
+        const string fkName = "MyForeignKey";
+        const string childTableName = "ChildTable";
+        const string parentTableName = "ParentTable";
+
+        const string parentColumnId = "Id";
+        const string parentColumnTest = "Test";
+        const string childColumnParentId = "ParentId";
+        const string childColumnParentTest = "ParentTest";
+
+        Provider.AddTable(parentTableName,
+            new Column(parentColumnId, DbType.Int32, ColumnProperty.PrimaryKey),
+            new Column(parentColumnTest, DbType.Int32, ColumnProperty.NotNull)
+        );
+
+        Provider.AddTable(childTableName,
+            new Column(childColumnParentId, DbType.Int32, ColumnProperty.PrimaryKey),
+            new Column(childColumnParentTest, DbType.Int32)
+        );
+
+        Provider.AddUniqueConstraint("MyUniqueConstraint", parentTableName, [parentColumnId, parentColumnTest]);
+
+        Provider.AddForeignKey(fkName, childTableName, [childColumnParentId, childColumnParentTest], parentTableName, [parentColumnId, parentColumnTest]);
+
+        // Act
+        var foreignKeyConstraints = Provider.GetForeignKeyConstraints(childTableName);
+
+        // Assert
+        var resultSingle = foreignKeyConstraints.Single();
+
+        Assert.That(resultSingle.Name.ToLowerInvariant(), Is.EqualTo(fkName.ToLowerInvariant()));
+        Assert.That(resultSingle.ChildTable.ToLowerInvariant(), Is.EqualTo(childTableName.ToLowerInvariant()));
+        Assert.That(resultSingle.ParentTable.ToLowerInvariant(), Is.EqualTo(parentTableName.ToLowerInvariant()));
+
+        var childColumns = resultSingle.ChildColumns.Select(x => x.ToLowerInvariant()).ToList();
+        var parentColumns = resultSingle.ParentColumns.Select(x => x.ToLowerInvariant()).ToList();
+
+        Assert.That(childColumns[0], Is.EqualTo(childColumnParentId.ToLowerInvariant()));
+        Assert.That(childColumns[1], Is.EqualTo(childColumnParentTest.ToLowerInvariant()));
+        Assert.That(parentColumns[0], Is.EqualTo(parentColumnId.ToLowerInvariant()));
+        Assert.That(parentColumns[1], Is.EqualTo(parentColumnTest.ToLowerInvariant()));
+    }
 }

src/Migrator/Providers/TransformationProvider.cs

@@ -156,8 +156,10 @@ public virtual ForeignKeyConstraint[] GetForeignKeyConstraints(string table)
         sb.AppendLine("  INFORMATION_SCHEMA.TABLE_CONSTRAINTS tc ");
         sb.AppendLine("JOIN INFORMATION_SCHEMA.KEY_COLUMN_USAGE as kcu");
         sb.AppendLine("  ON tc.CONSTRAINT_NAME = kcu.CONSTRAINT_NAME AND tc.TABLE_SCHEMA = kcu.TABLE_SCHEMA");
+        sb.AppendLine("JOIN INFORMATION_SCHEMA.REFERENTIAL_CONSTRAINTS as rc");
+        sb.AppendLine("  ON tc.CONSTRAINT_NAME = rc.CONSTRAINT_NAME AND tc.TABLE_SCHEMA = rc.CONSTRAINT_SCHEMA");
         sb.AppendLine("JOIN INFORMATION_SCHEMA.CONSTRAINT_COLUMN_USAGE AS ccu");
-        sb.AppendLine("  ON tc.CONSTRAINT_NAME = ccu.CONSTRAINT_NAME AND tc.TABLE_SCHEMA = ccu.TABLE_SCHEMA");
+        sb.AppendLine("  ON rc.UNIQUE_CONSTRAINT_NAME = ccu.CONSTRAINT_NAME AND rc.UNIQUE_CONSTRAINT_SCHEMA = ccu.CONSTRAINT_SCHEMA");
         sb.AppendLine($"WHERE LOWER(tc.TABLE_NAME) = LOWER('{table}') AND tc.CONSTRAINT_TYPE = 'FOREIGN KEY'");
         sb.AppendLine("ORDER BY kcu.ORDINAL_POSITION");