Use var instead of explicit type

Author: Ja bist du narrisch

src/Migrator.Tests/JoiningTableTransformationProviderExtensionsTests.cs

@@ -4,155 +4,154 @@
 using NUnit.Framework;
 using Rhino.Mocks;
 
-namespace Migrator.Tests
+namespace Migrator.Tests;
+
+[TestFixture]
+public class JoiningTableTransformationProviderExtensionsTests
 {
-    [TestFixture]
-    public class JoiningTableTransformationProviderExtensionsTests
-    {
-        #region Setup/Teardown
+    #region Setup/Teardown
 
-        [SetUp]
-        public void SetUp()
-        {
-            provider = MockRepository.GenerateStub<ITransformationProvider>();
-        }
+    [SetUp]
+    public void SetUp()
+    {
+        _provider = MockRepository.GenerateStub<ITransformationProvider>();
+    }
 
-        #endregion
+    #endregion
 
-        ITransformationProvider provider;
+    private ITransformationProvider _provider;
 
-        [Test]
-        public void AddManyToManyJoiningTable_AddsPrimaryKey()
-        {
-            provider.AddManyToManyJoiningTable("dbo", "TestScenarios", "Id", "Versions", "Id");
+    [Test]
+    public void AddManyToManyJoiningTable_AddsPrimaryKey()
+    {
+        _provider.AddManyToManyJoiningTable("dbo", "TestScenarios", "Id", "Versions", "Id");
 
-            object[] args = provider.GetArgumentsForCallsMadeOn(stub => stub.AddPrimaryKey(null, null, null))[0];
+        var args = _provider.GetArgumentsForCallsMadeOn(stub => stub.AddPrimaryKey(null, null, null))[0];
 
-            Assert.That("PK_TestScenarioVersions", Is.EqualTo(args[0]));
-            Assert.That("dbo.TestScenarioVersions", Is.EqualTo(args[1]));
+        Assert.That("PK_TestScenarioVersions", Is.EqualTo(args[0]));
+        Assert.That("dbo.TestScenarioVersions", Is.EqualTo(args[1]));
 
-            var columns = (string[])args[2];
+        var columns = (string[])args[2];
 
-            Assert.That("TestScenarioId", Does.Contain(columns));
-            Assert.That("VersionId", Does.Contain(columns));
-        }
+        Assert.That("TestScenarioId", Does.Contain(columns));
+        Assert.That("VersionId", Does.Contain(columns));
+    }
 
-        [Test]
-        public void AddManyToManyJoiningTable_CreatesLeftHandSideColumn_WithCorrectName()
-        {
-            provider.AddManyToManyJoiningTable("dbo", "TestScenarios", "Id", "Versions", "Id");
+    [Test]
+    public void AddManyToManyJoiningTable_CreatesLeftHandSideColumn_WithCorrectName()
+    {
+        _provider.AddManyToManyJoiningTable("dbo", "TestScenarios", "Id", "Versions", "Id");
 
-            object[] args = provider.GetArgumentsForCallsMadeOn(stub => stub.AddTable(null, (Column[])null))[0];
+        var args = _provider.GetArgumentsForCallsMadeOn(stub => stub.AddTable(null, (Column[])null))[0];
 
-            Column lhsColumn = ((IDbField[])args[1])[0] as Column;
+        var lhsColumn = ((IDbField[])args[1])[0] as Column;
 
-            Assert.That(lhsColumn.Name, Is.EqualTo("TestScenarioId"));
-            Assert.That(DbType.Guid, Is.EqualTo(lhsColumn.Type));
-            Assert.That(ColumnProperty.NotNull, Is.EqualTo(lhsColumn.ColumnProperty));
-        }
+        Assert.That(lhsColumn.Name, Is.EqualTo("TestScenarioId"));
+        Assert.That(DbType.Guid, Is.EqualTo(lhsColumn.Type));
+        Assert.That(ColumnProperty.NotNull, Is.EqualTo(lhsColumn.ColumnProperty));
+    }
 
-        [Test]
-        public void AddManyToManyJoiningTable_CreatesLeftHandSideForeignKey_WithCorrectAttributes()
-        {
-            provider.AddManyToManyJoiningTable("dbo", "TestScenarios", "Id", "Versions", "Id");
+    [Test]
+    public void AddManyToManyJoiningTable_CreatesLeftHandSideForeignKey_WithCorrectAttributes()
+    {
+        _provider.AddManyToManyJoiningTable("dbo", "TestScenarios", "Id", "Versions", "Id");
 
-            object[] args = provider.GetArgumentsForCallsMadeOn(stub => stub.AddForeignKey(null, null, "", null, null, ForeignKeyConstraintType.NoAction))[0];
+        var args = _provider.GetArgumentsForCallsMadeOn(stub => stub.AddForeignKey(null, null, "", null, null, ForeignKeyConstraintType.NoAction))[0];
 
-            Assert.That("dbo.TestScenarioVersions", Is.EqualTo(args[1]));
-            Assert.That("TestScenarioId", Is.EqualTo(args[2]));
-            Assert.That("dbo.TestScenarios", Is.EqualTo(args[3]));
-            Assert.That("Id", Is.EqualTo(args[4]));
-            Assert.That(ForeignKeyConstraintType.NoAction, Is.EqualTo(args[5]));
-        }
+        Assert.That("dbo.TestScenarioVersions", Is.EqualTo(args[1]));
+        Assert.That("TestScenarioId", Is.EqualTo(args[2]));
+        Assert.That("dbo.TestScenarios", Is.EqualTo(args[3]));
+        Assert.That("Id", Is.EqualTo(args[4]));
+        Assert.That(ForeignKeyConstraintType.NoAction, Is.EqualTo(args[5]));
+    }
 
-        [Test]
-        public void AddManyToManyJoiningTable_CreatesLeftHandSideForeignKey_WithCorrectName()
-        {
-            provider.AddManyToManyJoiningTable("dbo", "TestScenarios", "Id", "Versions", "Id");
+    [Test]
+    public void AddManyToManyJoiningTable_CreatesLeftHandSideForeignKey_WithCorrectName()
+    {
+        _provider.AddManyToManyJoiningTable("dbo", "TestScenarios", "Id", "Versions", "Id");
 
-            object[] args = provider.GetArgumentsForCallsMadeOn(stub => stub.AddForeignKey(null, null, "", null, null, ForeignKeyConstraintType.NoAction))[0];
+        var args = _provider.GetArgumentsForCallsMadeOn(stub => stub.AddForeignKey(null, null, "", null, null, ForeignKeyConstraintType.NoAction))[0];
 
-            Assert.That("FK_Scenarios_ScenarioVersions", Is.EqualTo(args[0]));
-        }
+        Assert.That("FK_Scenarios_ScenarioVersions", Is.EqualTo(args[0]));
+    }
 
-        [Test]
-        public void AddManyToManyJoiningTable_CreatesRightHandSideColumn_WithCorrectName()
-        {
-            provider.AddManyToManyJoiningTable("dbo", "TestScenarios", "Id", "Versions", "Id");
+    [Test]
+    public void AddManyToManyJoiningTable_CreatesRightHandSideColumn_WithCorrectName()
+    {
+        _provider.AddManyToManyJoiningTable("dbo", "TestScenarios", "Id", "Versions", "Id");
 
-            object[] args = provider.GetArgumentsForCallsMadeOn(stub => stub.AddTable(null, (Column[])null))[0];
+        var args = _provider.GetArgumentsForCallsMadeOn(stub => stub.AddTable(null, (Column[])null))[0];
 
-            Column rhsColumn = ((IDbField[])args[1])[1] as Column;
+        var rhsColumn = ((IDbField[])args[1])[1] as Column;
 
-            Assert.That(rhsColumn.Name, Is.EqualTo("VersionId"));
-            Assert.That(DbType.Guid, Is.EqualTo(rhsColumn.Type));
-            Assert.That(ColumnProperty.NotNull, Is.EqualTo(rhsColumn.ColumnProperty));
-        }
+        Assert.That(rhsColumn.Name, Is.EqualTo("VersionId"));
+        Assert.That(DbType.Guid, Is.EqualTo(rhsColumn.Type));
+        Assert.That(ColumnProperty.NotNull, Is.EqualTo(rhsColumn.ColumnProperty));
+    }
 
-        [Test]
-        public void AddManyToManyJoiningTable_CreatesRightHandSideForeignKey_WithCorrectAttributes()
-        {
-            provider.AddManyToManyJoiningTable("dbo", "TestScenarios", "Id", "Versions", "Id");
+    [Test]
+    public void AddManyToManyJoiningTable_CreatesRightHandSideForeignKey_WithCorrectAttributes()
+    {
+        _provider.AddManyToManyJoiningTable("dbo", "TestScenarios", "Id", "Versions", "Id");
 
-            object[] args = provider.GetArgumentsForCallsMadeOn(stub => stub.AddForeignKey(null, null, "", null, null, ForeignKeyConstraintType.NoAction))[1];
+        var args = _provider.GetArgumentsForCallsMadeOn(stub => stub.AddForeignKey(null, null, "", null, null, ForeignKeyConstraintType.NoAction))[1];
 
-            Assert.That("dbo.TestScenarioVersions", Is.EqualTo(args[1]));
-            Assert.That("VersionId", Is.EqualTo(args[2]));
-            Assert.That("dbo.Versions", Is.EqualTo(args[3]));
-            Assert.That("Id", Is.EqualTo(args[4]));
-            Assert.That(ForeignKeyConstraintType.NoAction, Is.EqualTo(args[5]));
-        }
+        Assert.That("dbo.TestScenarioVersions", Is.EqualTo(args[1]));
+        Assert.That("VersionId", Is.EqualTo(args[2]));
+        Assert.That("dbo.Versions", Is.EqualTo(args[3]));
+        Assert.That("Id", Is.EqualTo(args[4]));
+        Assert.That(ForeignKeyConstraintType.NoAction, Is.EqualTo(args[5]));
+    }
 
-        [Test]
-        public void AddManyToManyJoiningTable_CreatesRightHandSideForeignKey_WithCorrectName()
-        {
-            provider.AddManyToManyJoiningTable("dbo", "TestScenarios", "Id", "Versions", "Id");
+    [Test]
+    public void AddManyToManyJoiningTable_CreatesRightHandSideForeignKey_WithCorrectName()
+    {
+        _provider.AddManyToManyJoiningTable("dbo", "TestScenarios", "Id", "Versions", "Id");
 
-            object[] args = provider.GetArgumentsForCallsMadeOn(stub => stub.AddForeignKey(null, null, "", null, null, ForeignKeyConstraintType.NoAction))[1];
+        var args = _provider.GetArgumentsForCallsMadeOn(stub => stub.AddForeignKey(null, null, "", null, null, ForeignKeyConstraintType.NoAction))[1];
 
-            Assert.That("FK_Versions_ScenarioVersions", Is.EqualTo(args[0]));
-        }
+        Assert.That("FK_Versions_ScenarioVersions", Is.EqualTo(args[0]));
+    }
 
-        [Test]
-        public void AddManyToManyJoiningTable_CreatesTableWithCorrectName()
-        {
-            provider.AddManyToManyJoiningTable("dbo", "TestScenarios", "Id", "Versions", "Id");
+    [Test]
+    public void AddManyToManyJoiningTable_CreatesTableWithCorrectName()
+    {
+        _provider.AddManyToManyJoiningTable("dbo", "TestScenarios", "Id", "Versions", "Id");
 
-            object[] args = provider.GetArgumentsForCallsMadeOn(stub => stub.AddTable(null, (Column[])null))[0];
+        var args = _provider.GetArgumentsForCallsMadeOn(stub => stub.AddTable(null, (Column[])null))[0];
 
-            Assert.That("dbo.TestScenarioVersions", Is.EqualTo(args[0]));
-        }
+        Assert.That("dbo.TestScenarioVersions", Is.EqualTo(args[0]));
+    }
 
-        [Test]
-        public void RemoveManyToManyJoiningTable_RemovesLhsForeignKey()
-        {
-            provider.RemoveManyToManyJoiningTable("dbo", "TestScenarios", "Versions");
+    [Test]
+    public void RemoveManyToManyJoiningTable_RemovesLhsForeignKey()
+    {
+        _provider.RemoveManyToManyJoiningTable("dbo", "TestScenarios", "Versions");
 
-            object[] args = provider.GetArgumentsForCallsMadeOn(stub => stub.RemoveForeignKey(null, null))[0];
+        var args = _provider.GetArgumentsForCallsMadeOn(stub => stub.RemoveForeignKey(null, null))[0];
 
-            Assert.That("dbo.TestScenarioVersions", Is.EqualTo(args[0]));
-            Assert.That("FK_Scenarios_ScenarioVersions", Is.EqualTo(args[1]));
-        }
+        Assert.That("dbo.TestScenarioVersions", Is.EqualTo(args[0]));
+        Assert.That("FK_Scenarios_ScenarioVersions", Is.EqualTo(args[1]));
+    }
 
-        [Test]
-        public void RemoveManyToManyJoiningTable_RemovesRhsForeignKey()
-        {
-            provider.RemoveManyToManyJoiningTable("dbo", "TestScenarios", "Versions");
+    [Test]
+    public void RemoveManyToManyJoiningTable_RemovesRhsForeignKey()
+    {
+        _provider.RemoveManyToManyJoiningTable("dbo", "TestScenarios", "Versions");
 
-            object[] args = provider.GetArgumentsForCallsMadeOn(stub => stub.RemoveForeignKey(null, null))[1];
+        var args = _provider.GetArgumentsForCallsMadeOn(stub => stub.RemoveForeignKey(null, null))[1];
 
-            Assert.That("dbo.TestScenarioVersions", Is.EqualTo(args[0]));
-            Assert.That("FK_Versions_ScenarioVersions", Is.EqualTo(args[1]));
-        }
+        Assert.That("dbo.TestScenarioVersions", Is.EqualTo(args[0]));
+        Assert.That("FK_Versions_ScenarioVersions", Is.EqualTo(args[1]));
+    }
 
-        [Test]
-        public void RemoveManyToManyJoiningTable_RemovesTable()
-        {
-            provider.RemoveManyToManyJoiningTable("dbo", "TestScenarios", "Versions");
+    [Test]
+    public void RemoveManyToManyJoiningTable_RemovesTable()
+    {
+        _provider.RemoveManyToManyJoiningTable("dbo", "TestScenarios", "Versions");
 
-            object[] args = provider.GetArgumentsForCallsMadeOn(stub => stub.RemoveTable(null))[0];
+        var args = _provider.GetArgumentsForCallsMadeOn(stub => stub.RemoveTable(null))[0];
 
-            Assert.That("dbo.TestScenarioVersions", Is.EqualTo(args[0]));
-        }
+        Assert.That("dbo.TestScenarioVersions", Is.EqualTo(args[0]));
     }
 }

src/Migrator.Tests/MigrationLoaderTest.cs

@@ -4,71 +4,74 @@
 using NUnit.Framework;
 using NUnit.Mocks;
 
-namespace Migrator.Tests
+namespace Migrator.Tests;
+
+[TestFixture]
+public class MigrationLoaderTest
 {
-    [TestFixture]
-    public class MigrationLoaderTest
+    #region Setup/Teardown
+
+    [SetUp]
+    public void SetUp()
     {
-        #region Setup/Teardown
+        SetUpCurrentVersion(0, false);
+    }
 
-        [SetUp]
-        public void SetUp()
-        {
-            SetUpCurrentVersion(0, false);
-        }
+    #endregion
 
-        #endregion
+    private MigrationLoader _migrationLoader;
 
-        MigrationLoader _migrationLoader;
+    private void SetUpCurrentVersion(int version, bool assertRollbackIsCalled)
+    {
+        var providerMock = new DynamicMock(typeof(ITransformationProvider));
 
-        void SetUpCurrentVersion(int version, bool assertRollbackIsCalled)
+        providerMock.SetReturnValue("get_CurrentVersion", version);
+        providerMock.SetReturnValue("get_Logger", new Logger(false));
+        if (assertRollbackIsCalled)
         {
-            var providerMock = new DynamicMock(typeof(ITransformationProvider));
-
-            providerMock.SetReturnValue("get_CurrentVersion", version);
-            providerMock.SetReturnValue("get_Logger", new Logger(false));
-            if (assertRollbackIsCalled)
-                providerMock.Expect("Rollback");
-            else
-                providerMock.ExpectNoCall("Rollback");
-
-            _migrationLoader = new MigrationLoader((ITransformationProvider)providerMock.MockInstance, Assembly.GetExecutingAssembly(), true);
-            _migrationLoader.MigrationsTypes.Add(typeof(MigratorTest.FirstMigration));
-            _migrationLoader.MigrationsTypes.Add(typeof(MigratorTest.SecondMigration));
-            _migrationLoader.MigrationsTypes.Add(typeof(MigratorTest.ThirdMigration));
-            _migrationLoader.MigrationsTypes.Add(typeof(MigratorTest.ForthMigration));
-            _migrationLoader.MigrationsTypes.Add(typeof(MigratorTest.BadMigration));
-            _migrationLoader.MigrationsTypes.Add(typeof(MigratorTest.SixthMigration));
-            _migrationLoader.MigrationsTypes.Add(typeof(MigratorTest.NonIgnoredMigration));
+            providerMock.Expect("Rollback");
         }
-
-        [Test]
-        public void CheckForDuplicatedVersion()
+        else
         {
-            _migrationLoader.MigrationsTypes.Add(typeof(MigratorTest.FirstMigration));
-            Assert.Throws<DuplicatedVersionException>(() =>
-            {
-                _migrationLoader.CheckForDuplicatedVersion();
-            });
+            providerMock.ExpectNoCall("Rollback");
         }
 
-        [Test]
-        public void LastVersion()
-        {
-            Assert.That(7, Is.EqualTo(_migrationLoader.LastVersion));
-        }
+        _migrationLoader = new MigrationLoader((ITransformationProvider)providerMock.MockInstance, Assembly.GetExecutingAssembly(), true);
+        _migrationLoader.MigrationsTypes.Add(typeof(MigratorTest.FirstMigration));
+        _migrationLoader.MigrationsTypes.Add(typeof(MigratorTest.SecondMigration));
+        _migrationLoader.MigrationsTypes.Add(typeof(MigratorTest.ThirdMigration));
+        _migrationLoader.MigrationsTypes.Add(typeof(MigratorTest.ForthMigration));
+        _migrationLoader.MigrationsTypes.Add(typeof(MigratorTest.BadMigration));
+        _migrationLoader.MigrationsTypes.Add(typeof(MigratorTest.SixthMigration));
+        _migrationLoader.MigrationsTypes.Add(typeof(MigratorTest.NonIgnoredMigration));
+    }
 
-        [Test]
-        public void NullIfNoMigrationForVersion()
+    [Test]
+    public void CheckForDuplicatedVersion()
+    {
+        _migrationLoader.MigrationsTypes.Add(typeof(MigratorTest.FirstMigration));
+        Assert.Throws<DuplicatedVersionException>(() =>
         {
-            Assert.That(_migrationLoader.GetMigration(99999999), Is.Null);
-        }
+            _migrationLoader.CheckForDuplicatedVersion();
+        });
+    }
 
-        [Test]
-        public void ZeroIfNoMigrations()
-        {
-            _migrationLoader.MigrationsTypes.Clear();
-            Assert.That(0, Is.EqualTo(_migrationLoader.LastVersion));
-        }
+    [Test]
+    public void LastVersion()
+    {
+        Assert.That(7, Is.EqualTo(_migrationLoader.LastVersion));
+    }
+
+    [Test]
+    public void NullIfNoMigrationForVersion()
+    {
+        Assert.That(_migrationLoader.GetMigration(99999999), Is.Null);
+    }
+
+    [Test]
+    public void ZeroIfNoMigrations()
+    {
+        _migrationLoader.MigrationsTypes.Clear();
+        Assert.That(0, Is.EqualTo(_migrationLoader.LastVersion));
     }
 }