Updated boolean default values in Postgre

Author: JaBistDuNarrisch

src/Migrator.Tests/Providers/PostgreSQL/PostgreSQLTransformationProvider_GetColumnsDefaultValueTests.cs

@@ -36,12 +36,15 @@ public void GetColumns_DataTypeResolveSucceeds()
             new Column(dateTimeColumnName1, DbType.DateTime, dateTimeDefaultValue),
             new Column(dateTimeColumnName2, DbType.DateTime2, dateTimeDefaultValue),
             new Column(decimalColumnName1, DbType.Decimal, DecimalDefaultValue),
-            new Column(guidColumnName1, DbType.Guid, guidDefaultValue)
-        // new Column(booleanColumnName1, DbType.Boolean),
-        // new Column(int32ColumnName1, DbType.Int32),
-        // new Column(int64ColumnName1, DbType.Int64),
-        // new Column(stringColumnName1, DbType.String),
-        // new Column(stringColumnName2, DbType.String) { Size = 30 }
+            new Column(guidColumnName1, DbType.Guid, guidDefaultValue),
+
+            // other boolean default values are tested in another test
+            new Column(booleanColumnName1, DbType.Boolean, true),
+
+            new Column(int32ColumnName1, DbType.Int32, 43),
+            new Column(int64ColumnName1, DbType.Int64, 88),
+            new Column(stringColumnName1, DbType.String),
+            new Column(stringColumnName2, DbType.String) { Size = 30 }
         );
 
         // Act
@@ -52,15 +55,18 @@ public void GetColumns_DataTypeResolveSucceeds()
         var dateTimeColumn2 = columns.Single(x => x.Name == dateTimeColumnName2);
         var decimalColumn1 = columns.Single(x => x.Name == decimalColumnName1);
         var guidColumn1 = columns.Single(x => x.Name == guidColumnName1);
-        // var booleanColumn1 = columns.Single(x => x.Name == booleanColumnName1);
-        // var int32Column1 = columns.Single(x => x.Name == int32ColumnName1);
-        // var int64column1 = columns.Single(x => x.Name == int64ColumnName1);
-        // var stringColumn1 = columns.Single(x => x.Name == stringColumnName1);
-        // var stringColumn2 = columns.Single(x => x.Name == stringColumnName2);
+        var booleanColumn1 = columns.Single(x => x.Name == booleanColumnName1);
+        var int32Column1 = columns.Single(x => x.Name == int32ColumnName1);
+        var int64Column1 = columns.Single(x => x.Name == int64ColumnName1);
+        var stringColumn1 = columns.Single(x => x.Name == stringColumnName1);
+        var stringColumn2 = columns.Single(x => x.Name == stringColumnName2);
 
         Assert.That(dateTimeColumn1.DefaultValue, Is.EqualTo(dateTimeDefaultValue));
         Assert.That(dateTimeColumn2.DefaultValue, Is.EqualTo(dateTimeDefaultValue));
         Assert.That(decimalColumn1.DefaultValue, Is.EqualTo(DecimalDefaultValue));
         Assert.That(guidColumn1.DefaultValue, Is.EqualTo(guidDefaultValue));
+        Assert.That(booleanColumn1.DefaultValue, Is.True);
+        Assert.That(int32Column1.DefaultValue, Is.EqualTo(43));
+        Assert.That(int64Column1.DefaultValue, Is.EqualTo(88));
     }
 }

src/Migrator/Providers/Impl/PostgreSQL/PostgreSQLTransformationProvider.cs

@@ -403,7 +403,21 @@ public override Column[] GetColumns(string table)
                     }
                     else if (column.Type == DbType.Boolean)
                     {
-                        column.DefaultValue = column.DefaultValue.ToString().Trim() == "1" || column.DefaultValue.ToString().Trim().Equals("TRUE", StringComparison.OrdinalIgnoreCase) || column.DefaultValue.ToString().Trim() == "YES";
+                        var truthy = new[] { "1", "TRUE", "YES", "'true'", "on", "'on'", "t", "'t'" };
+                        var falsy = new[] { "0", "FALSE", "NO", "'false'", "off", "'off'", "f", "'f'" };
+
+                        if (truthy.Any(x => x.Equals(defaultValueString.Trim(), StringComparison.OrdinalIgnoreCase)))
+                        {
+                            column.DefaultValue = true;
+                        }
+                        else if (falsy.Any(x => x.Equals(defaultValueString.Trim(), StringComparison.OrdinalIgnoreCase)))
+                        {
+                            column.DefaultValue = false;
+                        }
+                        else
+                        {
+                            throw new NotImplementedException($"Cannot interpret the given default value in column '{column.Name}'");
+                        }
                     }
                     else if (column.Type == DbType.DateTime || column.Type == DbType.DateTime2)
                     {