work on tests with github

Author: jogibear9988

.github/workflows/dotnetpull.yml

@@ -22,3 +22,6 @@ jobs:
     - name: Build
       run: |
         dotnet build Migrator.slnx
+    - name: Test
+      run: |
+        dotnet test Migrator.slnx

src/Migrator.Tests/Providers/MySQL/MySqlTransformationProviderTest.cs

@@ -1,21 +1,8 @@
-#region License
-
-//The contents of this file are subject to the Mozilla Public License
-//Version 1.1 (the "License"); you may not use this file except in
-//compliance with the License. You may obtain a copy of the License at
-//http://www.mozilla.org/MPL/
-//Software distributed under the License is distributed on an "AS IS"
-//basis, WITHOUT WARRANTY OF ANY KIND, either express or implied. See the
-//License for the specific language governing rights and limitations
-//under the License.
-
-#endregion
-
-using System;
-using System.Configuration;
 using System.Data;
 using Migrator.Framework;
 using Migrator.Providers.Mysql;
+using Migrator.Tests.Settings;
+using Migrator.Tests.Settings.Config;
 using NUnit.Framework;
 
 namespace Migrator.Tests.Providers.MySQL;
@@ -27,13 +14,16 @@ public class MySqlTransformationProviderTest : TransformationProviderConstraintB
     [SetUp]
     public void SetUp()
     {
-        var constr = ConfigurationManager.AppSettings["MySqlConnectionString"];
-        if (constr == null)
+        var configReader = new ConfigurationReader();
+        var connectionString = configReader.GetDatabaseConnectionConfigById(DatabaseConnectionConfigIds.MySQL)
+            ?.ConnectionString;
+
+        if (string.IsNullOrEmpty(connectionString))
         {
-            throw new ArgumentNullException("MySqlConnectionString", "No config file");
+            throw new IgnoreException("No MySQL ConnectionString is Set.");
         }
 
-        Provider = new MySqlTransformationProvider(new MysqlDialect(), constr, "default", null);
+        Provider = new MySqlTransformationProvider(new MysqlDialect(), connectionString, "default", null);
         // _provider.Logger = new Logger(true, new ConsoleWriter());
 
         AddDefaultTable();
@@ -58,4 +48,4 @@ public void AddTableWithMyISAMEngine()
                            new Column("name", DbType.String, 50)
             );
     }
-}
+}

src/Migrator.Tests/Providers/Oracle/OracleTransformationProviderTest.cs

@@ -1,8 +1,8 @@
-using System;
-using System.Configuration;
 using System.Data;
 using Migrator.Framework;
 using Migrator.Providers.Oracle;
+using Migrator.Tests.Settings;
+using Migrator.Tests.Settings.Config;
 using NUnit.Framework;
 
 namespace Migrator.Tests.Providers;
@@ -14,13 +14,16 @@ public class OracleTransformationProviderTest : TransformationProviderConstraint
     [SetUp]
     public void SetUp()
     {
-        var constr = ConfigurationManager.AppSettings["OracleConnectionString"];
-        if (constr == null)
+        var configReader = new ConfigurationReader();
+        var connectionString = configReader.GetDatabaseConnectionConfigById(DatabaseConnectionConfigIds.Oracle)
+            ?.ConnectionString;
+
+        if (string.IsNullOrEmpty(connectionString))
         {
-            throw new ArgumentNullException("OracleConnectionString", "No config file");
+            throw new IgnoreException("No Oracle ConnectionString is Set.");
         }
 
-        Provider = new OracleTransformationProvider(new OracleDialect(), constr, null, "default", null);
+        Provider = new OracleTransformationProvider(new OracleDialect(), connectionString, null, "default", null);
         Provider.BeginTransaction();
 
         AddDefaultTable();
@@ -35,4 +38,4 @@ public void ChangeColumn_FromNotNullToNotNull()
         Provider.ChangeColumn("TestTwo", new Column("TestId", DbType.String, 50, ColumnProperty.NotNull));
         Provider.ChangeColumn("TestTwo", new Column("TestId", DbType.String, 50, ColumnProperty.NotNull));
     }
-}
+}

src/Migrator.Tests/Providers/PostgreSQL/PostgreSQLTransformationProviderTest.cs

@@ -1,5 +1,3 @@
-using System;
-using System.Configuration;
 using Migrator.Providers;
 using Migrator.Providers.PostgreSQL;
 using Migrator.Tests.Settings;
@@ -17,7 +15,12 @@ public void SetUp()
     {
         var configReader = new ConfigurationReader();
         var connectionString = configReader.GetDatabaseConnectionConfigById(DatabaseConnectionConfigIds.PostgreSQL)
-            .ConnectionString;
+            ?.ConnectionString;
+
+        if (string.IsNullOrEmpty(connectionString))
+        {
+            throw new IgnoreException("No Postgre ConnectionString is Set.");
+        }
 
         DbProviderFactories.RegisterFactory("Npgsql", () => Npgsql.NpgsqlFactory.Instance);
 
@@ -26,4 +29,4 @@ public void SetUp()
 
         AddDefaultTable();
     }
-}
+}

src/Migrator.Tests/Providers/PostgreSQL/PostgreSQLTransformationProviderTestBase.cs

@@ -16,7 +16,12 @@ public void SetUp()
     {
         var configReader = new ConfigurationReader();
         var connectionString = configReader.GetDatabaseConnectionConfigById(DatabaseConnectionConfigIds.PostgreSQL)
-            .ConnectionString;
+            ?.ConnectionString;
+
+        if (string.IsNullOrEmpty(connectionString))
+        {
+            throw new IgnoreException("No Postgre ConnectionString is Set.");
+        }
 
         DbProviderFactories.RegisterFactory("Npgsql", () => Npgsql.NpgsqlFactory.Instance);
 

src/Migrator.Tests/Providers/SQLServer/SqlServerTransformationProviderGenericTests.cs

@@ -1,22 +1,6 @@
-#region License
-
-//The contents of this file are subject to the Mozilla Public License
-//Version 1.1 (the "License"); you may not use this file except in
-//compliance with the License. You may obtain a copy of the License at
-//http://www.mozilla.org/MPL/
-//Software distributed under the License is distributed on an "AS IS"
-//basis, WITHOUT WARRANTY OF ANY KIND, either express or implied. See the
-//License for the specific language governing rights and limitations
-//under the License.
-
-#endregion
-
 using System.Data;
-using DotNetProjects.Migrator.Providers.Impl.SQLite;
 using Migrator.Providers;
-using Migrator.Providers.SQLite;
 using Migrator.Providers.SqlServer;
-using Migrator.Tests.Providers.Base;
 using Migrator.Tests.Settings;
 using Migrator.Tests.Settings.Config;
 using NUnit.Framework;
@@ -32,7 +16,12 @@ public void SetUp()
     {
         var configReader = new ConfigurationReader();
         var connectionString = configReader.GetDatabaseConnectionConfigById(DatabaseConnectionConfigIds.SQLServerConnectionConfigId)
-            .ConnectionString;
+            .ConnectionString;
+
+        if (string.IsNullOrEmpty(connectionString))
+        {
+            throw new IgnoreException("No SqlServer ConnectionString is Set.");
+        }
 
         DbProviderFactories.RegisterFactory("Microsoft.Data.SqlClient", () => Microsoft.Data.SqlClient.SqlClientFactory.Instance);
 
@@ -84,4 +73,4 @@ public void TableExistsShouldWorkWithTableNamesWithBracket()
     {
         Assert.That(Provider.TableExists("[TestTwo]"), Is.True);
     }
-}
+}

src/Migrator.Tests/Providers/SQLServer2005/SqlServer2005TransformationProviderTest.cs

@@ -3,7 +3,8 @@ namespace Migrator.Tests.Settings.Config;
 public static class DatabaseConnectionConfigIds
 {
     public const string Oracle = "Oracle";
+    public const string MySQL = "MySQL";
     public const string PostgreSQL = "PostgreSQL";
     public const string SQLiteConnectionConfigId = "SQLite";
     public const string SQLServerConnectionConfigId = "SQLServer";
-}
+}

src/Migrator.Tests/Settings/Config/ConnectionIds.cs

@@ -27,7 +27,7 @@ public DatabaseConnectionConfig GetDatabaseConnectionConfigById(string id)
         var databaseConnectionConfigs = configurationRoot.GetSection("DatabaseConnectionConfigs")
             .Get<List<DatabaseConnectionConfig>>() ?? throw new KeyNotFoundException();
 
-        return databaseConnectionConfigs.Single(x => x.Id == id);
+        return databaseConnectionConfigs.SingleOrDefault(x => x.Id == id);
     }
 
     /// <summary>
@@ -37,13 +37,18 @@ public DatabaseConnectionConfig GetDatabaseConnectionConfigById(string id)
     /// <returns></returns>
     public IConfigurationRoot GetConfigurationRoot()
     {
-        var aspNetCoreVariableName = GetAspNetCoreEnvironmentVariable();
 
-        return new ConfigurationBuilder()
+        var builder = new ConfigurationBuilder()
             .SetBasePath(AppDomain.CurrentDomain.BaseDirectory)
-            .AddJsonFile("appsettings.json", optional: false, reloadOnChange: false)
-            .AddJsonFile($"appsettings.{aspNetCoreVariableName}.json", optional: true, reloadOnChange: false)
-            .Build();
+            .AddJsonFile("appsettings.json", optional: false, reloadOnChange: false);
+        var aspNetCoreVariableName = GetAspNetCoreEnvironmentVariable();
+
+        if (!string.IsNullOrEmpty(aspNetCoreVariableName))
+        {
+            builder = builder.AddJsonFile($"appsettings.{aspNetCoreVariableName}.json", optional: true, reloadOnChange: false);
+        }
+
+        return builder.Build();
     }
 
     private static string GetAspNetCoreEnvironmentVariable()
@@ -59,11 +64,6 @@ private static string GetAspNetCoreEnvironmentVariable()
             aspNetCoreVariable = Environment.GetEnvironmentVariable(AspnetCoreVariableString, EnvironmentVariableTarget.Machine);
         }
 
-        if (string.IsNullOrWhiteSpace(aspNetCoreVariable))
-        {
-            throw new Exception($"The environment variable '{AspnetCoreVariableString}' is not set.");
-        }
-
         return aspNetCoreVariable;
     }
-}
+}