Updated AddColumn

Author: Ja bist du narrisch

src/Migrator.Tests/Providers/SQLite/SQLiteTransformationProvider_AddColumnTests.cs

@@ -0,0 +1,75 @@
+using System.Data;
+using System.Linq;
+using DotNetProjects.Migrator.Framework;
+using DotNetProjects.Migrator.Providers.Impl.SQLite;
+using Migrator.Framework;
+using Migrator.Tests.Providers.SQLite.Base;
+using NUnit.Framework;
+using NUnit.Framework.Legacy;
+
+namespace Migrator.Tests.Providers.SQLite;
+
+[TestFixture]
+[Category("SQLite")]
+public class SQLiteTransformationProvider_AddColumnTests : SQLiteTransformationProviderTestBase
+{
+
+    /// <summary>
+    /// We use a NULL column as new column here. NOT NULL will fail as expected. The user should handle that on his own.
+    /// </summary>
+    [Test]
+    public void RemovePrimaryKey_HavingColumnPropertyUniqueAndIndex_RebuildSucceeds()
+    {
+        // Arrange
+        var testTableName = "MyDefaultTestTable";
+        var propertyName1 = "Color1";
+        var propertyName2 = "Color2";
+        var newColumn = "NewColumn";
+        var indexName = "MyIndexName";
+
+        _provider.AddTable(testTableName,
+            new Column(propertyName1, DbType.Int32, ColumnProperty.PrimaryKey),
+            new Column(propertyName2, DbType.Int32, ColumnProperty.Unique)
+        );
+
+        _provider.AddIndex(indexName, testTableName, [propertyName1, propertyName2]);
+        var tableInfoBefore = ((SQLiteTransformationProvider)_provider).GetSQLiteTableInfo(testTableName);
+
+        _provider.ExecuteNonQuery($"INSERT INTO {testTableName} ({propertyName1}, {propertyName2}) VALUES (1, 2)");
+
+        // Act
+        ((SQLiteTransformationProvider)_provider).AddColumn(table: testTableName, new Column(newColumn, DbType.String, ColumnProperty.Null));
+        _provider.ExecuteNonQuery($"INSERT INTO {testTableName} ({propertyName1}, {propertyName2},  {newColumn}) VALUES (2, 3, 'Hello')");
+
+        // Assert
+        using var command = _provider.GetCommand();
+        using var reader = _provider.ExecuteQuery(command, $"SELECT COUNT(*) as Count from {testTableName}");
+        reader.Read();
+        var count = reader.GetInt32(reader.GetOrdinal("Count"));
+        Assert.That(count, Is.EqualTo(2));
+
+        var tableInfoAfter = ((SQLiteTransformationProvider)_provider).GetSQLiteTableInfo(testTableName);
+
+        Assert.That(tableInfoBefore.Columns.Single(x => x.Name == propertyName1).ColumnProperty.HasFlag(ColumnProperty.PrimaryKey), Is.True);
+        Assert.That(tableInfoBefore.Columns.Single(x => x.Name == propertyName2).ColumnProperty.HasFlag(ColumnProperty.Unique), Is.True);
+
+        Assert.That(tableInfoAfter.Columns.Single(x => x.Name == propertyName1).ColumnProperty.HasFlag(ColumnProperty.PrimaryKey), Is.True);
+        Assert.That(tableInfoAfter.Columns.Single(x => x.Name == propertyName2).ColumnProperty.HasFlag(ColumnProperty.Unique), Is.True);
+
+        var indexAfter = tableInfoAfter.Indexes.Single();
+        Assert.That(indexAfter.Name, Is.EqualTo(indexName));
+        CollectionAssert.AreEquivalent(indexAfter.KeyColumns, new string[] { propertyName1, propertyName2 });
+    }
+}
+
+
+
+
+
+
+
+
+
+
+
+

src/Migrator/Providers/Impl/SQLite/SQLiteTransformationProvider.cs

@@ -486,6 +486,7 @@ private void RecreateTable(SQLiteTableInfo sqliteTableInfo)
             AddTable(targetIntermediateTableQuoted, null, dbFields);
 
             var columnMappings = sqliteTableInfo.ColumnMappings
+                .Where(x => x.OldName != null)
                 .OrderBy(x => x.OldName)
                 .ToList();
 
@@ -525,9 +526,10 @@ public override void AddColumn(string table, Column column)
                 throw new Exception("Column already exists.");
             }
 
-            sqliteInfo.ColumnMappings.Add(new MappingInfo { OldName = column.Name, NewName = column.Name });
-
+            sqliteInfo.ColumnMappings.Add(new MappingInfo { OldName = null, NewName = column.Name });
             sqliteInfo.Columns.Add(column);
+
+            RecreateTable(sqliteInfo);
         }
 
         public override void ChangeColumn(string table, Column column)
@@ -544,8 +546,9 @@ public override void ChangeColumn(string table, Column column)
             }
 
             sqliteInfo.Columns.Where(x => !x.Name.Equals(column.Name, StringComparison.InvariantCultureIgnoreCase));
-
             sqliteInfo.Columns.Add(column);
+
+            RecreateTable(sqliteInfo);
         }
 
         public override int TruncateTable(string table)