Merge pull request #50 from dotnetprojects/Sqlite

ChangeColumn test

Author: jogibear9988

src/Migrator.Tests/Providers/SQLite/SQLiteTransformationProvider_AddColumnTests.cs

@@ -18,7 +18,7 @@ public class SQLiteTransformationProvider_AddColumnTests : SQLiteTransformationP
     /// We use a NULL column as new column here. NOT NULL will fail as expected. The user should handle that on his own.
     /// </summary>
     [Test]
-    public void RemovePrimaryKey_HavingColumnPropertyUniqueAndIndex_RebuildSucceeds()
+    public void AddColumn_HavingColumnPropertyUniqueAndIndex_RebuildSucceeds()
     {
         // Arrange
         var testTableName = "MyDefaultTestTable";
@@ -38,8 +38,8 @@ public void RemovePrimaryKey_HavingColumnPropertyUniqueAndIndex_RebuildSucceeds(
         _provider.ExecuteNonQuery($"INSERT INTO {testTableName} ({propertyName1}, {propertyName2}) VALUES (1, 2)");
 
         // Act
-        ((SQLiteTransformationProvider)_provider).AddColumn(table: testTableName, new Column(newColumn, DbType.String, ColumnProperty.Null));
-        _provider.ExecuteNonQuery($"INSERT INTO {testTableName} ({propertyName1}, {propertyName2},  {newColumn}) VALUES (2, 3, 'Hello')");
+        _provider.AddColumn(table: testTableName, new Column(newColumn, DbType.String, ColumnProperty.Null));
+        _provider.ExecuteNonQuery($"INSERT INTO {testTableName} ({propertyName1}, {propertyName2}, {newColumn}) VALUES (2, 3, 'Hello')");
 
         // Assert
         using var command = _provider.GetCommand();

src/Migrator.Tests/Providers/SQLite/SQLiteTransformationProvider_ChangeColumnTests.cs

@@ -0,0 +1,74 @@
+using System.Data;
+using System.Linq;
+using DotNetProjects.Migrator.Framework;
+using DotNetProjects.Migrator.Providers.Impl.SQLite;
+using Migrator.Framework;
+using Migrator.Tests.Providers.SQLite.Base;
+using NUnit.Framework;
+using NUnit.Framework.Legacy;
+
+namespace Migrator.Tests.Providers.SQLite;
+
+[TestFixture]
+[Category("SQLite")]
+public class SQLiteTransformationProvider_ChangeTests : SQLiteTransformationProviderTestBase
+{
+    [Test]
+    public void ChangeColumn_HavingColumnPropertyUniqueAndIndex_RebuildSucceeds()
+    {
+        // Arrange
+        var testTableName = "MyDefaultTestTable";
+        var propertyName1 = "Color1";
+        var propertyName2 = "Color2";
+        var indexName = "MyIndexName";
+
+        _provider.AddTable(testTableName,
+            new Column(propertyName1, DbType.Int32, ColumnProperty.PrimaryKey),
+            new Column(propertyName2, DbType.Int32, ColumnProperty.NotNull)
+        );
+
+        _provider.AddIndex(indexName, testTableName, [propertyName1, propertyName2]);
+        var tableInfoBefore = ((SQLiteTransformationProvider)_provider).GetSQLiteTableInfo(testTableName);
+
+        _provider.ExecuteNonQuery($"INSERT INTO {testTableName} ({propertyName1}, {propertyName2}) VALUES (1, 2)");
+
+        // Act
+        _provider.ChangeColumn(table: testTableName, new Column(propertyName2, DbType.String, ColumnProperty.Unique | ColumnProperty.Null));
+        _provider.ExecuteNonQuery($"INSERT INTO {testTableName} ({propertyName1}, {propertyName2}) VALUES (2, 3)");
+
+        // Assert
+        using var command = _provider.GetCommand();
+        using var reader = _provider.ExecuteQuery(command, $"SELECT COUNT(*) as Count from {testTableName}");
+        reader.Read();
+        var count = reader.GetInt32(reader.GetOrdinal("Count"));
+        Assert.That(count, Is.EqualTo(2));
+
+        var tableInfoAfter = ((SQLiteTransformationProvider)_provider).GetSQLiteTableInfo(testTableName);
+
+        Assert.That(tableInfoBefore.Columns.Single(x => x.Name == propertyName1).ColumnProperty.HasFlag(ColumnProperty.PrimaryKey), Is.True);
+        Assert.That(tableInfoBefore.Columns.Single(x => x.Name == propertyName2).ColumnProperty.HasFlag(ColumnProperty.Unique), Is.False);
+        Assert.That(tableInfoBefore.Columns.Single(x => x.Name == propertyName2).ColumnProperty.HasFlag(ColumnProperty.NotNull), Is.True);
+        Assert.That(tableInfoBefore.Columns.Single(x => x.Name == propertyName2).ColumnProperty.HasFlag(ColumnProperty.Null), Is.False);
+
+        Assert.That(tableInfoAfter.Columns.Single(x => x.Name == propertyName1).ColumnProperty.HasFlag(ColumnProperty.PrimaryKey), Is.True);
+        Assert.That(tableInfoAfter.Columns.Single(x => x.Name == propertyName2).ColumnProperty.HasFlag(ColumnProperty.Unique), Is.True);
+        Assert.That(tableInfoAfter.Columns.Single(x => x.Name == propertyName2).ColumnProperty.HasFlag(ColumnProperty.NotNull), Is.False);
+        Assert.That(tableInfoAfter.Columns.Single(x => x.Name == propertyName2).ColumnProperty.HasFlag(ColumnProperty.Null), Is.True);
+
+        var indexAfter = tableInfoAfter.Indexes.Single();
+        Assert.That(indexAfter.Name, Is.EqualTo(indexName));
+        CollectionAssert.AreEquivalent(indexAfter.KeyColumns, new string[] { propertyName1, propertyName2 });
+    }
+}
+
+
+
+
+
+
+
+
+
+
+
+

src/Migrator/Providers/Impl/SQLite/SQLiteTransformationProvider.cs

@@ -540,12 +540,16 @@ public override void ChangeColumn(string table, Column column)
             }
 
             var sqliteInfo = GetSQLiteTableInfo(table);
+
             if (!sqliteInfo.ColumnMappings.Select(x => x.OldName).ToList().Contains(column.Name))
             {
                 throw new Exception("Column does not exists.");
             }
 
-            sqliteInfo.Columns.Where(x => !x.Name.Equals(column.Name, StringComparison.InvariantCultureIgnoreCase));
+            sqliteInfo.Columns = sqliteInfo.Columns
+                .Where(x => !x.Name.Equals(column.Name, StringComparison.InvariantCultureIgnoreCase))
+                .ToList();
+
             sqliteInfo.Columns.Add(column);
 
             RecreateTable(sqliteInfo);