PostgreSQL GetColumns with default columns are green

Author: JaBistDuNarrisch

src/Migrator.Tests/Providers/OracleProvider/OracleTransformationProvider_GetColumns_Tests.cs

@@ -1,4 +1,8 @@
+using System;
+using System.Data;
+using System.Linq;
 using System.Threading.Tasks;
+using DotNetProjects.Migrator.Framework;
 using Migrator.Tests.Providers.Generic;
 using NUnit.Framework;
 
@@ -13,4 +17,29 @@ public async Task SetUpAsync()
     {
         await BeginOracleTransactionAsync();
     }
+
+    /// <summary>
+    /// Since SQLite does not support binary default values in the generic file a separate test is needed for Oracle
+    /// Find the generic test in the base class.
+    /// </summary>
+    [Test]
+    public void GetColumns_Oracle_DefaultValues_Succeeds()
+    {
+        // Arrange
+        const string testTableName = "MyDefaultTestTable";
+        const string binaryColumnName1 = "binarycolumn1";
+
+        // Should be extended by remaining types
+        Provider.AddTable(testTableName,
+            new Column(binaryColumnName1, DbType.Binary, defaultValue: new byte[] { 12, 32, 34 })
+        );
+
+        // Act
+        var columns = Provider.GetColumns(testTableName);
+
+        // Assert
+        var binarycolumn1 = columns.Single(x => x.Name.Equals(binaryColumnName1, StringComparison.OrdinalIgnoreCase));
+
+        Assert.That(binarycolumn1.DefaultValue, Is.EqualTo(new byte[] { 12, 32, 34 }));
+    }
 }

src/Migrator.Tests/Providers/PostgreSQL/PostgreSQLTransformationProvider_GetColumns_DefaultValueTests.cs

@@ -1,31 +1,41 @@
 using System;
 using System.Data;
 using System.Linq;
+using System.Threading.Tasks;
 using DotNetProjects.Migrator.Framework;
 using Migrator.Tests.Providers.Base;
+using Migrator.Tests.Providers.Generic;
 using NUnit.Framework;
 
 namespace Migrator.Tests.Providers.PostgreSQL;
 
 [TestFixture]
 [Category("Postgre")]
-public class PostgreSQLTransformationProvider_GetColumns_DefaultTypeTests : PostgreSQLTransformationProviderTestBase
+public class PostgreSQLTransformationProvider_GetColumns_DefaultTypeTests : TransformationProvider_GetColumns_GenericTests
 {
+    [SetUp]
+    public async Task SetUpAsync()
+    {
+        await BeginPostgreSQLTransactionAsync();
+    }
+
     /// <summary>
     /// More tests for GetColumns  <see cref="ITransformationProvider.GetColumns"/> in <see cref="TransformationProviderBase"/>
     /// </summary>
     [Test]
-    public void GetColumns_DefaultValuesInterval_Succeeds()
+    public void GetColumns_Postgres_DefaultValues_Succeeds()
     {
         // Arrange
         const string testTableName = "MyDefaultTestTable";
         const string intervalColumnName1 = "intervalcolumn1";
         const string intervalColumnName2 = "intervalcolumn2";
+        const string binaryColumnName1 = "binarycolumn1";
 
         // Should be extended by remaining types
         Provider.AddTable(testTableName,
             new Column(intervalColumnName1, MigratorDbType.Interval, defaultValue: new TimeSpan(100000, 3, 4, 5, 666)),
-            new Column(intervalColumnName2, MigratorDbType.Interval, defaultValue: new TimeSpan(0, 0, 0, 0, 666))
+            new Column(intervalColumnName2, MigratorDbType.Interval, defaultValue: new TimeSpan(0, 0, 0, 0, 666)),
+            new Column(binaryColumnName1, DbType.Binary, defaultValue: new byte[] { 12, 32, 34 })
         );
 
         // Act
@@ -34,9 +44,11 @@ public void GetColumns_DefaultValuesInterval_Succeeds()
         // Assert
         var intervalColumn1 = columns.Single(x => x.Name == intervalColumnName1);
         var intervalColumn2 = columns.Single(x => x.Name == intervalColumnName2);
+        var binarycolumn1 = columns.Single(x => x.Name.Equals(binaryColumnName1, StringComparison.OrdinalIgnoreCase));
 
         Assert.That(intervalColumn1.DefaultValue, Is.EqualTo(new TimeSpan(100000, 3, 4, 5, 666)));
         Assert.That(intervalColumn2.DefaultValue, Is.EqualTo(new TimeSpan(0, 0, 0, 0, 666)));
+        Assert.That(binarycolumn1.DefaultValue, Is.EqualTo(new byte[] { 12, 32, 34 }));
     }
 
     // 1 will coerce to true on inserts but not for default values in Postgre SQL - same for 0 to false

src/Migrator/Providers/Impl/PostgreSQL/PostgreSQLDialect.cs

@@ -124,7 +124,7 @@ public override string Default(object defaultValue)
         else if (defaultValue is byte[] byteArray)
         {
             var convertedString = BitConverter.ToString(byteArray).Replace("-", "").ToLower();
-            return $"'\\x{convertedString}'";
+            return @$"DEFAULT E'\\x{convertedString}'";
         }
 
         return base.Default(defaultValue);