Merge branch 'master' of https://github.com/dotnetprojects/Migrator.NET into gh-actions

# Conflicts:
#	src/Migrator.Tests/Migrator.Tests.csproj

Author: jogibear9988

src/Migrator.Tests/Migrator.Tests.csproj

@@ -25,15 +25,10 @@
       <PrivateAssets>all</PrivateAssets>
       <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
     </PackageReference>
-    <PackageReference Include="NUnit.Mocks" Version="2.6.4" />
   </ItemGroup>
 
   <ItemGroup>
     <Reference Include="System.Configuration" />
-    <Reference Include="System.Data.SqlServerCe, Version=3.5.0.0, Culture=neutral, PublicKeyToken=89845dcd8080cc91, processorArchitecture=MSIL">
-      <HintPath>..\..\lib\System.Data.SqlServerCe.dll</HintPath>
-      <SpecificVersion>False</SpecificVersion>
-    </Reference>
   </ItemGroup>
 
   <ItemGroup>

src/Migrator.Tests/Providers/Base/TransformationProviderBase.cs

@@ -292,10 +292,7 @@ public void AppliedMigrations()
         Assert.That(Provider.TableExists("SchemaInfo"), Is.True, "No SchemaInfo table created");
     }
 
-    /// <summary>
-    /// Reproduce bug reported by Luke Melia & Daniel Berlinger :
-    /// http://macournoyer.wordpress.com/2006/10/15/migrate-nant-task/#comment-113
-    /// </summary>
+
     [Test]
     public void CommitTwice()
     {

…tgreSQLTransformationProviderTestBase.cs …tgreSQLTransformationProviderTestBase.cssrc/Migrator.Tests/Providers/PostgreSQL/PostgreSQLTransformationProviderTestBase.cs renamed to src/Migrator.Tests/Providers/PostgreSQL/Base/PostgreSQLTransformationProviderTestBase.cs src/Migrator.Tests/Providers/PostgreSQL/PostgreSQLTransformationProviderTestBase.cs renamed to src/Migrator.Tests/Providers/PostgreSQL/Base/PostgreSQLTransformationProviderTestBase.cs

@@ -0,0 +1,46 @@
+using System;
+using System.Data;
+using Migrator.Framework;
+using Npgsql;
+using NUnit.Framework;
+
+namespace Migrator.Tests.Providers.PostgreSQL;
+
+[TestFixture]
+[Category("Postgre")]
+public class PostgreSQLTransformationProvider_PrimaryKeyWithIdentityTests : PostgreSQLTransformationProviderTestBase
+{
+    [Test]
+    public void AddTableWithPrimaryKeyIdentity_Succeeds()
+    {
+        // Arrange
+        const string testTableName = "MyDefaultTestTable";
+        const string propertyName1 = "Color1";
+        const string propertyName2 = "Color2";
+
+        Provider.AddTable(testTableName,
+            new Column(propertyName1, DbType.Int32, ColumnProperty.PrimaryKeyWithIdentity),
+            new Column(propertyName2, DbType.Int32, ColumnProperty.Unsigned)
+        );
+
+        // Act
+        Provider.Insert(testTableName, [propertyName2], [1]);
+        Provider.Insert(testTableName, [propertyName2], [1]);
+
+        // Assert
+        using (var command = Provider.GetCommand())
+        {
+            using var reader = Provider.ExecuteQuery(command, $"SELECT max({propertyName1}) as max from {testTableName}");
+            reader.Read();
+
+            var primaryKeyValue = reader.GetInt32(reader.GetOrdinal("max"));
+            Assert.That(primaryKeyValue, Is.EqualTo(2));
+        }
+
+        // Act II
+        var exception = Assert.Throws<PostgresException>(() => Provider.Insert(testTableName, [propertyName1, propertyName2], [1, 888]));
+
+        // Assert II
+        Assert.That(exception.Message, Does.Contain("cannot insert a non-DEFAULT value into column"));
+    }
+}

src/Migrator.Tests/Providers/PostgreSQL/PostgreSQLTransformationProvider_PrimaryKeyWithIdentityTests.cs

@@ -0,0 +1,49 @@
+using System.Data;
+using Microsoft.Data.SqlClient;
+using Migrator.Framework;
+using Migrator.Tests.Providers.SQLServer.Base;
+using NUnit.Framework;
+
+namespace Migrator.Tests.Providers.SQLServer;
+
+[TestFixture]
+[Category("SqlServer")]
+public class SqlServerTransformationProvider_NVARCHARnTests : SQLServerTransformationProviderTestBase
+{
+    [Test]
+    public void AddTableWithFixedLengthEqualTo4000Characters_ShouldCreateNVARCHAR4000()
+    {
+        // Arrange
+        const string testTableName = "MyDefaultTestTable";
+        const string propertyName1 = "Color1";
+
+        Provider.AddTable(testTableName,
+            new Column(propertyName1, DbType.String, 4000)
+        );
+
+        var stringLength4001 = new string('A', 4001);
+
+        // Act
+        var exception = Assert.Throws<SqlException>(() => Provider.Insert(testTableName, [propertyName1], [stringLength4001]));
+
+        Assert.That(exception.Errors[0].Message, Does.Contain("String or binary data would be truncated"));
+    }
+
+    [Test]
+    public void AddTableWithFixedLengthGreaterThan4000Characters_ShouldCreateNVARCHARMAX()
+    {
+        // Arrange
+        const string testTableName = "MyDefaultTestTable";
+        const string propertyName1 = "Color1";
+
+
+        Provider.AddTable(testTableName,
+            new Column(propertyName1, DbType.String, 4001)
+        );
+
+        var stringLength5000 = new string('A', 5000);
+
+        // Act
+        Provider.Insert(testTableName, [propertyName1], [stringLength5000]);
+    }
+}

src/Migrator.Tests/Providers/SQLServer/SQLServerTransformationProvider_NVARCHARnTests.cs

@@ -37,7 +37,7 @@ public enum ColumnProperty
     Indexed = 1 << 4,
 
     /// <summary>
-    /// Unsigned Column. Not used in SQLite there is only on integer data type INTEGER.
+    /// Unsigned Column. Not used in SQLite there is only one integer data type => INTEGER.
     /// </summary>
     Unsigned = 1 << 5,