Foreign key adjustments

Author: Ja bist du narrisch

src/Migrator.Tests/Providers/SQLite/SQLiteTransformationProvider_RemoveColumnTests.cs

@@ -63,44 +63,44 @@ public void RemoveColumn_HavingNoCompositeIndexAndNoCompositeUniqueConstraint_Su
     public void RemoveColumn_HavingASingleForeignKeyPointingToTheTargetColumn_SingleColumnForeignKeyIsRemoved()
     {
         // Arrange
-        const string testTableName = "Color";
+        const string parentTableName = "Parent";
         const string propertyName1 = "Id";
         const string propertyName2 = "OtherProperty";
-        const string childTestTableName = "ChildTable";
+        const string childTestTableName = "Child";
         const string childTestTableName2 = "ChildTable2";
         const string propertyChildTableName1 = "ColorId";
 
-        Provider.AddTable(testTableName,
+        Provider.AddTable(parentTableName,
             new Column(propertyName1, DbType.Int32, ColumnProperty.PrimaryKey),
             new Column(propertyName2, DbType.Int32, ColumnProperty.Unique)
         );
 
         Provider.AddTable(childTestTableName, new Column(propertyChildTableName1, DbType.Int32));
-        Provider.AddForeignKey("Not used in SQLite", childTestTableName, propertyChildTableName1, testTableName, propertyName1);
+        Provider.AddForeignKey("Not used in SQLite", childTestTableName, propertyChildTableName1, parentTableName, propertyName1);
         var script = ((SQLiteTransformationProvider)Provider).GetSqlCreateTableScript(childTestTableName);
 
         Provider.AddTable(childTestTableName2, new Column(propertyChildTableName1, DbType.Int32));
-        Provider.AddForeignKey(name: "Not used in SQLite", childTable: childTestTableName2, childColumn: propertyChildTableName1, parentTable: testTableName, parentColumn: propertyName2);
+        Provider.AddForeignKey(name: "Not used in SQLite", childTable: childTestTableName2, childColumn: propertyChildTableName1, parentTable: parentTableName, parentColumn: propertyName2);
 
-        var tableInfoBefore = ((SQLiteTransformationProvider)Provider).GetSQLiteTableInfo(testTableName);
+        var tableInfoBefore = ((SQLiteTransformationProvider)Provider).GetSQLiteTableInfo(parentTableName);
         var tableInfoChildBefore = ((SQLiteTransformationProvider)Provider).GetSQLiteTableInfo(childTestTableName);
 
-        Provider.ExecuteNonQuery($"INSERT INTO {testTableName} ({propertyName1}, {propertyName2}) VALUES (1, 2)");
+        Provider.ExecuteNonQuery($"INSERT INTO {parentTableName} ({propertyName1}, {propertyName2}) VALUES (1, 2)");
         Provider.ExecuteNonQuery($"INSERT INTO {childTestTableName} ({propertyChildTableName1}) VALUES (1)");
         Provider.ExecuteNonQuery($"INSERT INTO {childTestTableName2} ({propertyChildTableName1}) VALUES (2)");
 
         // Act
-        Provider.RemoveColumn(testTableName, propertyName1);
+        Provider.RemoveColumn(parentTableName, propertyName1);
 
         // Assert
-        Provider.ExecuteNonQuery($"INSERT INTO {testTableName} ({propertyName2}) VALUES (3)");
+        Provider.ExecuteNonQuery($"INSERT INTO {parentTableName} ({propertyName2}) VALUES (3)");
         using var command = Provider.GetCommand();
-        using var reader = Provider.ExecuteQuery(command, $"SELECT COUNT(*) as Count from {testTableName}");
+        using var reader = Provider.ExecuteQuery(command, $"SELECT COUNT(*) as Count from {parentTableName}");
         reader.Read();
         var count = reader.GetInt32(reader.GetOrdinal("Count"));
         Assert.That(count, Is.EqualTo(2));
 
-        var tableInfoAfter = ((SQLiteTransformationProvider)Provider).GetSQLiteTableInfo(testTableName);
+        var tableInfoAfter = ((SQLiteTransformationProvider)Provider).GetSQLiteTableInfo(parentTableName);
 
         Assert.That(tableInfoBefore.Columns.Single(x => x.Name == propertyName1).ColumnProperty.HasFlag(ColumnProperty.PrimaryKey), Is.True);
         Assert.That(tableInfoBefore.Columns.Single(x => x.Name == propertyName2).ColumnProperty.HasFlag(ColumnProperty.Unique), Is.True);
@@ -201,4 +201,68 @@ public void RemoveColumn_HavingMultipleSingleUniques_Succeeds()
         Assert.That(tableInfoBefore.Uniques.Count, Is.EqualTo(2));
         Assert.That(tableInfoAfter.Uniques.Count, Is.EqualTo(1));
     }
+
+    [Test]
+    public void RemoveColumn_HavingAForeignKeyPointingFromTableToParentAndForeignKeyPointingToTable_SingleColumnForeignKeyIsRemoved()
+    {
+        // Arrange
+        const string tableNameLevel1 = "Level1";
+        const string tableNameLevel2 = "Level2";
+        const string tableNameLevel3 = "Level3";
+        const string propertyId = "Id";
+        const string propertyLevel1Id = "Level1Id";
+        const string propertyLevel2Id = "Level2Id";
+
+        Provider.AddTable(tableNameLevel1, new Column(propertyId, DbType.Int32, ColumnProperty.PrimaryKey));
+
+        Provider.AddTable(tableNameLevel2,
+            new Column(propertyId, DbType.Int32, ColumnProperty.PrimaryKey),
+            new Column(propertyLevel1Id, DbType.Int32, ColumnProperty.Unique)
+        );
+
+        Provider.AddTable(tableNameLevel3,
+            new Column(propertyId, DbType.Int32, ColumnProperty.PrimaryKey),
+            new Column(propertyLevel2Id, DbType.Int32)
+        );
+
+        Provider.AddForeignKey("Level2ToLevel1", tableNameLevel2, propertyLevel1Id, tableNameLevel1, propertyId);
+        Provider.AddForeignKey("Level3ToLevel2", tableNameLevel3, propertyLevel2Id, tableNameLevel2, propertyId);
+
+        var script = ((SQLiteTransformationProvider)Provider).GetSqlCreateTableScript(tableNameLevel2);
+
+        var tableInfoLevel2Before = ((SQLiteTransformationProvider)Provider).GetSQLiteTableInfo(tableNameLevel2);
+        var tableInfoLevel3Before = ((SQLiteTransformationProvider)Provider).GetSQLiteTableInfo(tableNameLevel3);
+
+        Provider.ExecuteNonQuery($"INSERT INTO {tableNameLevel1} ({propertyId}) VALUES (1)");
+        Provider.ExecuteNonQuery($"INSERT INTO {tableNameLevel1} ({propertyId}) VALUES (2)");
+        Provider.ExecuteNonQuery($"INSERT INTO {tableNameLevel2} ({propertyId}, {propertyLevel1Id}) VALUES (1, 1)");
+        Provider.ExecuteNonQuery($"INSERT INTO {tableNameLevel3} ({propertyId}, {propertyLevel2Id}) VALUES (1, 1)");
+
+        // Act
+        Provider.RemoveColumn(tableNameLevel2, propertyLevel1Id);
+
+        // Assert
+        Provider.ExecuteNonQuery($"INSERT INTO {tableNameLevel2} ({propertyId}) VALUES (2)");
+        using var command = Provider.GetCommand();
+
+        using var reader = Provider.ExecuteQuery(command, $"SELECT COUNT(*) as Count from {tableNameLevel2}");
+        reader.Read();
+        var count = reader.GetInt32(reader.GetOrdinal("Count"));
+        Assert.That(count, Is.EqualTo(2));
+
+        var tableInfoLevel2After = ((SQLiteTransformationProvider)Provider).GetSQLiteTableInfo(tableNameLevel2);
+
+        Assert.That(tableInfoLevel2Before.Columns.Single(x => x.Name == propertyId).ColumnProperty.HasFlag(ColumnProperty.PrimaryKey), Is.True);
+        Assert.That(tableInfoLevel2Before.Columns.Single(x => x.Name == propertyLevel1Id).ColumnProperty.HasFlag(ColumnProperty.Unique), Is.True);
+        Assert.That(tableInfoLevel2Before.ForeignKeys.Single().ChildColumns.Single(), Is.EqualTo(propertyLevel1Id));
+
+        Assert.That(tableInfoLevel2After.Columns.FirstOrDefault(x => x.Name == propertyId), Is.Not.Null);
+        Assert.That(tableInfoLevel2After.Columns.FirstOrDefault(x => x.Name == propertyLevel1Id), Is.Null);
+        Assert.That(tableInfoLevel2After.Columns.FirstOrDefault(x => x.Name == propertyId), Is.Not.Null);
+        Assert.That(tableInfoLevel2After.Columns.FirstOrDefault(x => x.Name == propertyLevel1Id), Is.Null);
+        Assert.That(tableInfoLevel2After.ForeignKeys, Is.Empty);
+
+        var valid = ((SQLiteTransformationProvider)Provider).CheckForeignKeyIntegrity();
+        Assert.That(valid, Is.True);
+    }
 }

src/Migrator/Providers/Impl/SQLite/SQLiteTransformationProvider.cs

@@ -414,10 +414,11 @@ public override void RemoveColumn(string tableName, string column)
                 }
             }
 
-            sqliteInfoMainTable.Uniques.RemoveAll(x => x.KeyColumns.Length == 1 && x.KeyColumns[0] == column);
+            sqliteInfoMainTable.Uniques.RemoveAll(x => x.KeyColumns.Length == 1 && x.KeyColumns[0].Equals(column, StringComparison.OrdinalIgnoreCase));
             sqliteInfoMainTable.ColumnMappings.RemoveAll(x => x.OldName.Equals(column, StringComparison.OrdinalIgnoreCase));
             sqliteInfoMainTable.Columns.RemoveAll(x => x.Name.Equals(column, StringComparison.OrdinalIgnoreCase));
-            sqliteInfoMainTable.Indexes.RemoveAll(x => x.KeyColumns.Length == 1 && x.KeyColumns[0] == column);
+            sqliteInfoMainTable.Indexes.RemoveAll(x => x.KeyColumns.Length == 1 && x.KeyColumns[0].Equals(column, StringComparison.OrdinalIgnoreCase));
+            sqliteInfoMainTable.ForeignKeys.RemoveAll(x => x.ChildColumns.Length == 1 && x.ChildColumns[0].Equals(column, StringComparison.OrdinalIgnoreCase));
 
             RecreateTable(sqliteInfoMainTable);
         }