Oracle, SQL Server, SQLite and Postgre SQL Begin Transaction moved to base class

JaBistDuNarrisch · JaBistDuNarrisch · commit c3d24ad2094b · 2025-08-13T09:15:41.000+02:00
diff --git a/src/Migrator.Tests/Providers/Base/TransformationProviderBase.cs b/src/Migrator.Tests/Providers/Base/TransformationProviderBase.cs
@@ -1,12 +1,12 @@
 ﻿using System;
-using System.Data;
-using System.Linq;
 using System.Threading;
 using System.Threading.Tasks;
 using DotNetProjects.Migrator.Framework;
 using DotNetProjects.Migrator.Providers;
 using DotNetProjects.Migrator.Providers.Impl.Oracle;
+using DotNetProjects.Migrator.Providers.Impl.PostgreSQL;
 using DotNetProjects.Migrator.Providers.Impl.SQLite;
+using DotNetProjects.Migrator.Providers.Impl.SqlServer;
 using DryIoc;
 using Migrator.Tests.Database;
 using Migrator.Tests.Database.Interfaces;
@@ -24,7 +24,7 @@ public abstract class TransformationProviderBase
 {
     protected ITransformationProvider Provider;
 
-    protected async Task StartOracleTransactionAsync()
+    protected async Task BeginOracleTransactionAsync()
     {
         using var cts = new CancellationTokenSource(TimeSpan.FromSeconds(10));
         var configReader = new ConfigurationReader();
@@ -51,6 +51,25 @@ protected async Task StartOracleTransactionAsync()
         Provider.BeginTransaction();
     }
 
+    protected async Task BeginPostgreSQLTransactionAsync()
+    {
+        var configReader = new ConfigurationReader();
+        var connectionString = configReader.GetDatabaseConnectionConfigById(DatabaseConnectionConfigIds.PostgreSQL)
+            ?.ConnectionString;
+
+        if (string.IsNullOrEmpty(connectionString))
+        {
+            throw new IgnoreException("No Postgre ConnectionString is Set.");
+        }
+
+        DbProviderFactories.RegisterFactory("Npgsql", () => Npgsql.NpgsqlFactory.Instance);
+
+        Provider = new PostgreSQLTransformationProvider(new PostgreSQLDialect(), connectionString, null, "default", "Npgsql");
+        Provider.BeginTransaction();
+
+        await Task.CompletedTask;
+    }
+
     protected async Task BeginSQLiteTransactionAsync()
     {
         var configReader = new ConfigurationReader();
@@ -62,4 +81,30 @@ protected async Task BeginSQLiteTransactionAsync()
 
         await Task.CompletedTask;
     }
+
+    protected async Task BeginSQLServerTransactionAsync()
+    {
+        var configReader = new ConfigurationReader();
+
+        var databaseConnectionConfig = configReader.GetDatabaseConnectionConfigById(DatabaseConnectionConfigIds.SQLServerId);
+
+        var connectionString = databaseConnectionConfig?.ConnectionString;
+
+        if (string.IsNullOrEmpty(connectionString))
+        {
+            throw new IgnoreException($"No SQL Server {nameof(DatabaseConnectionConfig.ConnectionString)} is set.");
+        }
+
+        DbProviderFactories.RegisterFactory("Microsoft.Data.SqlClient", () => Microsoft.Data.SqlClient.SqlClientFactory.Instance);
+
+        using var container = new Container();
+        container.RegisterDatabaseIntegrationTestService();
+        var databaseIntegrationTestServiceFactory = container.Resolve<IDatabaseIntegrationTestServiceFactory>();
+        var sqlServerIntegrationTestService = databaseIntegrationTestServiceFactory.Create(DatabaseProviderType.SQLServer);
+        var databaseInfo = await sqlServerIntegrationTestService.CreateTestDatabaseAsync(databaseConnectionConfig, CancellationToken.None);
+
+        Provider = new SqlServerTransformationProvider(new SqlServerDialect(), databaseInfo.DatabaseConnectionConfig.ConnectionString, "dbo", "default", "Microsoft.Data.SqlClient");
+
+        Provider.BeginTransaction();
+    }
 }
diff --git a/src/Migrator.Tests/Providers/OracleProvider/Base/OracleTransformationProviderTestBase.cs b/src/Migrator.Tests/Providers/OracleProvider/Base/OracleTransformationProviderTestBase.cs
@@ -19,7 +19,7 @@ public class OracleTransformationProviderTestBase : TransformationProviderSimple
     [SetUp]
     public async Task SetUpAsync()
     {
-        await StartOracleTransactionAsync();
+        await BeginOracleTransactionAsync();
 
         AddDefaultTable();
     }
diff --git a/src/Migrator.Tests/Providers/OracleProvider/OracleTransformationProviderGenericTests.cs b/src/Migrator.Tests/Providers/OracleProvider/OracleTransformationProviderGenericTests.cs
@@ -23,7 +23,7 @@ public class OracleTransformationProviderGenericTests : TransformationProviderGe
     [SetUp]
     public async Task SetUpAsync()
     {
-        await StartOracleTransactionAsync();
+        await BeginOracleTransactionAsync();
 
         AddDefaultTable();
     }
diff --git a/src/Migrator.Tests/Providers/PostgreSQL/PostgreSQLTransformationProviderGenericTests.cs b/src/Migrator.Tests/Providers/PostgreSQL/PostgreSQLTransformationProviderGenericTests.cs
@@ -0,0 +1,18 @@
+using System.Threading.Tasks;
+using Migrator.Tests.Providers.Generic;
+using NUnit.Framework;
+
+namespace Migrator.Tests.Providers.PostgreSQL;
+
+[TestFixture]
+[Category("Postgre")]
+public class PostgreSQLTransformationProviderGenericTests : TransformationProviderGenericMiscConstraintBase
+{
+    [SetUp]
+    public async Task SetUpAsync()
+    {
+        await BeginPostgreSQLTransactionAsync();
+
+        AddDefaultTable();
+    }
+}
diff --git a/src/Migrator.Tests/Providers/PostgreSQL/PostgreSQLTransformationProviderTest.cs b/src/Migrator.Tests/Providers/PostgreSQL/PostgreSQLTransformationProviderTest.cs
diff --git a/src/Migrator.Tests/Providers/SQLServer/SqlServerTransformationProviderGenericTests.cs b/src/Migrator.Tests/Providers/SQLServer/SqlServerTransformationProviderGenericTests.cs
@@ -7,6 +7,7 @@
 using DryIoc;
 using Migrator.Tests.Database;
 using Migrator.Tests.Database.Interfaces;
+using Migrator.Tests.Providers.Generic;
 using Migrator.Tests.Settings;
 using Migrator.Tests.Settings.Config;
 using Migrator.Tests.Settings.Models;
@@ -16,32 +17,12 @@ namespace Migrator.Tests.Providers.SQLServer;
 
 [TestFixture]
 [Category("SqlServer")]
-public class SqlServerTransformationProviderGenericTests : TransformationProviderConstraintBase
+public class SqlServerTransformationProviderGenericTests : TransformationProviderGenericMiscConstraintBase
 {
     [SetUp]
     public async Task SetUpAsync()
     {
-        var configReader = new ConfigurationReader();
-
-        var databaseConnectionConfig = configReader.GetDatabaseConnectionConfigById(DatabaseConnectionConfigIds.SQLServerId);
-
-        var connectionString = databaseConnectionConfig?.ConnectionString;
-
-        if (string.IsNullOrEmpty(connectionString))
-        {
-            throw new IgnoreException($"No SQL Server {nameof(DatabaseConnectionConfig.ConnectionString)} is set.");
-        }
-
-        DbProviderFactories.RegisterFactory("Microsoft.Data.SqlClient", () => Microsoft.Data.SqlClient.SqlClientFactory.Instance);
-
-        using var container = new Container();
-        container.RegisterDatabaseIntegrationTestService();
-        var databaseIntegrationTestServiceFactory = container.Resolve<IDatabaseIntegrationTestServiceFactory>();
-        var sqlServerIntegrationTestService = databaseIntegrationTestServiceFactory.Create(DatabaseProviderType.SQLServer);
-        var databaseInfo = await sqlServerIntegrationTestService.CreateTestDatabaseAsync(databaseConnectionConfig, CancellationToken.None);
-
-        Provider = new SqlServerTransformationProvider(new SqlServerDialect(), databaseInfo.DatabaseConnectionConfig.ConnectionString, "dbo", "default", "Microsoft.Data.SqlClient");
-        Provider.BeginTransaction();
+        dfdfg
 
         AddDefaultTable();
     }
diff --git a/src/Migrator.Tests/Providers/SQLite/Base/SQLiteTransformationProviderTestBase.cs b/src/Migrator.Tests/Providers/SQLite/Base/SQLiteTransformationProviderTestBase.cs
@@ -1,3 +1,4 @@
+using System.Threading.Tasks;
 using DotNetProjects.Migrator.Providers.Impl.SQLite;
 using Migrator.Tests.Providers.Base;
 using Migrator.Tests.Settings;
@@ -11,7 +12,7 @@ namespace Migrator.Tests.Providers.SQLite.Base;
 public abstract class SQLiteTransformationProviderTestBase : TransformationProviderSimpleBase
 {
     [SetUp]
-    public void SetUp()
+    public async Task SetUpAsync()
     {
         var configReader = new ConfigurationReader();
         var connectionString = configReader.GetDatabaseConnectionConfigById(DatabaseConnectionConfigIds.SQLiteId)
@@ -20,6 +21,6 @@ public void SetUp()
         Provider = new SQLiteTransformationProvider(new SQLiteDialect(), connectionString, "default", null);
         Provider.BeginTransaction();
 
-        AddDefaultTable();
+        await Task.CompletedTask;
     }
 }
diff --git a/src/Migrator.Tests/Providers/SQLite/SQLiteTransformationProviderGenericTests.cs b/src/Migrator.Tests/Providers/SQLite/SQLiteTransformationProviderGenericTests.cs
@@ -1,24 +1,17 @@
-using DotNetProjects.Migrator.Providers.Impl.SQLite;
-using Migrator.Tests.Providers.Base;
-using Migrator.Tests.Settings;
-using Migrator.Tests.Settings.Config;
+using System.Threading.Tasks;
+using Migrator.Tests.Providers.Generic;
 using NUnit.Framework;
 
 namespace Migrator.Tests.Providers.SQLite;
 
 [TestFixture]
 [Category("SQLite")]
-public class SQLiteTransformationProviderGenericTests : TransformationProviderBase
+public class SQLiteTransformationProviderGenericTests : TransformationProviderGenericMiscConstraintBase
 {
     [SetUp]
-    public void SetUp()
+    public async Task SetUpAsync()
     {
-        var configReader = new ConfigurationReader();
-        var connectionString = configReader.GetDatabaseConnectionConfigById(DatabaseConnectionConfigIds.SQLiteId)
-            .ConnectionString;
-
-        Provider = new SQLiteTransformationProvider(new SQLiteDialect(), connectionString, "default", null);
-        Provider.BeginTransaction();
+        await BeginSQLiteTransactionAsync();
 
         AddDefaultTable();
     }
diff --git a/src/Migrator.Tests/Providers/SQLite/SQLiteTransformationProvider_RenameColumnTests.cs b/src/Migrator.Tests/Providers/SQLite/SQLiteTransformationProvider_RenameColumnTests.cs
@@ -1,16 +1,15 @@
-using System;
 using System.Data;
 using System.Linq;
 using DotNetProjects.Migrator.Framework;
 using DotNetProjects.Migrator.Providers.Impl.SQLite;
-using Migrator.Tests.Providers.SQLite.Base;
+using Migrator.Tests.Providers.Base;
 using NUnit.Framework;
 
 namespace Migrator.Tests.Providers.SQLite;
 
 [TestFixture]
 [Category("SQLite")]
-public class SQLiteTransformationProvider_RenameColumnTests : SQLiteTransformationProviderTestBase
+public class SQLiteTransformationProvider_RenameColumnTests : TransformationProviderBase
 {
     [Test]
     public void RenameColumn_HavingASingleForeignKeyPointingToTheTargetColumn_SingleColumnForeignKeyIsRemoved()

Original file line number	Diff line number	Diff line change
`@@ -19,7 +19,7 @@ public class OracleTransformationProviderTestBase : TransformationProviderSimple`
`19`	`19`	`[SetUp]`
`20`	`20`	`public async Task SetUpAsync()`
`21`	`21`	`{`
`22`		`- await StartOracleTransactionAsync();`
	`22`	`+ await BeginOracleTransactionAsync();`
`23`	`23`
`24`	`24`	`AddDefaultTable();`
`25`	`25`	`}`
Original file line number	Diff line number	Diff line change
`@@ -23,7 +23,7 @@ public class OracleTransformationProviderGenericTests : TransformationProviderGe`
`23`	`23`	`[SetUp]`
`24`	`24`	`public async Task SetUpAsync()`
`25`	`25`	`{`
`26`		`- await StartOracleTransactionAsync();`
	`26`	`+ await BeginOracleTransactionAsync();`
`27`	`27`
`28`	`28`	`AddDefaultTable();`
`29`	`29`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,4 @@`
	`1`	`+using System.Threading.Tasks;`
`1`	`2`	`using DotNetProjects.Migrator.Providers.Impl.SQLite;`
`2`	`3`	`using Migrator.Tests.Providers.Base;`
`3`	`4`	`using Migrator.Tests.Settings;`
`@@ -11,7 +12,7 @@ namespace Migrator.Tests.Providers.SQLite.Base;`
`11`	`12`	`public abstract class SQLiteTransformationProviderTestBase : TransformationProviderSimpleBase`
`12`	`13`	`{`
`13`	`14`	`[SetUp]`
`14`		`- public void SetUp()`
	`15`	`+ public async Task SetUpAsync()`
`15`	`16`	`{`
`16`	`17`	`var configReader = new ConfigurationReader();`
`17`	`18`	`var connectionString = configReader.GetDatabaseConnectionConfigById(DatabaseConnectionConfigIds.SQLiteId)`
`@@ -20,6 +21,6 @@ public void SetUp()`
`20`	`21`	`Provider = new SQLiteTransformationProvider(new SQLiteDialect(), connectionString, "default", null);`
`21`	`22`	`Provider.BeginTransaction();`
`22`	`23`
`23`		`- AddDefaultTable();`
	`24`	`+ await Task.CompletedTask;`
`24`	`25`	`}`
`25`	`26`	`}`