Updated TableExists and ViewExists

Author: Ja bist du narrisch

src/Migrator/Providers/Impl/SqlServer/SqlServerTransformationProvider.cs

@@ -16,7 +16,6 @@
 using System;
 using System.Collections.Generic;
 using System.Data;
-using System.Data.Common;
 using System.Globalization;
 using Index = Migrator.Framework.Index;
 
@@ -64,7 +63,35 @@ protected virtual void CreateConnection(string providerName)
             collationString = "Latin1_General_CI_AS";
         }
 
-        this.Dialect.RegisterProperty(ColumnProperty.CaseSensitive, "COLLATE " + collationString.Replace("_CI_", "_CS_"));
+        Dialect.RegisterProperty(ColumnProperty.CaseSensitive, "COLLATE " + collationString.Replace("_CI_", "_CS_"));
+    }
+
+    public override bool TableExists(string tableName)
+    {
+        // This is not clean! Usually you should use schema as well as this query will find tables in other tables as well!
+
+        using var cmd = CreateCommand();
+        using var reader = ExecuteQuery(cmd, $"SELECT OBJECT_ID('{tableName}', 'U')");
+
+        var result = cmd.ExecuteScalar();
+
+        var tableExists = result != DBNull.Value && result != null;
+
+        return tableExists;
+    }
+
+    public override bool ViewExists(string viewName)
+    {
+        // This is not clean! Usually you should use schema as well as this query will find views in other tables as well!
+
+        using var cmd = CreateCommand();
+        using var reader = ExecuteQuery(cmd, $"SELECT OBJECT_ID('{viewName}', 'V')");
+
+        var result = cmd.ExecuteScalar();
+
+        var viewExists = result != DBNull.Value && result != null;
+
+        return viewExists;
     }
 
     public override bool ConstraintExists(string table, string name)
@@ -183,50 +210,6 @@ public override void RemoveColumnDefaultValue(string table, string column)
         }
     }
 
-
-    public override bool TableExists(string table)
-    {
-        string schema;
-
-        var firstIndex = table.IndexOf(".");
-        if (firstIndex >= 0)
-        {
-            schema = table.Substring(0, firstIndex).Trim();
-            table = table.Substring(firstIndex + 1).Trim();
-        }
-        else
-        {
-            schema = _defaultSchema;
-        }
-
-        schema = schema.StartsWith("[") && schema.EndsWith("]") ? schema.Substring(1, schema.Length - 2) : schema;
-        table = table.StartsWith("[") && table.EndsWith("]") ? table.Substring(1, table.Length - 2) : table;
-
-        using var cmd = CreateCommand();
-        using var reader = base.ExecuteQuery(cmd, string.Format("SELECT * FROM INFORMATION_SCHEMA.TABLES WHERE TABLE_NAME='{0}' AND TABLE_SCHEMA='{1}'", table, schema));
-        return reader.Read();
-    }
-
-    public override bool ViewExists(string view)
-    {
-        string schema;
-
-        var firstIndex = view.IndexOf(".");
-        if (firstIndex >= 0)
-        {
-            schema = view.Substring(0, firstIndex);
-            view = view.Substring(firstIndex + 1);
-        }
-        else
-        {
-            schema = _defaultSchema;
-        }
-
-        using var cmd = CreateCommand();
-        using var reader = base.ExecuteQuery(cmd, string.Format("SELECT * FROM INFORMATION_SCHEMA.VIEWS WHERE TABLE_NAME='{0}' AND TABLE_SCHEMA='{1}'", view, schema));
-        return reader.Read();
-    }
-
     public override Index[] GetIndexes(string table)
     {
         var retVal = new List<Index>();

src/Migrator/Providers/TransformationProvider.cs

@@ -558,28 +558,12 @@ public virtual void RemoveColumnDefaultValue(string table, string column)
 
     public virtual bool TableExists(string table)
     {
-        try
-        {
-            ExecuteNonQuery("SELECT COUNT(*) FROM " + table);
-            return true;
-        }
-        catch (Exception)
-        {
-            return false;
-        }
+        throw new NotImplementedException();
     }
 
     public virtual bool ViewExists(string view)
     {
-        try
-        {
-            ExecuteNonQuery("SELECT COUNT(*) FROM " + view);
-            return true;
-        }
-        catch (Exception)
-        {
-            return false;
-        }
+        throw new NotImplementedException();
     }
 
     public virtual void SwitchDatabase(string databaseName)