Adjusted tests due to not supported PrimaryKeyExists in SQLite

Author: JaBistDuNarrisch

src/Migrator.Tests/Providers/Generic/TransformationProviderGenericMiscConstraintBase.cs

@@ -44,7 +44,15 @@ public void AddCheckConstraint()
     public void CanAddPrimaryKey()
     {
         AddPrimaryKey();
-        Assert.That(Provider.PrimaryKeyExists("Test", "PK_Test"), Is.True);
+
+        if (Provider is SQLiteTransformationProvider)
+        {
+            Assert.Throws<NotSupportedException>(() => Provider.PrimaryKeyExists("Test", "PK_Test"));
+        }
+        else
+        {
+            Assert.That(Provider.PrimaryKeyExists("Test", "PK_Test"), Is.True);
+        }
     }
 
     [Test]

src/Migrator.Tests/Providers/SQLite/Base/SQLiteTransformationProviderTestBase.cs

@@ -1,8 +1,5 @@
 using System.Threading.Tasks;
-using DotNetProjects.Migrator.Providers.Impl.SQLite;
 using Migrator.Tests.Providers.Base;
-using Migrator.Tests.Settings;
-using Migrator.Tests.Settings.Config;
 using NUnit.Framework;
 
 namespace Migrator.Tests.Providers.SQLite.Base;
@@ -14,15 +11,7 @@ public abstract class SQLiteTransformationProviderTestBase : TransformationProvi
     [SetUp]
     public async Task SetUpAsync()
     {
-        var configReader = new ConfigurationReader();
-        var connectionString = configReader.GetDatabaseConnectionConfigById(DatabaseConnectionConfigIds.SQLiteId)
-            .ConnectionString;
-
-        Provider = new SQLiteTransformationProvider(new SQLiteDialect(), connectionString, "default", null);
-        Provider.BeginTransaction();
-
+        await BeginSQLiteTransactionAsync();
         AddDefaultTable();
-
-        await Task.CompletedTask;
     }
 }

src/Migrator.Tests/Providers/SQLite/SQLiteTransformationProvider_RemoveColumnTests.cs

@@ -198,8 +198,9 @@ public void RemoveColumn_HavingMultipleSingleUniques_Succeeds()
         Provider.RemoveColumn(testTableName, propertyName2);
         var tableInfoAfter = ((SQLiteTransformationProvider)Provider).GetSQLiteTableInfo(testTableName);
 
-        Assert.That(tableInfoBefore.Uniques.Count, Is.EqualTo(2));
-        Assert.That(tableInfoAfter.Uniques.Count, Is.EqualTo(1));
+        // We do not support not named uniques in SQLite any more.
+        Assert.That(tableInfoBefore.Uniques.Count, Is.EqualTo(0));
+        Assert.That(tableInfoAfter.Uniques.Count, Is.EqualTo(0));
     }
 
     [Test]

src/Migrator.Tests/Providers/SQLite/SQLiteTransformationProvider_RenameColumnTests.cs

@@ -3,13 +3,14 @@
 using DotNetProjects.Migrator.Framework;
 using DotNetProjects.Migrator.Providers.Impl.SQLite;
 using Migrator.Tests.Providers.Base;
+using Migrator.Tests.Providers.SQLite.Base;
 using NUnit.Framework;
 
 namespace Migrator.Tests.Providers.SQLite;
 
 [TestFixture]
 [Category("SQLite")]
-public class SQLiteTransformationProvider_RenameColumnTests : TransformationProviderBase
+public class SQLiteTransformationProvider_RenameColumnTests : SQLiteTransformationProviderTestBase
 {
     [Test]
     public void RenameColumn_HavingASingleForeignKeyPointingToTheTargetColumn_SingleColumnForeignKeyIsRemoved()

src/Migrator/Providers/TransformationProvider.cs

@@ -14,6 +14,7 @@
 using DotNetProjects.Migrator.Framework;
 using DotNetProjects.Migrator.Framework.Loggers;
 using DotNetProjects.Migrator.Framework.SchemaBuilder;
+using DotNetProjects.Migrator.Providers.Impl.SQLite;
 using DotNetProjects.Migrator.Providers.Models;
 using System;
 using System.Collections.Generic;
@@ -392,9 +393,9 @@ public virtual void AddView(string name, string tableName, params IViewElement[]
     /// </example>
     public virtual void AddTable(string name, params IDbField[] columns)
     {
-        if (columns.Any(x => x is CheckConstraint))
+        if (this is not SQLiteTransformationProvider && columns.Any(x => x is CheckConstraint))
         {
-            throw new MigrationException($"{nameof(CheckConstraint)}s are currently supported in SQLite only.");
+            throw new MigrationException($"{nameof(CheckConstraint)}s are currently only supported in SQLite.");
         }
 
         // Most databases don't have the concept of a storage engine, so default is to not use it.