Skip to content

Automatic column creation does not create all columns #49

@gcurtis-pds

Description

@gcurtis-pds

The version 3.3 merge added new logic for ItemSourceHelper.CreateColumnFromPropertyDescription and ItemSourceHelper.SetPropertyDescriptions methods.

During creation of columns it now additionally checks whether the property description IsDisplayable in addition to IsBrowsable.
The newer logic also added during this merge creates descriptions by calling ItemSourceHelper.SetPropertyDescriptions with displayable set to "false" by default. Other usages of this method pass "true".
With this check in place some columns may not be created when the control is initialized with automatic creation enabled.

I am trying to determine whether or not the check is invalid, if the default "displayable" value passed should be updated to be "true" as is done in other places, or if there is some other reason that is causing property descriptions to not have the correct IsDisplayable value to pass this check.

Check for IsBrowsable and IsDisplayable:

if( !propertyDescription.IsBrowsable || !propertyDescription.IsDisplayable )

Lines setting displayable to false:

ItemsSourceHelper.SetPropertyDescriptions( childPropertyDescriptions, null, null, parentItemType, false );

ItemsSourceHelper.SetPropertyDescriptions( propertyDescriptions, model, itemsSource, itemType, false );

Lines setting displayable to true:

ItemsSourceHelper.SetPropertyDescriptions( collection, null, itemsSource, null, true );

ItemsSourceHelper.SetPropertyDescriptions( m_defaultPropertyDescriptions, modelDataTable, m_enumeration, m_itemType, true );

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions