removed get and setters, using class project as result

Author: Death111

src/main/java/de/doubleslash/keeptime/controller/Controller.java

@@ -92,6 +92,7 @@ public void changeProject(final Project newProject, final long minusSeconds) {
    }
 
    public void addNewProject(final Project project) {
+      LOG.info("Creating new project '{}'.", project);
       model.getAllProjects().add(project);
       model.getAvailableProjects().add(project);
 

src/main/java/de/doubleslash/keeptime/view/ManageProjectController.java

@@ -13,7 +13,6 @@
 import javafx.scene.control.TextArea;
 import javafx.scene.control.TextField;
 import javafx.scene.layout.GridPane;
-import javafx.scene.paint.Color;
 
 public class ManageProjectController {
 
@@ -39,35 +38,20 @@ public class ManageProjectController {
    @FXML
    private Spinner<Integer> sortIndexSpinner;
 
-   public String getProjectName() {
-      return nameTextField.getText();
-   }
-
-   public String getProjectDescription() {
-      return descriptionTextArea.getText();
-   }
-
-   public Color getProjectColor() {
-      return textFillColorPicker.getValue();
-   }
-
-   public boolean isWork() {
-      return isWorkCheckBox.isSelected();
-   }
-
-   public int getIndex() {
-      return sortIndexSpinner.getValue();
-   }
-
    public void setModel(final Model model) {
       this.model = model;
    }
 
-   public Project getValues() {
-      return new Project(getProjectName(), getProjectDescription(), getProjectColor(), isWork(), getIndex());
+   public void secondInitialize() {
+      if (model != null) {
+         final int availableProjectAmount = model.getAllProjects().size();
+         sortIndexSpinner
+               .setValueFactory(new IntegerSpinnerValueFactory(0, availableProjectAmount, availableProjectAmount));
+         sortIndexSpinner.getValueFactory().setValue(model.getAvailableProjects().size());
+      }
    }
 
-   public void setValues(final Project project) {
+   public void initializeWith(final Project project) {
       LOG.info("Setting values.");
       nameTextField.setText(project.getName());
       descriptionTextArea.setText(project.getDescription());
@@ -76,13 +60,9 @@ public void setValues(final Project project) {
       sortIndexSpinner.getValueFactory().setValue(project.getIndex());
    }
 
-   public void secondInitialize() {
-      if (model != null) {
-         final int availableProjectAmount = model.getAllProjects().size();
-         sortIndexSpinner
-               .setValueFactory(new IntegerSpinnerValueFactory(0, availableProjectAmount, availableProjectAmount));
-         sortIndexSpinner.getValueFactory().setValue(model.getAvailableProjects().size());
-      }
+   public Project getProjectFromUserInput() {
+      return new Project(nameTextField.getText(), descriptionTextArea.getText(), textFillColorPicker.getValue(),
+            isWorkCheckBox.isSelected(), sortIndexSpinner.getValue());
    }
 
 }

src/main/java/de/doubleslash/keeptime/view/ProjectsListViewController.java

@@ -324,16 +324,11 @@ private GridPane setUpEditProjectGridPane(final Project p, final Dialog<Project>
       final ManageProjectController manageProjectController = loader.getController();
       manageProjectController.setModel(model);
       manageProjectController.secondInitialize();
-      manageProjectController.setValues(p);
+      manageProjectController.initializeWith(p);
 
       dialog.setResultConverter(dialogButton -> {
          if (dialogButton == ButtonType.OK) {
-            final String projectName = manageProjectController.getProjectName();
-            final String projectDescription = manageProjectController.getProjectDescription();
-            final Color projectColor = manageProjectController.getProjectColor();
-            final boolean isWork = manageProjectController.isWork();
-            final int index = manageProjectController.getIndex();
-            return new Project(projectName, projectDescription, projectColor, isWork, index);
+            return manageProjectController.getProjectFromUserInput();
          }
          // TODO: Do you really want to return null?
          return null;

src/main/java/de/doubleslash/keeptime/view/ViewController.java

@@ -306,17 +306,7 @@ private Dialog<Project> dialogResultConverter(final Dialog<Project> dialog,
          final ManageProjectController manageProjectController) {
       dialog.setResultConverter(dialogButton -> {
          if (dialogButton == ButtonType.OK) {
-            final String projectName = manageProjectController.getProjectName();
-            final String projectDescription = manageProjectController.getProjectDescription();
-            final Color projectColor = manageProjectController.getProjectColor();
-            final boolean isWork = manageProjectController.isWork();
-            final int index = manageProjectController.getIndex();
-            return new Project(projectName, projectDescription, projectColor, isWork, index); // temporary
-                                                                                              // (misused)
-                                                                                              // transfer
-                                                                                              // object
-                                                                                              // for
-                                                                                              // project
+            return manageProjectController.getProjectFromUserInput();
          }
          // TODO: Do you really want to return null?
          return null;