Skip to content

Commit 22d3d6f

Browse files
author
Martin Plieske
committed
resolved some change requests
1 parent 26a2c57 commit 22d3d6f

File tree

3 files changed

+11
-11
lines changed

3 files changed

+11
-11
lines changed

src/main/java/de/doubleslash/keeptime/common/ColorTimeLine.java renamed to src/main/java/de/doubleslash/keeptime/view/ColorTimeLine.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
package de.doubleslash.keeptime.common;
1+
package de.doubleslash.keeptime.view;
22

33
import java.time.Duration;
44

src/main/java/de/doubleslash/keeptime/view/ReportController.java

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@
1212

1313
import com.sun.javafx.scene.control.skin.DatePickerSkin;
1414

15-
import de.doubleslash.keeptime.common.ColorTimeLine;
1615
import de.doubleslash.keeptime.common.DateFormatter;
1716
import de.doubleslash.keeptime.common.DateProvider;
1817
import de.doubleslash.keeptime.controller.Controller;
@@ -65,7 +64,7 @@ public class ReportController {
6564

6665
private static final Logger LOG = LoggerFactory.getLogger(ReportController.class);
6766

68-
private DatePicker datePicker; // for calender element
67+
private DatePicker datePicker; // for calendar element
6968

7069
private Model model;
7170

@@ -123,10 +122,7 @@ private void updateReport(final LocalDate newvalue) {
123122
this.gridPane.add(workedTimeLabel, 2, rowIndex);
124123

125124
// text will be set later
126-
/*
127-
* final TextArea textArea = new TextArea(); textArea.setMaxHeight(20); textArea.setFont(Font.font("System",
128-
* FontWeight.NORMAL, 15)); textArea.setWrapText(true); this.gridPane.add(textArea, 1, rowIndex);
129-
*/
125+
130126
final Button bProjectReport = createProjectReport();
131127
this.gridPane.add(bProjectReport, 1, rowIndex);
132128

@@ -157,15 +153,13 @@ private void updateReport(final LocalDate newvalue) {
157153

158154
rowIndex++;
159155
}
160-
// textArea.setText(pr.getNotes(true));
161156
bProjectReport.setUserData(pr.getNotes(true));
162157
}
163158
this.scrollPane.setVvalue(0); // scroll to the top
164159

165160
this.currentDayTimeLabel.setText(DateFormatter.secondsToHHMMSS(currentSeconds));
166161
this.currentDayWorkTimeLabel.setText(DateFormatter.secondsToHHMMSS(currentWorkSeconds));
167162

168-
controller = new Controller(model, dateProvider);
169163
colorTimeLine = new ColorTimeLine(reportColorTimeLine, model, controller);
170164
colorTimeLine.update();
171165
}
@@ -217,4 +211,8 @@ public void updateItem(final LocalDate item, final boolean empty) {
217211
public void update() {
218212
updateReport(this.datePicker.getValue());
219213
}
214+
215+
public void setController(final Controller controller) {
216+
this.controller = controller;
217+
}
220218
}

src/main/java/de/doubleslash/keeptime/view/ViewController.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@
1616
import org.springframework.stereotype.Component;
1717

1818
import de.doubleslash.keeptime.common.ColorHelper;
19-
import de.doubleslash.keeptime.common.ColorTimeLine;
2019
import de.doubleslash.keeptime.common.DateFormatter;
2120
import de.doubleslash.keeptime.common.Resources;
2221
import de.doubleslash.keeptime.common.Resources.RESOURCE;
@@ -122,6 +121,8 @@ public class ViewController {
122121
@FXML
123122
private Canvas canvas;
124123

124+
private ColorTimeLine mainColorTimeLine;
125+
125126
private static final Logger LOG = LoggerFactory.getLogger(ViewController.class);
126127

127128
private class Delta {
@@ -316,11 +317,11 @@ private void initialize() {
316317
label.setText(DateFormatter.secondsToHHMMSS(seconds));
317318
}
318319

319-
final ColorTimeLine mainColorTimeLine = new ColorTimeLine(canvas, model, controller);
320320
mainColorTimeLine.update();
321321
updateTaskbarIcon(currentWorkSeconds);
322322
});
323323

324+
mainColorTimeLine = new ColorTimeLine(canvas, model, controller);
324325
}
325326

326327
private Dialog<Project> dialogResultConverter(final Dialog<Project> dialog, final GridPane grid) {
@@ -424,6 +425,7 @@ private void loadSubStages() {
424425
final Parent sceneRoot = fxmlLoader.load();
425426
reportController = fxmlLoader.getController();
426427
reportController.setModel(model);
428+
reportController.setController(controller);
427429
reportStage = new Stage();
428430
reportStage.initModality(Modality.APPLICATION_MODAL);
429431
reportStage.setScene(new Scene(sceneRoot));

0 commit comments

Comments
 (0)