#165: Code Refactoring

Author: mairKi

pom.xml

@@ -114,12 +114,7 @@
       <artifactId>spring-boot-starter-validation</artifactId>
     </dependency>
 
-    <!-- https://mvnrepository.com/artifact/org.springframework.boot/spring-boot-starter-security -->
-    <dependency>
-      <groupId>org.springframework.boot</groupId>
-      <artifactId>spring-boot-starter-security</artifactId>
-      <version>3.1.3</version>
-    </dependency>
+
 
     <dependency>
       <groupId>org.glassfish.jaxb</groupId>

src/main/java/de/doubleslash/keeptime/view/LoginController.java

@@ -13,25 +13,6 @@ public LoginController(final String username, final String password) {
       this.password = password;
    }
 
-   public String getUsername() {
-      username = extractValue(properties.getProperty("spring.security.user.name"));
-
-      return username;
-   }
-
-   public String getPassword() {
-      password = extractValue(properties.getProperty("spring.security.user.password"));
-      return password;
-   }
-
-   public void setUsername(final String username) {
-      this.username = username;
-   }
-
-   public void setPassword(final String password) {
-      this.password = password;
-   }
-
    public void createAndSaveUser() {
       properties.setProperty("spring.security.user.name", "${BASIC_AUTH_USER:" + this.username + "}");
       properties.setProperty("spring.security.user.password", "${BASIC_AUTH_PASSWORD:" + this.password + "}");

src/test/java/de/doubleslash/keeptime/REST_API_Test/ApiTest.java

@@ -31,14 +31,14 @@ public void testExtractValuePassword() {
 
    @Test
    public void testCreateAndSaveUser() {
-      String username = "testUser";
-      String password = "testPassword";
+      String username = "User";
+      String password = "123A";
       LoginController loginController = new LoginController(username, password);
 
       loginController.createAndSaveUser();
       Properties properties = loginController.properties;
-      assertEquals("${BASIC_AUTH_USER:testUser}", properties.getProperty("spring.security.user.name"));
-      assertEquals("${BASIC_AUTH_PASSWORD:testPassword}", properties.getProperty("spring.security.user.password"));
+      assertEquals("${BASIC_AUTH_USER:User}", properties.getProperty("spring.security.user.name"));
+      assertEquals("${BASIC_AUTH_PASSWORD:123A}", properties.getProperty("spring.security.user.password"));
    }
 }