there are almost no sonar issues left

Author: mplieske

src/main/java/de/doubleslash/keeptime/Main.java

@@ -157,7 +157,7 @@ private void initialisePopupUI(final Stage primaryStage) throws IOException {
       popupViewStage.setAlwaysOnTop(true);
       final ViewControllerPopup viewControllerPopupController = loader.getController();
       viewControllerPopupController.setStage(popupViewStage);
-      viewControllerPopupController.setController(controller, model);
+      viewControllerPopupController.setControllerAndModel(controller, model);
       globalScreenListener.setViewController(viewControllerPopupController);
 
    }

src/main/java/de/doubleslash/keeptime/common/DateFormatter.java

@@ -19,9 +19,8 @@ public static String secondsToHHMMSS(final long currentWorkSeconds) {
 
       final int sec = (int) (currentWorkSeconds % 3600 % 60);
 
-      final String a = (hours > 9 ? hours : "0" + hours) + ":" + (minutes > 9 ? minutes : "0" + minutes) + ":"
+      return (hours > 9 ? hours : "0" + hours) + ":" + (minutes > 9 ? minutes : "0" + minutes) + ":"
             + (sec > 9 ? sec : "0" + sec);
-      return a;
    }
 
    public static long getSecondsBewtween(final LocalDateTime startDate, final LocalDateTime endDate) {

src/main/java/de/doubleslash/keeptime/model/Model.java

@@ -49,7 +49,7 @@ public Model(final ProjectRepository projectRepository, final WorkRepository wor
    protected static final ObservableList<Work> pastWorkItems = FXCollections.observableArrayList();
    public static final ObjectProperty<Work> activeWorkItem = new SimpleObjectProperty<>();
 
-   public static final long NEEDED_WORK_SECONDS = 60 * 60 * 8; // 8 hours
+   public static final long NEEDED_WORK_SECONDS = (long) (60 * 60 * 8.0); // 8 hours
 
    public static final ObjectProperty<Color> TASK_BAR_COLOR = new SimpleObjectProperty<>(ORIGINAL_TASK_BAR_FONT_COLOR);
 

src/main/java/de/doubleslash/keeptime/view/ViewController.java

@@ -453,8 +453,7 @@ private void loadSubStages() {
    }
 
    private FXMLLoader createFXMLLoader(final RESOURCE fxmlLayout) {
-      final FXMLLoader fxmlLoader = new FXMLLoader(Resources.getResource(fxmlLayout));
-      return fxmlLoader;
+      return new FXMLLoader(Resources.getResource(fxmlLayout));
    }
 
    private Node addProjectToProjectList(final Project p) {

src/main/java/de/doubleslash/keeptime/viewpopup/ViewControllerPopup.java

@@ -38,7 +38,6 @@ public class ViewControllerPopup {
    private Stage stage;
 
    private Controller controller;
-   private Model model;
 
    private FilteredList<Project> filteredData;
 
@@ -160,9 +159,8 @@ protected void updateItem(final Project project, final boolean empty) {
 
    }
 
-   public void setController(final Controller controller, final Model model) {
+   public void setControllerAndModel(final Controller controller, final Model model) {
       this.controller = controller;
-      this.model = model;
 
       filteredData = new FilteredList<>(model.getSortedAvailableProjects(), p -> true);
       projectListView.setItems(filteredData);