#178: make validation logic consistent

Author: Death111

src/main/java/de/doubleslash/keeptime/view/ExternalProjectsSyncController.java

@@ -213,11 +213,7 @@ private HBox createRow(Color color, String text) {
 
       Consumer<Spinner<LocalTime>> spinnerValidConsumer = (Spinner<LocalTime> spinner) -> {
          final boolean isValid = areSecondsOfDayValid(spinner.getValue().toSecondOfDay());
-         if (!isValid) {
-            spinner.setStyle("-fx-border-color: red; -fx-border-width: 2px; -fx-border-radius: 4px;");
-         } else {
-            spinner.setStyle(""); // Reset to default style
-         }
+         markNodeValidOrNot(spinner, isValid);
       };
       timeColumn.setCellFactory(column -> new TableCell<>() {
          private final Spinner<LocalTime> timeSpinner = new Spinner<>();
@@ -263,11 +259,8 @@ protected void updateItem(TableRow item, boolean empty) {
       notesColumn.setCellValueFactory(data -> new SimpleObjectProperty<>(data.getValue())); // Placeholder property
 
       Consumer<TextArea> textAreaValid = (TextArea textArea) -> {
-         if (textArea.getText().isBlank()) {
-            textArea.setStyle("-fx-border-color: red; -fx-border-width: 2px; -fx-border-radius: 4px;");
-         } else {
-            textArea.setStyle(""); // Reset to default style
-         }
+         final boolean isValid = !textArea.getText().isBlank();
+         markNodeValidOrNot(textArea, isValid);
       };
       notesColumn.setCellFactory(column -> new TableCell<>() {
          private ChangeListener<String> stringChangeListener;
@@ -299,8 +292,12 @@ protected void updateItem(TableRow item, boolean empty) {
             copyHeimatNotes.setTooltip(new Tooltip("Copy notes"));
             copyHeimatNotes.setOnAction(me -> copyToClipboard(heimatNotesLabel.getText()));
 
-            hbox.getChildren().addAll(copyKeepTimeNotes, new Label("KeepTime:"), keepTimeNotesLabel);
-            hbox2.getChildren().addAll(copyHeimatNotes, new Label("HEIMAT:"), heimatNotesLabel);
+            final Label keeptimeLabel = new Label("KeepTime:");
+            keeptimeLabel.setMinWidth(60);
+            hbox.getChildren().addAll(copyKeepTimeNotes, keeptimeLabel, keepTimeNotesLabel);
+            final Label heimatLabel = new Label("HEIMAT:");
+            heimatLabel.setMinWidth(60);
+            hbox2.getChildren().addAll(copyHeimatNotes, heimatLabel, heimatNotesLabel);
             container.getChildren().addAll(textArea, hbox, hbox2);
          }
 
@@ -404,6 +401,14 @@ protected List<HeimatController.HeimatErrors> call() {
       // TODO offer some way to book time to an additional project?
    }
 
+   private static void markNodeValidOrNot(final Node textArea, final boolean isValid) {
+      String borderColor = "lightgreen";
+      if (!isValid) {
+         borderColor = "lightcoral";
+      }
+      textArea.setStyle("-fx-border-color: " + borderColor + "; -fx-border-width: 1px; -fx-border-radius: 4px;");
+   }
+
    private static boolean areSecondsOfDayValid(final long seconds) {
       long minutes = (seconds / 60);
       final boolean isInvalid = seconds % 60 != 0 || minutes % 15 != 0 || minutes <= 0;