code review changes

Author: ddamke

src/main/java/de/doubleslash/keeptime/view/ManageProjectController.java

@@ -76,11 +76,8 @@ private void initialize() {
       validateTextAlert.visibleProperty().bind(formValidProperty.not());
 
       Platform.runLater(() ->{
-         if(nameTextField.getText().isBlank()){
             nameTextField.requestFocus();
-         }else {
-            descriptionTextArea.requestFocus();
-         }
+            nameTextField.end();
       });
    }
 

src/main/resources/layouts/manage-project.fxml

@@ -33,10 +33,10 @@
       <Label text="IsWork:" GridPane.rowIndex="5" />
       <Label text="SortIndex:" GridPane.rowIndex="6" />
       <TextField fx:id="nameTextField" GridPane.columnIndex="1" />
+      <TextArea fx:id="descriptionTextArea" prefHeight="120.0" prefWidth="300.0" GridPane.columnIndex="1" GridPane.rowIndex="2" />
       <ColorPicker fx:id="textFillColorPicker" GridPane.columnIndex="1" GridPane.rowIndex="4" />
       <CheckBox fx:id="isWorkCheckBox" mnemonicParsing="false" selected="true" GridPane.columnIndex="1" GridPane.rowIndex="5" />
       <Spinner fx:id="sortIndexSpinner" GridPane.columnIndex="1" GridPane.rowIndex="6" />
-      <TextArea fx:id="descriptionTextArea" prefHeight="120.0" prefWidth="300.0" GridPane.columnIndex="1" GridPane.rowIndex="2" />
       <VBox alignment="CENTER_LEFT" GridPane.rowIndex="2">
          <children>
             <Label text="Description:" />

src/main/resources/layouts/manage-work.fxml

@@ -11,7 +11,7 @@
 <?import javafx.scene.layout.RowConstraints?>
 <?import javafx.scene.text.Font?>
 
-<GridPane fx:id="grid" hgap="5.0" maxHeight="-Infinity" maxWidth="-Infinity" minHeight="-Infinity" minWidth="-Infinity" prefHeight="214.0" prefWidth="371.0" vgap="5.0" xmlns="http://javafx.com/javafx/8.0.202-ea" xmlns:fx="http://javafx.com/fxml/1" fx:controller="de.doubleslash.keeptime.view.ManageWorkController">
+<GridPane fx:id="grid" hgap="5.0" maxHeight="-Infinity" maxWidth="-Infinity" minHeight="-Infinity" minWidth="-Infinity" prefHeight="214.0" prefWidth="371.0" vgap="5.0" xmlns="http://javafx.com/javafx/8.0.171" xmlns:fx="http://javafx.com/fxml/1" fx:controller="de.doubleslash.keeptime.view.ManageWorkController">
   <columnConstraints>
     <ColumnConstraints hgrow="SOMETIMES" />
     <ColumnConstraints hgrow="SOMETIMES" maxWidth="200.0" minWidth="100.0" prefWidth="150.0" />
@@ -23,6 +23,7 @@
     <RowConstraints minHeight="10.0" prefHeight="30.0" vgrow="SOMETIMES" />
     <RowConstraints vgrow="SOMETIMES" />
     <RowConstraints vgrow="SOMETIMES" />
+      <RowConstraints />
   </rowConstraints>
   <children>
     <Label text="Start">
@@ -31,12 +32,14 @@
       </font>
     </Label>
     <DatePicker fx:id="startDatePicker" GridPane.columnIndex="1" />
+    <Spinner fx:id="startTimeSpinner" editable="true" GridPane.columnIndex="2" />
     <Label text="End" GridPane.rowIndex="1">
       <font>
         <Font name="Open Sans Regular" size="12.0" />
       </font>
     </Label>
     <DatePicker fx:id="endDatePicker" GridPane.columnIndex="1" GridPane.rowIndex="1" />
+    <Spinner fx:id="endTimeSpinner" editable="true" GridPane.columnIndex="2" GridPane.rowIndex="1" />
     <Label text="Project" GridPane.rowIndex="3">
       <font>
         <Font name="Open Sans Regular" size="12.0" />
@@ -48,8 +51,6 @@
         <Font name="Open Sans Regular" size="12.0" />
       </font>
     </Label>
-    <Spinner fx:id="startTimeSpinner" editable="true" GridPane.columnIndex="2" />
-    <Spinner fx:id="endTimeSpinner" editable="true" GridPane.columnIndex="2" GridPane.rowIndex="1" />
     <TextArea fx:id="noteTextArea" prefHeight="200.0" prefWidth="200.0" wrapText="true" GridPane.columnIndex="1" GridPane.columnSpan="2" GridPane.rowIndex="4" />
     <Label text="Changing the times may result in overlapping times!" textFill="#ffa100" GridPane.columnIndex="1" GridPane.columnSpan="2" GridPane.rowIndex="2">
       <font>