made tablecells look more clickable; added License and license headers

Martin Plieske · Martin Plieske · commit a84e64e657d3 · 2019-04-02T14:35:46.000+02:00
diff --git a/COPYING.txt b/COPYING.txt
diff --git a/assembly.xml b/assembly.xml
@@ -1,3 +1,5 @@
+<!-- Copyright 2019 doubleSlash Net Business GmbH -->
+
 <assembly xmlns="http://maven.apache.org/ASSEMBLY/2.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
   xsi:schemaLocation="http://maven.apache.org/ASSEMBLY/2.0.0 http://maven.apache.org/xsd/assembly-2.0.0.xsd">
   
diff --git a/keeptime.bat b/keeptime.bat
@@ -1 +1,2 @@
+# Copyright 2019 doubleSlash Net Business GmbH
 start "" "javaw" -Dprism.order=sw -jar keeptime-v1.0.0.jar
diff --git a/logging.properties b/logging.properties
@@ -1,3 +1,5 @@
+# Copyright 2019 doubleSlash Net Business GmbH
+
 #Thu Jul 05 16:50:17 CEST 2018
 .level=INFO
 application.Log$ConsoleHandler.format={8_level} | {message_80} {time} {origin} \n{exception}
diff --git a/src/main/java/de/doubleslash/keeptime/DefaultExceptionHandler.java b/src/main/java/de/doubleslash/keeptime/DefaultExceptionHandler.java
@@ -1,3 +1,5 @@
+// Copyright 2019 doubleSlash Net Business GmbH
+
 package de.doubleslash.keeptime;
 
 import java.lang.Thread.UncaughtExceptionHandler;
diff --git a/src/main/java/de/doubleslash/keeptime/Main.java b/src/main/java/de/doubleslash/keeptime/Main.java
@@ -1,3 +1,5 @@
+// Copyright 2019 doubleSlash Net Business GmbH
+
 package de.doubleslash.keeptime;
 
 import java.io.IOException;
diff --git a/src/main/java/de/doubleslash/keeptime/common/BrowserHelper.java b/src/main/java/de/doubleslash/keeptime/common/BrowserHelper.java
@@ -1,3 +1,5 @@
+// Copyright 2019 doubleSlash Net Business GmbH
+
 package de.doubleslash.keeptime.common;
 
 import java.net.MalformedURLException;
diff --git a/src/main/java/de/doubleslash/keeptime/common/ColorHelper.java b/src/main/java/de/doubleslash/keeptime/common/ColorHelper.java
@@ -1,3 +1,5 @@
+// Copyright 2019 doubleSlash Net Business GmbH
+
 package de.doubleslash.keeptime.common;
 
 import javafx.scene.paint.Color;
diff --git a/src/main/java/de/doubleslash/keeptime/common/ConfigParser.java b/src/main/java/de/doubleslash/keeptime/common/ConfigParser.java
@@ -1,3 +1,5 @@
+// Copyright 2019 doubleSlash Net Business GmbH
+
 package de.doubleslash.keeptime.common;
 
 import java.io.File;
diff --git a/src/main/java/de/doubleslash/keeptime/common/DateFormatter.java b/src/main/java/de/doubleslash/keeptime/common/DateFormatter.java
@@ -1,3 +1,5 @@
+// Copyright 2019 doubleSlash Net Business GmbH
+
 package de.doubleslash.keeptime.common;
 
 import java.time.Duration;
diff --git a/src/main/java/de/doubleslash/keeptime/common/DateProvider.java b/src/main/java/de/doubleslash/keeptime/common/DateProvider.java
@@ -1,3 +1,5 @@
+// Copyright 2019 doubleSlash Net Business GmbH
+
 package de.doubleslash.keeptime.common;
 
 import java.time.LocalDateTime;
diff --git a/src/main/java/de/doubleslash/keeptime/common/FileOpenHelper.java b/src/main/java/de/doubleslash/keeptime/common/FileOpenHelper.java
@@ -1,3 +1,5 @@
+// Copyright 2019 doubleSlash Net Business GmbH
+
 package de.doubleslash.keeptime.common;
 
 import java.io.File;
diff --git a/src/main/java/de/doubleslash/keeptime/common/FontProvider.java b/src/main/java/de/doubleslash/keeptime/common/FontProvider.java
@@ -1,3 +1,5 @@
+// Copyright 2019 doubleSlash Net Business GmbH
+
 package de.doubleslash.keeptime.common;
 
 import javafx.scene.text.Font;
diff --git a/src/main/java/de/doubleslash/keeptime/common/Licenses.java b/src/main/java/de/doubleslash/keeptime/common/Licenses.java
@@ -1,3 +1,5 @@
+// Copyright 2019 doubleSlash Net Business GmbH
+
 package de.doubleslash.keeptime.common;
 
 public enum Licenses {
@@ -13,7 +15,7 @@ public enum Licenses {
    private final String path;
    private final String name;
 
-   Licenses(final String licensePath, final String licenseName) {
+   private Licenses(final String licensePath, final String licenseName) {
       path = licensePath;
       name = licenseName;
    }
diff --git a/src/main/java/de/doubleslash/keeptime/common/OS.java b/src/main/java/de/doubleslash/keeptime/common/OS.java
@@ -1,3 +1,5 @@
+// Copyright 2019 doubleSlash Net Business GmbH
+
 package de.doubleslash.keeptime.common;
 
 public class OS {
diff --git a/src/main/java/de/doubleslash/keeptime/common/RealDateProvider.java b/src/main/java/de/doubleslash/keeptime/common/RealDateProvider.java
@@ -1,3 +1,5 @@
+// Copyright 2019 doubleSlash Net Business GmbH
+
 package de.doubleslash.keeptime.common;
 
 import java.time.LocalDateTime;
diff --git a/src/main/java/de/doubleslash/keeptime/common/Resources.java b/src/main/java/de/doubleslash/keeptime/common/Resources.java
@@ -1,3 +1,5 @@
+// Copyright 2019 doubleSlash Net Business GmbH
+
 package de.doubleslash.keeptime.common;
 
 import java.net.URL;
diff --git a/src/main/java/de/doubleslash/keeptime/controller/Controller.java b/src/main/java/de/doubleslash/keeptime/controller/Controller.java
@@ -1,3 +1,5 @@
+// Copyright 2019 doubleSlash Net Business GmbH
+
 package de.doubleslash.keeptime.controller;
 
 import java.time.Duration;
@@ -164,13 +166,13 @@ public void editProject(final Project p, final String newName, final Color newCo
     * Changes the indexes of the originalList parameter to have a consistent order.
     * 
     * @param originalList
-    *                          list of all projects to adapt the indexes for
+    *           list of all projects to adapt the indexes for
     * @param changedProject
-    *                          the project which has changed which already has the new index
+    *           the project which has changed which already has the new index
     * @param oldIndex
-    *                          the old index of the changed project
+    *           the old index of the changed project
     * @param newIndex
-    *                          the new index of the changed project (which the projects also already has)
+    *           the new index of the changed project (which the projects also already has)
     * @return all projects whose index has been adapted
     */
    List<Project> resortProjectIndexes(final List<Project> originalList, final Project changedProject,
@@ -207,9 +209,9 @@ List<Project> resortProjectIndexes(final List<Project> originalList, final Proje
     * Decreases all indexes by one, after the removed index
     * 
     * @param originalList
-    *                        list of all projects to adapt the indexes for
+    *           list of all projects to adapt the indexes for
     * @param removedIndex
-    *                        the index which has been removed
+    *           the index which has been removed
     * @return all projects whose index has been adapted
     */
    List<Project> adaptProjectIndexesAfterRemoving(final List<Project> originalList, final int removedIndex) {
diff --git a/src/main/java/de/doubleslash/keeptime/exceptions/FXMLLoaderException.java b/src/main/java/de/doubleslash/keeptime/exceptions/FXMLLoaderException.java
@@ -1,3 +1,5 @@
+// Copyright 2019 doubleSlash Net Business GmbH
+
 package de.doubleslash.keeptime.exceptions;
 
 public class FXMLLoaderException extends RuntimeException {
diff --git a/src/main/java/de/doubleslash/keeptime/model/LicenceTableRow.java b/src/main/java/de/doubleslash/keeptime/model/LicenceTableRow.java
@@ -1,3 +1,5 @@
+// Copyright 2019 doubleSlash Net Business GmbH
+
 package de.doubleslash.keeptime.model;
 
 import de.doubleslash.keeptime.common.Licenses;
diff --git a/src/main/java/de/doubleslash/keeptime/model/Model.java b/src/main/java/de/doubleslash/keeptime/model/Model.java
@@ -1,3 +1,5 @@
+// Copyright 2019 doubleSlash Net Business GmbH
+
 package de.doubleslash.keeptime.model;
 
 import java.util.Comparator;
diff --git a/src/main/java/de/doubleslash/keeptime/model/Project.java b/src/main/java/de/doubleslash/keeptime/model/Project.java
@@ -1,3 +1,5 @@
+// Copyright 2019 doubleSlash Net Business GmbH
+
 package de.doubleslash.keeptime.model;
 
 import javax.persistence.Column;
diff --git a/src/main/java/de/doubleslash/keeptime/model/Settings.java b/src/main/java/de/doubleslash/keeptime/model/Settings.java
@@ -1,3 +1,5 @@
+// Copyright 2019 doubleSlash Net Business GmbH
+
 package de.doubleslash.keeptime.model;
 
 import javax.persistence.Column;
diff --git a/src/main/java/de/doubleslash/keeptime/model/Work.java b/src/main/java/de/doubleslash/keeptime/model/Work.java
@@ -1,3 +1,5 @@
+// Copyright 2019 doubleSlash Net Business GmbH
+
 package de.doubleslash.keeptime.model;
 
 import java.time.LocalDate;
diff --git a/src/main/java/de/doubleslash/keeptime/model/persistenceconverter/ColorConverter.java b/src/main/java/de/doubleslash/keeptime/model/persistenceconverter/ColorConverter.java
@@ -1,3 +1,5 @@
+// Copyright 2019 doubleSlash Net Business GmbH
+
 package de.doubleslash.keeptime.model.persistenceconverter;
 
 import javax.persistence.AttributeConverter;
diff --git a/src/main/java/de/doubleslash/keeptime/model/repos/ProjectRepository.java b/src/main/java/de/doubleslash/keeptime/model/repos/ProjectRepository.java
@@ -1,3 +1,5 @@
+// Copyright 2019 doubleSlash Net Business GmbH
+
 package de.doubleslash.keeptime.model.repos;
 
 import org.springframework.data.jpa.repository.JpaRepository;
diff --git a/src/main/java/de/doubleslash/keeptime/model/repos/SettingsRepository.java b/src/main/java/de/doubleslash/keeptime/model/repos/SettingsRepository.java
@@ -1,3 +1,5 @@
+// Copyright 2019 doubleSlash Net Business GmbH
+
 package de.doubleslash.keeptime.model.repos;
 
 import org.springframework.data.jpa.repository.JpaRepository;
diff --git a/src/main/java/de/doubleslash/keeptime/model/repos/WorkRepository.java b/src/main/java/de/doubleslash/keeptime/model/repos/WorkRepository.java
@@ -1,3 +1,5 @@
+// Copyright 2019 doubleSlash Net Business GmbH
+
 package de.doubleslash.keeptime.model.repos;
 
 import java.time.LocalDate;
diff --git a/src/main/java/de/doubleslash/keeptime/view/AboutController.java b/src/main/java/de/doubleslash/keeptime/view/AboutController.java
@@ -1,3 +1,5 @@
+// Copyright 2019 doubleSlash Net Business GmbH
+
 package de.doubleslash.keeptime.view;
 
 import org.slf4j.Logger;
@@ -14,16 +16,18 @@
 import javafx.scene.control.Button;
 import javafx.scene.control.Hyperlink;
 import javafx.scene.control.Label;
+import javafx.scene.control.TableCell;
 import javafx.scene.control.TableColumn;
-import javafx.scene.control.TableRow;
 import javafx.scene.control.TableView;
 import javafx.scene.control.cell.PropertyValueFactory;
 import javafx.scene.input.MouseButton;
+import javafx.scene.paint.Color;
 
 public class AboutController {
 
    private static final String GITHUB_PAGE = "https://www.github.com/doubleSlashde/KeepTime";
    private static final String GITHUB_ISSUE_PAGE = GITHUB_PAGE + "/issues";
+   private static final Color HYPERLINK_COLOR = Color.rgb(0, 115, 170);
 
    private final FileOpenHelper fileOpen = new FileOpenHelper();
    private final BrowserHelper browserOpen = new BrowserHelper();
@@ -40,7 +44,7 @@ public class AboutController {
    @FXML
    private TableView<LicenceTableRow> licenseTableView;
 
-   public static final Logger LOG = LoggerFactory.getLogger(AboutController.class);
+   private static final Logger LOG = LoggerFactory.getLogger(AboutController.class);
 
    @FXML
    public void initialize() {
@@ -52,12 +56,36 @@ public void initialize() {
       TableColumn<LicenceTableRow, String> nameColumn;
       nameColumn = new TableColumn<>("Name");
       nameColumn.setMinWidth(160);
+
       nameColumn.setCellValueFactory(new PropertyValueFactory<>("name"));
 
       // licenseColumn
-      TableColumn<LicenceTableRow, String> licenseColumn;
-      licenseColumn = new TableColumn<>("License");
+      final TableColumn<LicenceTableRow, String> licenseColumn = new TableColumn<>("License");
       licenseColumn.setMinWidth(260);
+      licenseColumn.setCellFactory(param -> new TableCell<LicenceTableRow, String>() {
+         @Override
+         protected void updateItem(final String item, final boolean empty) {
+            super.updateItem(item, empty);
+
+            setText(empty ? null : item);
+            setTextFill(HYPERLINK_COLOR);
+
+            setOnMouseEntered(e -> setUnderline(true));
+
+            setOnMouseExited(e -> setUnderline(false));
+
+            setOnMouseClicked(e -> {
+               if (!empty && e.getButton() == MouseButton.PRIMARY) {
+                  final LicenceTableRow row = (LicenceTableRow) getTableRow().getItem();
+                  final Licenses license = row.getLicense();
+                  LOG.debug("License file name: {}", license);
+
+                  fileOpen.openFile(license.getPath());
+                  // TODO show error if file does not exist
+               }
+            });
+         }
+      });
       licenseColumn.setCellValueFactory(new PropertyValueFactory<>("licenseName"));
 
       final ObservableList<LicenceTableRow> licenses = loadRows();
@@ -67,22 +95,6 @@ public void initialize() {
       licenseTableView.getColumns().add(nameColumn);
       licenseTableView.getColumns().add(licenseColumn);
 
-      LOG.debug("tablerow setonaction");
-      licenseTableView.setRowFactory(tv -> {
-         LOG.info("table row clicked");
-         final TableRow<LicenceTableRow> row = new TableRow<>();
-         row.setOnMouseClicked(event -> {
-            if (!row.isEmpty() && event.getButton() == MouseButton.PRIMARY && event.getClickCount() == 2) {
-               final LicenceTableRow clickedRow = row.getItem();
-               final Licenses license = clickedRow.getLicense();
-               LOG.debug("License file name: {}", license);
-
-               fileOpen.openFile(license.getPath());
-            }
-         });
-         return row;
-      });
-
       LOG.debug("hyperlink setonaction");
       gitHubHyperlink.setOnAction(ae -> {
          LOG.debug("hyperlink clicked");
diff --git a/src/main/java/de/doubleslash/keeptime/view/ProjectReport.java b/src/main/java/de/doubleslash/keeptime/view/ProjectReport.java
@@ -1,3 +1,5 @@
+// Copyright 2019 doubleSlash Net Business GmbH
+
 package de.doubleslash.keeptime.view;
 
 import static de.doubleslash.keeptime.view.ReportController.EMPTY_NOTE;
diff --git a/src/main/java/de/doubleslash/keeptime/view/ReportController.java b/src/main/java/de/doubleslash/keeptime/view/ReportController.java
@@ -1,3 +1,5 @@
+// Copyright 2019 doubleSlash Net Business GmbH
+
 package de.doubleslash.keeptime.view;
 
 import java.time.LocalDate;
diff --git a/src/main/java/de/doubleslash/keeptime/view/SettingsController.java b/src/main/java/de/doubleslash/keeptime/view/SettingsController.java
@@ -1,3 +1,5 @@
+// Copyright 2019 doubleSlash Net Business GmbH
+
 package de.doubleslash.keeptime.view;
 
 import java.io.File;
diff --git a/src/main/java/de/doubleslash/keeptime/view/ViewController.java b/src/main/java/de/doubleslash/keeptime/view/ViewController.java
@@ -1,3 +1,5 @@
+// Copyright 2019 doubleSlash Net Business GmbH
+
 package de.doubleslash.keeptime.view;
 
 import java.awt.image.BufferedImage;
diff --git a/src/main/java/de/doubleslash/keeptime/view/time/CallBackListener.java b/src/main/java/de/doubleslash/keeptime/view/time/CallBackListener.java
@@ -1,3 +1,5 @@
+// Copyright 2019 doubleSlash Net Business GmbH
+
 package de.doubleslash.keeptime.view.time;
 
 public interface CallBackListener {
diff --git a/src/main/java/de/doubleslash/keeptime/view/time/Interval.java b/src/main/java/de/doubleslash/keeptime/view/time/Interval.java
@@ -1,3 +1,5 @@
+// Copyright 2019 doubleSlash Net Business GmbH
+
 package de.doubleslash.keeptime.view.time;
 
 import java.time.LocalDateTime;
diff --git a/src/main/java/de/doubleslash/keeptime/viewpopup/GlobalScreenListener.java b/src/main/java/de/doubleslash/keeptime/viewpopup/GlobalScreenListener.java
@@ -1,3 +1,5 @@
+// Copyright 2019 doubleSlash Net Business GmbH
+
 package de.doubleslash.keeptime.viewpopup;
 
 import java.awt.Point;
diff --git a/src/main/java/de/doubleslash/keeptime/viewpopup/ViewControllerPopup.java b/src/main/java/de/doubleslash/keeptime/viewpopup/ViewControllerPopup.java
@@ -1,3 +1,5 @@
+// Copyright 2019 doubleSlash Net Business GmbH
+
 package de.doubleslash.keeptime.viewpopup;
 
 import java.awt.Point;
diff --git a/src/main/resources/application.properties b/src/main/resources/application.properties
@@ -1,3 +1,5 @@
+# Copyright 2019 doubleSlash Net Business GmbH
+
 # H2
 spring.h2.console.enabled=true
 spring.h2.console.path=/h2
diff --git a/src/main/resources/css/application.css b/src/main/resources/css/application.css
@@ -1,4 +1,5 @@
-/* JavaFX CSS - Leave this comment until you have at least create one rule which uses -fx-Property */
+/* Copyright 2019 doubleSlash Net Business GmbH
+ * JavaFX CSS - Leave this comment until you have at least create one rule which uses -fx-Property */
 .text-area {
 	-fx-text-fill: rgba(1,1,1,.5);
     -fx-background-color: rgba(0,0,0,0);
diff --git a/src/main/resources/css/menu.css b/src/main/resources/css/menu.css
@@ -1,3 +1,5 @@
+/* Copyright 2019 doubleSlash Net Business GmbH */
+
 .menuBorder {
 	-fx-border-color: rgba(180,180,180,1);
 	-fx-padding: 2px;
diff --git a/src/main/resources/layouts/ProjectDetailLayout.fxml b/src/main/resources/layouts/ProjectDetailLayout.fxml
@@ -1,3 +1,4 @@
+<!-- Copyright 2019 doubleSlash Net Business GmbH -->
 <?xml version="1.0" encoding="UTF-8"?>
 
 <?import java.lang.*?>
diff --git a/src/main/resources/layouts/ViewLayout.fxml b/src/main/resources/layouts/ViewLayout.fxml
@@ -1,3 +1,5 @@
+<!-- Copyright 2019 doubleSlash Net Business GmbH -->
+
 <?xml version="1.0" encoding="UTF-8"?>
 
 <?import java.lang.*?>
diff --git a/src/main/resources/layouts/ViewLayoutPopup.fxml b/src/main/resources/layouts/ViewLayoutPopup.fxml
@@ -1,3 +1,5 @@
+<!-- Copyright 2019 doubleSlash Net Business GmbH -->
+
 <?xml version="1.0" encoding="UTF-8"?>
 
 <?import java.lang.*?>
diff --git a/src/main/resources/layouts/about.fxml b/src/main/resources/layouts/about.fxml
diff --git a/src/main/resources/layouts/report.fxml b/src/main/resources/layouts/report.fxml
diff --git a/src/main/resources/layouts/settings.fxml b/src/main/resources/layouts/settings.fxml
diff --git a/src/main/resources/logback.xml b/src/main/resources/logback.xml
diff --git a/src/test/java/de/doubleslash/keeptime/common/ConfigParserTest.java b/src/test/java/de/doubleslash/keeptime/common/ConfigParserTest.java
diff --git a/src/test/java/de/doubleslash/keeptime/common/DateFormatterTest.java b/src/test/java/de/doubleslash/keeptime/common/DateFormatterTest.java
diff --git a/src/test/java/de/doubleslash/keeptime/controller/ControllerTest.java b/src/test/java/de/doubleslash/keeptime/controller/ControllerTest.java
diff --git a/src/test/java/de/doubleslash/keeptime/view/ProjectReportTest.java b/src/test/java/de/doubleslash/keeptime/view/ProjectReportTest.java

Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,5 @@`
	`1`	`+<!-- Copyright 2019 doubleSlash Net Business GmbH -->`
	`2`	`+`
`1`	`3`	`<assembly xmlns="http://maven.apache.org/ASSEMBLY/2.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"`
`2`	`4`	`xsi:schemaLocation="http://maven.apache.org/ASSEMBLY/2.0.0 http://maven.apache.org/xsd/assembly-2.0.0.xsd">`
`3`	`5`
Original file line number	Diff line number	Diff line change
`@@ -1 +1,2 @@`
	`1`	`+# Copyright 2019 doubleSlash Net Business GmbH`
`1`	`2`	`start "" "javaw" -Dprism.order=sw -jar keeptime-v1.0.0.jar`
Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,5 @@`
	`1`	`+# Copyright 2019 doubleSlash Net Business GmbH`
	`2`	`+`
`1`	`3`	`#Thu Jul 05 16:50:17 CEST 2018`
`2`	`4`	`.level=INFO`
`3`	`5`	`application.Log$ConsoleHandler.format={8_level} \| {message_80} {time} {origin} \n{exception}`
Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,5 @@`
	`1`	`+// Copyright 2019 doubleSlash Net Business GmbH`
	`2`	`+`
`1`	`3`	`package de.doubleslash.keeptime;`
`2`	`4`
`3`	`5`	`import java.lang.Thread.UncaughtExceptionHandler;`
Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,5 @@`
	`1`	`+// Copyright 2019 doubleSlash Net Business GmbH`
	`2`	`+`
`1`	`3`	`package de.doubleslash.keeptime.common;`
`2`	`4`
`3`	`5`	`import java.net.MalformedURLException;`